From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109AbdLFOpp (ORCPT ); Wed, 6 Dec 2017 09:45:45 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33655 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbdLFOpk (ORCPT ); Wed, 6 Dec 2017 09:45:40 -0500 X-Google-Smtp-Source: AGs4zMYky3zP7FLXTyvdNBREUuCylXRva4xyBTDWqFFm7kNMqLw6e+cZ3h40Ida8qTQ66gznbQ2Fuw== From: Takuo Koguchi X-Google-Original-From: Takuo Koguchi To: lkml@vger.kernel.org, khoroshilov@ispras.ru, takuo.koguchi.sw@gmail.com Cc: Takuo Koguchi , Mark Brown , Maxime Ripard , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: sun4i: disable clocks in the remove function Date: Thu, 7 Dec 2017 00:22:13 +0900 Message-Id: <1512573752-13091-1-git-send-email-takuo.koguchi.sw@hitachi.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mclk and hclk need to be disabled explicitly since pm_runtime_disable does not disable the clocks. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi --- drivers/spi/spi-sun4i.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index c5cd635..9011c09 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,6 +525,11 @@ static int sun4i_spi_probe(struct platform_device *pdev) static int sun4i_spi_remove(struct platform_device *pdev) { + struct spi_master *master = dev_get_drvdata(&pdev->dev); + struct sun4i_spi *sspi = spi_master_get_devdata(master); + + clk_disable_unprepare(sspi->mclk); + clk_disable_unprepare(sspi->hclk); pm_runtime_disable(&pdev->dev); return 0; -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: takuo.koguchi@gmail.com (Takuo Koguchi) Date: Thu, 7 Dec 2017 00:22:13 +0900 Subject: [PATCH] spi: sun4i: disable clocks in the remove function Message-ID: <1512573752-13091-1-git-send-email-takuo.koguchi.sw@hitachi.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org mclk and hclk need to be disabled explicitly since pm_runtime_disable does not disable the clocks. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi --- drivers/spi/spi-sun4i.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index c5cd635..9011c09 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,6 +525,11 @@ static int sun4i_spi_probe(struct platform_device *pdev) static int sun4i_spi_remove(struct platform_device *pdev) { + struct spi_master *master = dev_get_drvdata(&pdev->dev); + struct sun4i_spi *sspi = spi_master_get_devdata(master); + + clk_disable_unprepare(sspi->mclk); + clk_disable_unprepare(sspi->hclk); pm_runtime_disable(&pdev->dev); return 0; -- 2.7.4