All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Unwind i915_gem_init() failure
Date: Fri, 08 Dec 2017 00:29:53 +0000	[thread overview]
Message-ID: <151269299367.24060.3743848123612648297@mail.alporthouse.com> (raw)
In-Reply-To: <20171207235625.9135-1-chris@chris-wilson.co.uk>

Quoting Chris Wilson (2017-12-07 23:56:25)
> Since Michal introduced new errors other than -EIO during
> i915_gem_init(), we need to actually unwind on the error path as we have
> to abort the module load (and we expect to do so cleanly!).
> 
> As we now teardown key state and then mark the driver as wedged (on
> EIO), we have to be careful to not allow ourselves to resume and
> unwedge, thus attempting to use the uninitialised driver.

Hmm, I don't think this is sufficient just yet, e.g. execbuf should now
report -EINVAL for the absent engine as opposed to -EIO we expect.
Context allocation will still hit uninitialised idr etc.

Back to the plan of having if (ret != -EIO) at each point, I guess.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-12-08  0:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 23:56 [PATCH] drm/i915: Unwind i915_gem_init() failure Chris Wilson
2017-12-08  0:20 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-08  0:29 ` Chris Wilson [this message]
2017-12-08  1:17 ` [PATCH v2] " Chris Wilson
2017-12-08 22:32   ` Michał Winiarski
2017-12-08 22:46     ` Chris Wilson
2017-12-08  1:53 ` ✓ Fi.CI.BAT: success for drm/i915: Unwind i915_gem_init() failure (rev2) Patchwork
2017-12-08  2:17 ` ✗ Fi.CI.IGT: warning for drm/i915: Unwind i915_gem_init() failure Patchwork
2017-12-08  3:34 ` ✗ Fi.CI.IGT: failure for drm/i915: Unwind i915_gem_init() failure (rev2) Patchwork
2017-12-11 11:19 ` [PATCH v3] drm/i915: Unwind i915_gem_init() failure Chris Wilson
2017-12-11 13:04 ` ✓ Fi.CI.BAT: success for drm/i915: Unwind i915_gem_init() failure (rev3) Patchwork
2017-12-11 13:17   ` Chris Wilson
2017-12-11 14:27 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-12-13 13:43 ` [PATCH v3] drm/i915: Unwind i915_gem_init() failure Chris Wilson
2017-12-13 15:55 ` ✓ Fi.CI.BAT: success for drm/i915: Unwind i915_gem_init() failure (rev4) Patchwork
2017-12-13 18:26 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-13 18:56   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151269299367.24060.3743848123612648297@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.