From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v5 2/2] sock: Move the socket inuse to namespace.
Date: Thu, 07 Dec 2017 21:40:58 -0800
Message-ID: <1512711658.25033.23.camel@gmail.com>
References: <1512665148-2413-1-git-send-email-xiangxia.m.yue@gmail.com>
         <1512665148-2413-2-git-send-email-xiangxia.m.yue@gmail.com>
         <1512667208.25033.13.camel@gmail.com>
         <CAMDZJNXPtcNf4zHjbkJWwfvToXt-i7mxfm5VDf+0FSR4ZFV_Hg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: David Miller <davem@davemloft.net>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Willem de Bruijn <willemb@google.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f68.google.com ([209.85.214.68]:43621 "EHLO
        mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751061AbdLHFlB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 8 Dec 2017 00:41:01 -0500
Received: by mail-it0-f68.google.com with SMTP id u62so2557125ita.2
        for <netdev@vger.kernel.org>; Thu, 07 Dec 2017 21:41:01 -0800 (PST)
In-Reply-To: <CAMDZJNXPtcNf4zHjbkJWwfvToXt-i7mxfm5VDf+0FSR4ZFV_Hg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 2017-12-08 at 13:28 +0800, Tonghao Zhang wrote:
> On Fri, Dec 8, 2017 at 1:20 AM, Eric Dumazet <eric.dumazet@gmail.com>
> wrote:
> > On Thu, 2017-12-07 at 08:45 -0800, Tonghao Zhang wrote:
> > > In some case, we want to know how many sockets are in use in
> > > different _net_ namespaces. It's a key resource metric.
> > > 
> > 
> > ...
> > 
> > > +static void sock_inuse_add(struct net *net, int val)
> > > +{
> > > +     if (net->core.prot_inuse)
> > > +             this_cpu_add(*net->core.sock_inuse, val);
> > > +}
> > 
> > This is very confusing.
> > 
> > Why testing net->core.prot_inuse for NULL is needed at all ?
> > 
> > Why not testing net->core.sock_inuse instead ?
> > 
> 
> Hi Eric and Cong, oh it's a typo. it's net->core.sock_inuse there.
> Why
> we should check the net->core.sock_inuse
> Now show you the code:
> 
> cleanup_net will call all of the network namespace exit methods,
> rcu_barrier, and then remove the _net_ namespace.
> 
> cleanup_net:
>     list_for_each_entry_reverse(ops, &pernet_list, list)
>          ops_exit_list(ops, &net_exit_list);
> 
>     rcu_barrier(); /* for netlink sock, the ‘deferred_put_nlk_sk’
> will
> be called. But sock_inuse has been released. */


Thats would be a bug.

Please find another way, but we want ultimately to check that before
net->core.sock_inuse is freed, folding the inuse count on all cpus is
0, to make sure we do not have a bug somewhere.

We should not have to test if net->core.sock_inuse is NULL or not from
sock_inuse_add(). Pointer must be there all the time.

The freeing should only happen once we are sure sock_inuse_add() can
not be called anymore.

> 
> 
>     /* Finally it is safe to free my network namespace structure */
>     list_for_each_entry_safe(net, tmp, &net_exit_list, exit_list) {}
> 
> 
> 
> Release the netlink sock created in kernel(not hold the _net_
> namespace):
> 
> netlink_release
>        call_rcu(&nlk->rcu, deferred_put_nlk_sk);
> 
> deferred_put_nlk_sk
>        sk_free(sk);
> 
> 
> I may add a comment for sock_inuse_add in v6.