From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jackie Li <yaodong.li@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 4/5] drm/i915/guc: Add WOPCM partitioning support for CNL
Date: Fri, 08 Dec 2017 23:03:28 +0000 [thread overview]
Message-ID: <151277420839.16951.720666012736408695@mail.alporthouse.com> (raw)
In-Reply-To: <1512769312-21993-4-git-send-email-yaodong.li@intel.com>
Quoting Jackie Li (2017-12-08 21:41:51)
> +static inline int cnl_a0_wopcm_size_check(struct drm_i915_private *i915)
> +{
> + struct intel_guc_wopcm *wopcm = &i915->guc.wopcm;
> + u32 huc_size = intel_uc_fw_get_size(&i915->huc.fw);
> +
> + /*
> + * On CNL A0, hardware requires guc size to be larger than or equal to
> + * HuC kernel size.
> + */
I couldn't find anything that told me that wopcm->size had to be greater
than GEN10_GUC_WOPCM_OFFSET. Either that is always true by construction,
in which case GEM_BUG_ON() here, or it may be too small in which case
add the test.
> + if ((wopcm->size - GEN10_GUC_WOPCM_OFFSET) < huc_size)
((((Do) you) like) brackets)?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-08 23:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 21:41 [PATCH v3 1/5] drm/i915/guc: Move GuC WOPCM related code into separate files Jackie Li
2017-12-08 21:41 ` [PATCH v3 2/5] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset Jackie Li
2017-12-08 21:41 ` [PATCH v3 3/5] drm/i915/guc: Implement dynamic WOPCM partitioning Jackie Li
2017-12-08 21:57 ` Chris Wilson
2017-12-08 22:47 ` Yaodong Li
2017-12-08 21:41 ` [PATCH v3 4/5] drm/i915/guc: Add WOPCM partitioning support for CNL Jackie Li
2017-12-08 23:03 ` Chris Wilson [this message]
2017-12-12 0:16 ` Yaodong Li
2017-12-08 21:41 ` [PATCH v3 5/5] HAX Enable GuC Submission for CI Jackie Li
2017-12-08 22:30 ` ✗ Fi.CI.BAT: failure for series starting with [v3,1/5] drm/i915/guc: Move GuC WOPCM related code into separate files Patchwork
2017-12-11 9:31 ` [PATCH v3 1/5] " Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151277420839.16951.720666012736408695@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=yaodong.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.