From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753784AbdLIDlG (ORCPT ); Fri, 8 Dec 2017 22:41:06 -0500 Received: from esa1.dell-outbound.iphmx.com ([68.232.153.90]:39684 "EHLO esa1.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752960AbdLIDlC (ORCPT ); Fri, 8 Dec 2017 22:41:02 -0500 IronPort-PHdr: =?us-ascii?q?9a23=3AWXPG5BYXMb0EJmaVn+4qhaf/LSx+4OfEezUN459i?= =?us-ascii?q?sYplN5qZr8W6bnLW6fgltlLVR4KTs6sC0LuG9fi4EUU7or+5+EgYd5JNUxJXwe?= =?us-ascii?q?43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRp?= =?us-ascii?q?OOv1BpTSj8Oq3Oyu5pHfeQtFiT6+bL9oMBm6sRjau9ULj4dlNqs/0AbCrGFSe+?= =?us-ascii?q?RRy2NoJFaTkAj568yt4pNt8Dletuw4+cJYXqr0Y6o3TbpDDDQ7KG81/9HktQPC?= =?us-ascii?q?TQSU+HQRVHgdnwdSDAjE6BH6WYrxsjf/u+Fg1iSWIdH6QLYpUjmk8qxlSgLniD?= =?us-ascii?q?0fOjA57m/Zl9BwgqxYrhKvpRN/wpLbbo6aO/dlYqPdZMkXSXZdUspNSiBMBJ63?= =?us-ascii?q?YYsVD+oGOOZVt47wqVwUohukBAmsA/njxDlJhn/z2q061fguEQDY0wwkG9IOt2?= =?us-ascii?q?/Zo8jrO6cWVeC51rXHzTLGb/5P3zr29YvGcgg5rPyNXr98a9TdxEcxGw/fk1md?= =?us-ascii?q?qYLoMymL2ugRrWSX9/dsWf61h2I6pAx8rCKjytkjh4XXnI4YyFDJ+T1kzIs6K9?= =?us-ascii?q?C0UlN3bN+lHZdKtCyXN5F6Tt0+T210visx16cItoShfCcQzZQq3xvfa/uafIeW?= =?us-ascii?q?+h/jT+ORIStghHJiZbK/mw6+8Ui+xe34Ucm5yEhFrjFfndXSrHwCygLc6syDSv?= =?us-ascii?q?dk+UehxCqP2BvU6uFZJ0A7iLTXJ4Qgwr4olpoTtEvCEjXql0Xxia+abkQk+u62?= =?us-ascii?q?5OT7erjrp5yRO5VqhgzwLKgigNGzDOQ2PwQUQWSX5fqw2KXm/ULjQbVKivM2kr?= =?us-ascii?q?PesJDfPckVobS2AxVU0oYk8RqxCTam0NEfnXkBMF1FeQyIj4ztO1HJO/33EOmw?= =?us-ascii?q?g1CokDtx2//GObjhDo3XLnffiLfhYap960lExQo3zNBf4Y9UC74YLPLwREDxrt?= =?us-ascii?q?rYAQE9MwGv3ebnB8ty1pkEVWKMHKCZKqXSvkGM5u41JOmMfoAVsi7nK/c5//7u?= =?us-ascii?q?kWM5mVgFcKmx2ZsYcmy4HvphI0WDZHrgm8oOEX0LvgogUuPqkkSOUDFQanuzRK?= =?us-ascii?q?88+D47B5y8DYvZRYCinqaB3CGlEZ1SfGxGDUqMEXi7P7mDDqMIdT6VCsZkmzcN?= =?us-ascii?q?Tbm9Qotn0xyy4lzU0b1ie77x8zcZstTH1d1y4ebSmBU28hR4AsCZlWqKSjcnzS?= =?us-ascii?q?szWzYq0fUn8gRGwVCZ3P0gjg=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2FfAwD2Witah8qZ6ERSChkBAQEBAQEBA?= =?us-ascii?q?QEBAQEHAQEBAQGEFIEEJweGR5ZTgX2CAYJBAQKUXAqFOwKEX0IVAQEBAQEBAQE?= =?us-ascii?q?BAQIQAQEBCgsJCCgvgjgigkkBAQEBAgEnUhACAQgYCSUPSAIEDgWKIAipEzqKb?= =?us-ascii?q?AELASWDW4ILgz+DK4R0K0yFDCAFkliQMJUgk2GWXIE7NYFzb4J4glIQDBmBTni?= =?us-ascii?q?JM4EVAQEB?= X-IPAS-Result: =?us-ascii?q?A2FfAwD2Witah8qZ6ERSChkBAQEBAQEBAQEBAQEHAQEBAQG?= =?us-ascii?q?EFIEEJweGR5ZTgX2CAYJBAQKUXAqFOwKEX0IVAQEBAQEBAQEBAQIQAQEBCgsJC?= =?us-ascii?q?CgvgjgigkkBAQEBAgEnUhACAQgYCSUPSAIEDgWKIAipEzqKbAELASWDW4ILgz+?= =?us-ascii?q?DK4R0K0yFDCAFkliQMJUgk2GWXIE7NYFzb4J4glIQDBmBTniJM4EVAQEB?= From: X-LoopCount0: from 10.166.132.152 X-IronPort-AV: E=Sophos;i="5.45,380,1508821200"; d="scan'208";a="587457169" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , Subject: Re: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device Thread-Topic: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device Thread-Index: AQHTcJZHsnWitN3ZwECtqtaUDYa0OaM6tNGA//+oeCA= Date: Sat, 9 Dec 2017 03:41:00 +0000 Message-ID: <1512790860266.96149@Dell.com> References: <1512786861-1014-1-git-send-email-mario.limonciello@dell.com> <1512786861-1014-2-git-send-email-mario.limonciello@dell.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vB93f9kk023788 >> On Dec 8, 2017, at 6:34 PM, Mario Limonciello wrote: >> >> It's possible for the same GUID to show up on as system twice. >> This means using solely the GUID for identify the file will not >> be sufficient. > >Isn't the file already in a per-bus directory? Yep, but the symlink created in /sys/bus/wmi/devices isn't. That's where the kernel complains about duplicate sysfs attributes. It's not exactly a pretty path I submitted, but it does avoid those collisions. Example (with this in place from /sys/bus/wmi/devices): lrwxrwxrwx 1 root root 0 Dec 8 21:39 PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A -> ../../../devices/platform/PNP0C14:04/wmi_bus/wmi_bus-PNP0C14:04/PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: Re: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device Date: Sat, 9 Dec 2017 03:41:00 +0000 Message-ID: <1512790860266.96149@Dell.com> References: <1512786861-1014-1-git-send-email-mario.limonciello@dell.com> <1512786861-1014-2-git-send-email-mario.limonciello@dell.com>, Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: luto@amacapital.net Cc: dvhart@infradead.org, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, luto@kernel.org List-Id: platform-driver-x86.vger.kernel.org >> On Dec 8, 2017, at 6:34 PM, Mario Limonciello wrote:=0A= >>=0A= >> It's possible for the same GUID to show up on as system twice.=0A= >> This means using solely the GUID for identify the file will not=0A= >> be sufficient.=0A= >=0A= >Isn't the file already in a per-bus directory?=0A= =0A= Yep, but the symlink created in /sys/bus/wmi/devices isn't.=0A= That's where the kernel complains about duplicate sysfs=0A= attributes.=0A= =0A= It's not exactly a pretty path I submitted, but it does avoid=0A= those collisions.=0A= =0A= Example (with this in place from /sys/bus/wmi/devices):=0A= lrwxrwxrwx 1 root root 0 Dec 8 21:39 PNP0C14:04-70FE8229-D03B-4214-A1C6-1F= 884B1A892A -> ../../../devices/platform/PNP0C14:04/wmi_bus/wmi_bus-PNP0C14:= 04/PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A=0A=