* [PATCH v3 0/2] staging: rtl8712: Cleanup codestyle
@ 2017-12-10 4:38 ` Neil Singh
0 siblings, 0 replies; 6+ messages in thread
From: Neil Singh @ 2017-12-10 4:38 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: devel, linux-kernel, driverdev-devel
Cleanup some codestyle issues identified by checkpatch.
Changes since v2:
- Modify patches so they themselves don't trigger the checkpatch
issues CHECK:PARENTHESIS_ALIGNMENT and WARNING:EMAIL_SUBJECT
Changes since v1:
- Split single patch into multiple
Neil Singh (2):
staging: rtl8712: Cleanup codestyle, break up long line
staging: rtl8712: Cleanup codestyle, change spaces to tabs
drivers/staging/rtl8712/rtl871x_security.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 0/2] staging: rtl8712: Cleanup codestyle
@ 2017-12-10 4:38 ` Neil Singh
0 siblings, 0 replies; 6+ messages in thread
From: Neil Singh @ 2017-12-10 4:38 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: devel, driverdev-devel, linux-kernel
Cleanup some codestyle issues identified by checkpatch.
Changes since v2:
- Modify patches so they themselves don't trigger the checkpatch
issues CHECK:PARENTHESIS_ALIGNMENT and WARNING:EMAIL_SUBJECT
Changes since v1:
- Split single patch into multiple
Neil Singh (2):
staging: rtl8712: Cleanup codestyle, break up long line
staging: rtl8712: Cleanup codestyle, change spaces to tabs
drivers/staging/rtl8712/rtl871x_security.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.1.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] staging: rtl8712: Cleanup codestyle, break up long line
2017-12-10 4:38 ` Neil Singh
@ 2017-12-10 4:38 ` Neil Singh
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Singh @ 2017-12-10 4:38 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: devel, linux-kernel, driverdev-devel
Cleanup below checkpatch issue:
WARNING:LONG_LINE: line over 80 characters
1000: FILE: rtl871x_security.c:1000:
+static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
Signed-off-by: Neil Singh <neil2468@gmail.com>
---
drivers/staging/rtl8712/rtl871x_security.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index 56d36f6..630f18f 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -997,8 +997,9 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists,
/* Builds the last MIC header block from */
/* header fields. */
/************************************************/
-static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
- u8 *mpdu, u8 *pn_vector, sint c)
+static void construct_ctr_preload(u8 *ctr_preload,
+ sint a4_exists, sint qc_exists,
+ u8 *mpdu, u8 *pn_vector, sint c)
{
sint i;
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] staging: rtl8712: Cleanup codestyle, break up long line
@ 2017-12-10 4:38 ` Neil Singh
0 siblings, 0 replies; 6+ messages in thread
From: Neil Singh @ 2017-12-10 4:38 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: devel, driverdev-devel, linux-kernel
Cleanup below checkpatch issue:
WARNING:LONG_LINE: line over 80 characters
1000: FILE: rtl871x_security.c:1000:
+static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
Signed-off-by: Neil Singh <neil2468@gmail.com>
---
drivers/staging/rtl8712/rtl871x_security.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index 56d36f6..630f18f 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -997,8 +997,9 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists,
/* Builds the last MIC header block from */
/* header fields. */
/************************************************/
-static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
- u8 *mpdu, u8 *pn_vector, sint c)
+static void construct_ctr_preload(u8 *ctr_preload,
+ sint a4_exists, sint qc_exists,
+ u8 *mpdu, u8 *pn_vector, sint c)
{
sint i;
--
2.1.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] staging: rtl8712: Cleanup codestyle, change spaces to tabs
2017-12-10 4:38 ` Neil Singh
@ 2017-12-10 4:38 ` Neil Singh
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Singh @ 2017-12-10 4:38 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: devel, linux-kernel, driverdev-devel
Cleanup below checkpatch issues:
ERROR:CODE_INDENT: code indent should use tabs where possible
1409: FILE: rtl871x_security.c:1409:
+ from_timer(padapter, t, securitypriv.tkip_timer);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
1409: FILE: rtl871x_security.c:1409:
+ from_timer(padapter, t, securitypriv.tkip_timer);$
Signed-off-by: Neil Singh <neil2468@gmail.com>
---
drivers/staging/rtl8712/rtl871x_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index 630f18f..f459152 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -1406,7 +1406,7 @@ u32 r8712_aes_decrypt(struct _adapter *padapter, u8 *precvframe)
void r8712_use_tkipkey_handler(struct timer_list *t)
{
struct _adapter *padapter =
- from_timer(padapter, t, securitypriv.tkip_timer);
+ from_timer(padapter, t, securitypriv.tkip_timer);
padapter->securitypriv.busetkipkey = true;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] staging: rtl8712: Cleanup codestyle, change spaces to tabs
@ 2017-12-10 4:38 ` Neil Singh
0 siblings, 0 replies; 6+ messages in thread
From: Neil Singh @ 2017-12-10 4:38 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
Cc: devel, driverdev-devel, linux-kernel
Cleanup below checkpatch issues:
ERROR:CODE_INDENT: code indent should use tabs where possible
1409: FILE: rtl871x_security.c:1409:
+ from_timer(padapter, t, securitypriv.tkip_timer);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
1409: FILE: rtl871x_security.c:1409:
+ from_timer(padapter, t, securitypriv.tkip_timer);$
Signed-off-by: Neil Singh <neil2468@gmail.com>
---
drivers/staging/rtl8712/rtl871x_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index 630f18f..f459152 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -1406,7 +1406,7 @@ u32 r8712_aes_decrypt(struct _adapter *padapter, u8 *precvframe)
void r8712_use_tkipkey_handler(struct timer_list *t)
{
struct _adapter *padapter =
- from_timer(padapter, t, securitypriv.tkip_timer);
+ from_timer(padapter, t, securitypriv.tkip_timer);
padapter->securitypriv.busetkipkey = true;
}
--
2.1.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-10 4:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-10 4:38 [PATCH v3 0/2] staging: rtl8712: Cleanup codestyle Neil Singh
2017-12-10 4:38 ` Neil Singh
2017-12-10 4:38 ` [PATCH v3 1/2] staging: rtl8712: Cleanup codestyle, break up long line Neil Singh
2017-12-10 4:38 ` Neil Singh
2017-12-10 4:38 ` [PATCH v3 2/2] staging: rtl8712: Cleanup codestyle, change spaces to tabs Neil Singh
2017-12-10 4:38 ` Neil Singh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.