From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbdLKJe1 (ORCPT ); Mon, 11 Dec 2017 04:34:27 -0500 Received: from mga12.intel.com ([192.55.52.136]:62302 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbdLKJeY (ORCPT ); Mon, 11 Dec 2017 04:34:24 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1776281" Message-ID: <1512984860.5315.17.camel@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use copy_from_user() in fence copying From: Joonas Lahtinen To: Kees Cook , Jason Ekstrand Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Date: Mon, 11 Dec 2017 11:34:20 +0200 In-Reply-To: <20171206202850.GA38365@beast> References: <20171206202850.GA38365@beast> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.2 (3.26.2-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-12-06 at 12:28 -0800, Kees Cook wrote: > There's no good reason to separate the access_ok() from the copy, > especially since the access_ok() size is hard-coded instead of using > sizeof(). Instead, just use copy_from_user() directly. > > Fixes: cf6e7bac6357 ("drm/i915: Add support for drm syncobjs") There's been request to reduce the amount of Fixes: tags that are not actually fixing bugs. This seems more like an optimization. References: has been suggested for these cases instead. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: Use copy_from_user() in fence copying Date: Mon, 11 Dec 2017 11:34:20 +0200 Message-ID: <1512984860.5315.17.camel@linux.intel.com> References: <20171206202850.GA38365@beast> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171206202850.GA38365@beast> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Kees Cook , Jason Ekstrand Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyMDE3LTEyLTA2IGF0IDEyOjI4IC0wODAwLCBLZWVzIENvb2sgd3JvdGU6Cj4gVGhl cmUncyBubyBnb29kIHJlYXNvbiB0byBzZXBhcmF0ZSB0aGUgYWNjZXNzX29rKCkgZnJvbSB0aGUg Y29weSwKPiBlc3BlY2lhbGx5IHNpbmNlIHRoZSBhY2Nlc3Nfb2soKSBzaXplIGlzIGhhcmQtY29k ZWQgaW5zdGVhZCBvZiB1c2luZwo+IHNpemVvZigpLiBJbnN0ZWFkLCBqdXN0IHVzZSBjb3B5X2Zy b21fdXNlcigpIGRpcmVjdGx5Lgo+IAo+IEZpeGVzOiBjZjZlN2JhYzYzNTcgKCJkcm0vaTkxNTog QWRkIHN1cHBvcnQgZm9yIGRybSBzeW5jb2JqcyIpCgpUaGVyZSdzIGJlZW4gcmVxdWVzdCB0byBy ZWR1Y2UgdGhlIGFtb3VudCBvZiBGaXhlczogdGFncyB0aGF0IGFyZSBub3QKYWN0dWFsbHkgZml4 aW5nIGJ1Z3MuIFRoaXMgc2VlbXMgbW9yZSBsaWtlIGFuIG9wdGltaXphdGlvbi4KClJlZmVyZW5j ZXM6IGhhcyBiZWVuIHN1Z2dlc3RlZCBmb3IgdGhlc2UgY2FzZXMgaW5zdGVhZC4KClJlZ2FyZHMs IEpvb25hcwotLSAKSm9vbmFzIExhaHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVy CkludGVsIENvcnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=