* [U-Boot] [PATCH u-boot] ARM: arch-meson: fix writel arguments order
@ 2017-12-12 13:23 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-12-12 13:23 UTC (permalink / raw)
To: u-boot
From: Hans Verkuil <hans.verkuil@cisco.com>
Using writel causes a "Synchronous Abort". Invert the arguments.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm/mach-meson/eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks Hans for finding this stupid error !
Neil
diff --git a/arch/arm/mach-meson/eth.c b/arch/arm/mach-meson/eth.c
index 2debe93..8c6577b 100644
--- a/arch/arm/mach-meson/eth.c
+++ b/arch/arm/mach-meson/eth.c
@@ -38,8 +38,8 @@ void meson_gx_eth_init(phy_interface_t mode, unsigned int flags)
/* Use GXL RMII Internal PHY */
if (IS_ENABLED(CONFIG_MESON_GXL) &&
(flags & MESON_GXL_USE_INTERNAL_RMII_PHY)) {
- writel(GXBB_ETH_REG_2, 0x10110181);
- writel(GXBB_ETH_REG_3, 0xe40908ff);
+ writel(0x10110181, GXBB_ETH_REG_2);
+ writel(0xe40908ff, GXBB_ETH_REG_3);
}
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH u-boot] ARM: arch-meson: fix writel arguments order
@ 2017-12-12 13:23 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-12-12 13:23 UTC (permalink / raw)
To: linus-amlogic
From: Hans Verkuil <hans.verkuil@cisco.com>
Using writel causes a "Synchronous Abort". Invert the arguments.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm/mach-meson/eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks Hans for finding this stupid error !
Neil
diff --git a/arch/arm/mach-meson/eth.c b/arch/arm/mach-meson/eth.c
index 2debe93..8c6577b 100644
--- a/arch/arm/mach-meson/eth.c
+++ b/arch/arm/mach-meson/eth.c
@@ -38,8 +38,8 @@ void meson_gx_eth_init(phy_interface_t mode, unsigned int flags)
/* Use GXL RMII Internal PHY */
if (IS_ENABLED(CONFIG_MESON_GXL) &&
(flags & MESON_GXL_USE_INTERNAL_RMII_PHY)) {
- writel(GXBB_ETH_REG_2, 0x10110181);
- writel(GXBB_ETH_REG_3, 0xe40908ff);
+ writel(0x10110181, GXBB_ETH_REG_2);
+ writel(0xe40908ff, GXBB_ETH_REG_3);
}
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH u-boot] ARM: arch-meson: fix writel arguments order
2017-12-12 13:23 ` Neil Armstrong
@ 2017-12-18 11:57 ` Neil Armstrong
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-12-18 11:57 UTC (permalink / raw)
To: u-boot
On 12/12/2017 14:23, Neil Armstrong wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Using writel causes a "Synchronous Abort". Invert the arguments.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> arch/arm/mach-meson/eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks Hans for finding this stupid error !
>
> Neil
>
> diff --git a/arch/arm/mach-meson/eth.c b/arch/arm/mach-meson/eth.c
> index 2debe93..8c6577b 100644
> --- a/arch/arm/mach-meson/eth.c
> +++ b/arch/arm/mach-meson/eth.c
> @@ -38,8 +38,8 @@ void meson_gx_eth_init(phy_interface_t mode, unsigned int flags)
> /* Use GXL RMII Internal PHY */
> if (IS_ENABLED(CONFIG_MESON_GXL) &&
> (flags & MESON_GXL_USE_INTERNAL_RMII_PHY)) {
> - writel(GXBB_ETH_REG_2, 0x10110181);
> - writel(GXBB_ETH_REG_3, 0xe40908ff);
> + writel(0x10110181, GXBB_ETH_REG_2);
> + writel(0xe40908ff, GXBB_ETH_REG_3);
> }
>
> break;
>
Hi Tom,
Can this be merged ?
This error breaks boot on 3 boards.
Thanks,
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH u-boot] ARM: arch-meson: fix writel arguments order
@ 2017-12-18 11:57 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-12-18 11:57 UTC (permalink / raw)
To: linus-amlogic
On 12/12/2017 14:23, Neil Armstrong wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Using writel causes a "Synchronous Abort". Invert the arguments.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> arch/arm/mach-meson/eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks Hans for finding this stupid error !
>
> Neil
>
> diff --git a/arch/arm/mach-meson/eth.c b/arch/arm/mach-meson/eth.c
> index 2debe93..8c6577b 100644
> --- a/arch/arm/mach-meson/eth.c
> +++ b/arch/arm/mach-meson/eth.c
> @@ -38,8 +38,8 @@ void meson_gx_eth_init(phy_interface_t mode, unsigned int flags)
> /* Use GXL RMII Internal PHY */
> if (IS_ENABLED(CONFIG_MESON_GXL) &&
> (flags & MESON_GXL_USE_INTERNAL_RMII_PHY)) {
> - writel(GXBB_ETH_REG_2, 0x10110181);
> - writel(GXBB_ETH_REG_3, 0xe40908ff);
> + writel(0x10110181, GXBB_ETH_REG_2);
> + writel(0xe40908ff, GXBB_ETH_REG_3);
> }
>
> break;
>
Hi Tom,
Can this be merged ?
This error breaks boot on 3 boards.
Thanks,
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-Boot, u-boot] ARM: arch-meson: fix writel arguments order
2017-12-12 13:23 ` Neil Armstrong
@ 2017-12-18 23:37 ` Tom Rini
-1 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2017-12-18 23:37 UTC (permalink / raw)
To: u-boot
On Tue, Dec 12, 2017 at 02:23:39PM +0100, Neil Armstrong wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Using writel causes a "Synchronous Abort". Invert the arguments.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171218/95339b2f/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot,u-boot] ARM: arch-meson: fix writel arguments order
@ 2017-12-18 23:37 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2017-12-18 23:37 UTC (permalink / raw)
To: linus-amlogic
On Tue, Dec 12, 2017 at 02:23:39PM +0100, Neil Armstrong wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Using writel causes a "Synchronous Abort". Invert the arguments.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20171218/95339b2f/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-18 23:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 13:23 [U-Boot] [PATCH u-boot] ARM: arch-meson: fix writel arguments order Neil Armstrong
2017-12-12 13:23 ` Neil Armstrong
2017-12-18 11:57 ` [U-Boot] " Neil Armstrong
2017-12-18 11:57 ` Neil Armstrong
2017-12-18 23:37 ` [U-Boot] [U-Boot, " Tom Rini
2017-12-18 23:37 ` [U-Boot,u-boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.