From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbdLLOUt (ORCPT ); Tue, 12 Dec 2017 09:20:49 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:42467 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbdLLOUo (ORCPT ); Tue, 12 Dec 2017 09:20:44 -0500 X-Google-Smtp-Source: ACJfBouMjbempx1DBu4vVCaiGiqd8lm6CZyGRMuMTkxqO+A0qBR4ydedHi7ktQSAL0fAvIlgDkIn7w== Message-ID: <1513088442.26438.18.camel@baylibre.com> Subject: Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static From: Jerome Brunet To: Colin King , Andrew Lunn , Florian Fainelli , Carlo Caione , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 Dec 2017 15:20:42 +0100 In-Reply-To: <20171212130311.17185-1-colin.king@canonical.com> References: <20171212130311.17185-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.2 (3.26.2-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote: > From: Colin Ian King > > The function meson_gxl_read_status is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'meson_gxl_read_status' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Indeed, silly mistake, thx for spotting it. Reviewed-by: Jerome Brunet From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Date: Tue, 12 Dec 2017 14:20:42 +0000 Subject: Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static Message-Id: <1513088442.26438.18.camel@baylibre.com> List-Id: References: <20171212130311.17185-1-colin.king@canonical.com> In-Reply-To: <20171212130311.17185-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linus-amlogic@lists.infradead.org On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote: > From: Colin Ian King > > The function meson_gxl_read_status is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'meson_gxl_read_status' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Indeed, silly mistake, thx for spotting it. Reviewed-by: Jerome Brunet From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Tue, 12 Dec 2017 15:20:42 +0100 Subject: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static In-Reply-To: <20171212130311.17185-1-colin.king@canonical.com> References: <20171212130311.17185-1-colin.king@canonical.com> Message-ID: <1513088442.26438.18.camel@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote: > From: Colin Ian King > > The function meson_gxl_read_status is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'meson_gxl_read_status' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Indeed, silly mistake, thx for spotting it. Reviewed-by: Jerome Brunet From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Tue, 12 Dec 2017 15:20:42 +0100 Subject: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static In-Reply-To: <20171212130311.17185-1-colin.king@canonical.com> References: <20171212130311.17185-1-colin.king@canonical.com> Message-ID: <1513088442.26438.18.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote: > From: Colin Ian King > > The function meson_gxl_read_status is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'meson_gxl_read_status' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Indeed, silly mistake, thx for spotting it. Reviewed-by: Jerome Brunet