From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa5.hgst.iphmx.com ([216.71.153.144]:34838 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbdLLWUn (ORCPT ); Tue, 12 Dec 2017 17:20:43 -0500 From: Bart Van Assche To: "tj@kernel.org" , "axboe@kernel.dk" CC: "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "osandov@fb.com" , "linux-block@vger.kernel.org" , "oleg@redhat.com" , "hch@lst.de" Subject: Re: [PATCH 6/6] blk-mq: remove REQ_ATOM_STARTED Date: Tue, 12 Dec 2017 22:20:39 +0000 Message-ID: <1513117238.2999.54.camel@wdc.com> References: <20171212190134.535941-1-tj@kernel.org> <20171212190134.535941-7-tj@kernel.org> In-Reply-To: <20171212190134.535941-7-tj@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org T24gVHVlLCAyMDE3LTEyLTEyIGF0IDExOjAxIC0wODAwLCBUZWp1biBIZW8gd3JvdGU6DQo+IEBA IC00MDksNyArNDA3LDcgQEAgc3RhdGljIHZvaWQgaGN0eF9zaG93X2J1c3lfcnEoc3RydWN0IHJl cXVlc3QgKnJxLCB2b2lkICpkYXRhLCBib29sIHJlc2VydmVkKQ0KPiAgICAgICAgIGNvbnN0IHN0 cnVjdCBzaG93X2J1c3lfcGFyYW1zICpwYXJhbXMgPSBkYXRhOw0KPiAgDQo+ICAgICAgICAgaWYg KGJsa19tcV9tYXBfcXVldWUocnEtPnEsIHJxLT5tcV9jdHgtPmNwdSkgPT0gcGFyYW1zLT5oY3R4 ICYmDQo+IC0gICAgICAgICAgIHRlc3RfYml0KFJFUV9BVE9NX1NUQVJURUQsICZycS0+YXRvbWlj X2ZsYWdzKSkNCj4gKyAgICAgICAgICAgYmxrX21xX3JxX3N0YXRlKHJxKSAhPSBNUV9SUV9JRExF KQ0KPiAgICAgICAgICAgICAgICAgX19ibGtfbXFfZGVidWdmc19ycV9zaG93KHBhcmFtcy0+bSwN Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaXN0X2VudHJ5X3Jx KCZycS0+cXVldWVsaXN0KSk7DQoNClRoZSBhYm92ZSBjb2RlIHNob3VsZCBzaG93IGFsbCByZXF1 ZXN0cyBvd25lZCBieSB0aGUgYmxvY2sgZHJpdmVyLiBQYXRjaA0KImJsay1tcS1kZWJ1Z2ZzOiBB bHNvIHNob3cgcmVxdWVzdHMgdGhhdCBoYXZlIG5vdCB5ZXQgYmVlbiBzdGFydGVkIiAobm90IHll dA0KaW4gSmVucycgdHJlZSkgY2hhbmdlcyB0aGUgUkVRX0FUT01fU1RBUlRFRCB0ZXN0IGludG8g bGlzdF9lbXB0eSgmcnEtPnF1ZXVlbGlzdCkuDQpDYW4gdGhhdCBjaGFuZ2UgYmUgc3VwcG9ydGVk IHdpdGggdGhlIGV4aXN0aW5nIE1RX1JRXyogc3RhdGVzIG9yIHdpbGwgYSBuZXcNCnN0YXRlIGhh dmUgdG8gYmUgaW50cm9kdWNlZCB0byBzdXBwb3J0IHRoaXM/IFNlZSBhbHNvDQpodHRwczovL21h cmMuaW5mby8/bD1saW51eC1ibG9jayZtPTE1MTI1MjE4ODQxMTk5MS4NCg0KVGhhbmtzLA0KDQpC YXJ0Lg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbdLLWUs (ORCPT ); Tue, 12 Dec 2017 17:20:48 -0500 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:34838 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbdLLWUn (ORCPT ); Tue, 12 Dec 2017 17:20:43 -0500 X-IronPort-AV: E=Sophos;i="5.45,395,1508774400"; d="scan'208";a="64815226" From: Bart Van Assche To: "tj@kernel.org" , "axboe@kernel.dk" CC: "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "osandov@fb.com" , "linux-block@vger.kernel.org" , "oleg@redhat.com" , "hch@lst.de" Subject: Re: [PATCH 6/6] blk-mq: remove REQ_ATOM_STARTED Thread-Topic: [PATCH 6/6] blk-mq: remove REQ_ATOM_STARTED Thread-Index: AQHTc3vFMLaUbTF/gU2w2ElGqC9xb6NAR+gA Date: Tue, 12 Dec 2017 22:20:39 +0000 Message-ID: <1513117238.2999.54.camel@wdc.com> References: <20171212190134.535941-1-tj@kernel.org> <20171212190134.535941-7-tj@kernel.org> In-Reply-To: <20171212190134.535941-7-tj@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.171] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1534;20:Vws47m4fWLsp7RrbbMrKirDjLXYEp+DQmlJgQfVcelAEAtiBuuXfiOpZtzzIffcAuAJlzul/INlR1StTO9houtLjrLIWW+SPalO3RTOX906nsOep0G/uGqKlY0zOKKE2E2r/dvXMfHvSa+/jIKQh7SXwXCS2TYuN8jzLJYJPsA0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 073a0350-a6bd-4e03-543d-08d541ae9373 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307);SRVR:CY1PR0401MB1534; x-ms-traffictypediagnostic: CY1PR0401MB1534: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231023)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011);SRVR:CY1PR0401MB1534;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1534; x-forefront-prvs: 051900244E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(39860400002)(376002)(346002)(24454002)(377424004)(189003)(199004)(103116003)(6486002)(229853002)(36756003)(102836003)(6116002)(3846002)(77096006)(81156014)(72206003)(110136005)(4326008)(54906003)(14454004)(966005)(99286004)(8676002)(316002)(478600001)(6436002)(4001150100001)(81166006)(2906002)(5660300001)(3660700001)(53936002)(68736007)(76176011)(25786009)(8936002)(3280700002)(59450400001)(66066001)(2900100001)(6306002)(6512007)(6246003)(7736002)(106356001)(86362001)(105586002)(2950100002)(305945005)(97736004)(2501003)(6506007)(6606295002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1534;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <6884A693B730534FAB9BC191B1E81A19@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 073a0350-a6bd-4e03-543d-08d541ae9373 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2017 22:20:39.4842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1534 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBCMKpFs009079 On Tue, 2017-12-12 at 11:01 -0800, Tejun Heo wrote: > @@ -409,7 +407,7 @@ static void hctx_show_busy_rq(struct request *rq, void *data, bool reserved) > const struct show_busy_params *params = data; > > if (blk_mq_map_queue(rq->q, rq->mq_ctx->cpu) == params->hctx && > - test_bit(REQ_ATOM_STARTED, &rq->atomic_flags)) > + blk_mq_rq_state(rq) != MQ_RQ_IDLE) > __blk_mq_debugfs_rq_show(params->m, > list_entry_rq(&rq->queuelist)); The above code should show all requests owned by the block driver. Patch "blk-mq-debugfs: Also show requests that have not yet been started" (not yet in Jens' tree) changes the REQ_ATOM_STARTED test into list_empty(&rq->queuelist). Can that change be supported with the existing MQ_RQ_* states or will a new state have to be introduced to support this? See also https://marc.info/?l=linux-block&m=151252188411991. Thanks, Bart.