From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "tj@kernel.org" , "axboe@kernel.dk" CC: "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "osandov@fb.com" , "linux-block@vger.kernel.org" , "oleg@redhat.com" , "hch@lst.de" Subject: Re: [PATCH 4/6] blk-mq: make blk_abort_request() trigger timeout path Date: Thu, 14 Dec 2017 18:56:55 +0000 Message-ID: <1513277814.2475.45.camel@wdc.com> References: <20171212190134.535941-1-tj@kernel.org> <20171212190134.535941-5-tj@kernel.org> In-Reply-To: <20171212190134.535941-5-tj@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gVHVlLCAyMDE3LTEyLTEyIGF0IDExOjAxIC0wODAwLCBUZWp1biBIZW8gd3JvdGU6DQo+ICB2 b2lkIGJsa19hYm9ydF9yZXF1ZXN0KHN0cnVjdCByZXF1ZXN0ICpyZXEpDQo+ICB7DQo+IC0JaWYg KGJsa19tYXJrX3JxX2NvbXBsZXRlKHJlcSkpDQo+IC0JCXJldHVybjsNCj4gIA0KPiAgCWlmIChy ZXEtPnEtPm1xX29wcykgew0KPiAtCQlibGtfbXFfcnFfdGltZWRfb3V0KHJlcSwgZmFsc2UpOw0K PiArCQlyZXEtPmRlYWRsaW5lID0gamlmZmllczsNCj4gKwkJbW9kX3RpbWVyKCZyZXEtPnEtPnRp bWVvdXQsIDApOw0KPiAgCX0gZWxzZSB7DQo+ICsJCWlmIChibGtfbWFya19ycV9jb21wbGV0ZShy ZXEpKQ0KPiArCQkJcmV0dXJuOw0KPiAgCQlibGtfZGVsZXRlX3RpbWVyKHJlcSk7DQo+ICAJCWJs a19ycV90aW1lZF9vdXQocmVxKTsNCj4gIAl9DQoNClRoaXMgcGF0Y2ggbWFrZXMgYmxrX2Fib3J0 X3JlcXVlc3QoKSBhc3luY2hyb25vdXMgZm9yIGJsay1tcS4gSGF2ZSBhbGwgY2FsbGVycw0KYmVl biBhdWRpdGVkIHRvIHZlcmlmeSB3aGV0aGVyIHRoaXMgY2hhbmdlIGlzIHNhZmU/DQoNClRoYW5r cywNCg0KQmFydC4= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbdLNS5A (ORCPT ); Thu, 14 Dec 2017 13:57:00 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:29909 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753894AbdLNS46 (ORCPT ); Thu, 14 Dec 2017 13:56:58 -0500 X-IronPort-AV: E=Sophos;i="5.45,401,1508774400"; d="scan'208";a="65511870" From: Bart Van Assche To: "tj@kernel.org" , "axboe@kernel.dk" CC: "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "osandov@fb.com" , "linux-block@vger.kernel.org" , "oleg@redhat.com" , "hch@lst.de" Subject: Re: [PATCH 4/6] blk-mq: make blk_abort_request() trigger timeout path Thread-Topic: [PATCH 4/6] blk-mq: make blk_abort_request() trigger timeout path Thread-Index: AQHTc3u0eebilIe+fUmD1yeuOTKtTqNDM6YA Date: Thu, 14 Dec 2017 18:56:55 +0000 Message-ID: <1513277814.2475.45.camel@wdc.com> References: <20171212190134.535941-1-tj@kernel.org> <20171212190134.535941-5-tj@kernel.org> In-Reply-To: <20171212190134.535941-5-tj@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.171] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY1PR0401MB1532;20:umjFYpZJJ6i570tW3SPK3IrDOHUGSb2atXrn8wqfxFVVxHGym6OgDyRcLDjyar/LRBgewZhsAvLnfef/N8InFFq8ReqYhkIh0b6hQN1rZ1u0Mx2ufQQCiB57a8XGSj/XGNasSy5ar6Y/63mquspAirK0oQ1bS3J3tvLdFjLM45A= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 54c21d50-2047-401b-7b59-08d543247253 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);SRVR:BY1PR0401MB1532; x-ms-traffictypediagnostic: BY1PR0401MB1532: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231023)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011);SRVR:BY1PR0401MB1532;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BY1PR0401MB1532; x-forefront-prvs: 05214FD68E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(346002)(366004)(39860400002)(24454002)(189003)(377424004)(199004)(3846002)(102836003)(6486002)(53936002)(81166006)(103116003)(6116002)(81156014)(8676002)(54906003)(110136005)(316002)(478600001)(6246003)(6436002)(8936002)(6512007)(36756003)(59450400001)(4001150100001)(305945005)(7736002)(5250100002)(6506007)(106356001)(229853002)(72206003)(105586002)(14454004)(97736004)(66066001)(68736007)(5660300001)(2501003)(99286004)(4326008)(3660700001)(3280700002)(2900100001)(2906002)(86362001)(2950100002)(25786009)(76176011);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0401MB1532;H:BY1PR0401MB1532.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54c21d50-2047-401b-7b59-08d543247253 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2017 18:56:55.6094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0401MB1532 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBEIv7PR011323 On Tue, 2017-12-12 at 11:01 -0800, Tejun Heo wrote: > void blk_abort_request(struct request *req) > { > - if (blk_mark_rq_complete(req)) > - return; > > if (req->q->mq_ops) { > - blk_mq_rq_timed_out(req, false); > + req->deadline = jiffies; > + mod_timer(&req->q->timeout, 0); > } else { > + if (blk_mark_rq_complete(req)) > + return; > blk_delete_timer(req); > blk_rq_timed_out(req); > } This patch makes blk_abort_request() asynchronous for blk-mq. Have all callers been audited to verify whether this change is safe? Thanks, Bart.