From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbdLSTsa (ORCPT ); Tue, 19 Dec 2017 14:48:30 -0500 Received: from mga01.intel.com ([192.55.52.88]:17647 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753072AbdLSTgl (ORCPT ); Tue, 19 Dec 2017 14:36:41 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,428,1508828400"; d="scan'208";a="4018540" From: Dongwon Kim To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, mateuszx.potrola@intel.com, dongwon.kim@intel.com Subject: [RFC PATCH 19/60] hyper_dmabuf: fix the case with sharing a buffer with 2 pages Date: Tue, 19 Dec 2017 11:29:35 -0800 Message-Id: <1513711816-2618-19-git-send-email-dongwon.kim@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513711816-2618-1-git-send-email-dongwon.kim@intel.com> References: <1513711816-2618-1-git-send-email-dongwon.kim@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mateusz Polrola Checking whether buffer has more than two pages should be done by evaluating nents > 1 instead of i > 1 to properly cover the case when nents == 2. Signed-off-by: Dongwon Kim --- drivers/xen/hyper_dmabuf/hyper_dmabuf_imp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/hyper_dmabuf/hyper_dmabuf_imp.c b/drivers/xen/hyper_dmabuf/hyper_dmabuf_imp.c index b61d29a..9b05063 100644 --- a/drivers/xen/hyper_dmabuf/hyper_dmabuf_imp.c +++ b/drivers/xen/hyper_dmabuf/hyper_dmabuf_imp.c @@ -129,7 +129,7 @@ struct sg_table* hyper_dmabuf_create_sgt(struct page **pages, sg_set_page(sgl, pages[i], PAGE_SIZE, 0); } - if (i > 1) /* more than one page */ { + if (nents > 1) /* more than one page */ { sgl = sg_next(sgl); sg_set_page(sgl, pages[i], last_len, 0); } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dongwon Kim Subject: [RFC PATCH 19/60] hyper_dmabuf: fix the case with sharing a buffer with 2 pages Date: Tue, 19 Dec 2017 11:29:35 -0800 Message-ID: <1513711816-2618-19-git-send-email-dongwon.kim@intel.com> References: <1513711816-2618-1-git-send-email-dongwon.kim@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1513711816-2618-1-git-send-email-dongwon.kim@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, mateuszx.potrola@intel.com, dri-devel@lists.freedesktop.org, dongwon.kim@intel.com List-Id: dri-devel@lists.freedesktop.org RnJvbTogTWF0ZXVzeiBQb2xyb2xhIDxtYXRldXN6eC5wb3Ryb2xhQGludGVsLmNvbT4KCkNoZWNr aW5nIHdoZXRoZXIgYnVmZmVyIGhhcyBtb3JlIHRoYW4gdHdvIHBhZ2VzIHNob3VsZCBiZSBkb25l CmJ5IGV2YWx1YXRpbmcgbmVudHMgPiAxIGluc3RlYWQgb2YgaSA+IDEgdG8gcHJvcGVybHkgY292 ZXIgdGhlCmNhc2Ugd2hlbiBuZW50cyA9PSAyLgoKU2lnbmVkLW9mZi1ieTogRG9uZ3dvbiBLaW0g PGRvbmd3b24ua2ltQGludGVsLmNvbT4KLS0tCiBkcml2ZXJzL3hlbi9oeXBlcl9kbWFidWYvaHlw ZXJfZG1hYnVmX2ltcC5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vaHlwZXJfZG1hYnVmL2h5cGVy X2RtYWJ1Zl9pbXAuYyBiL2RyaXZlcnMveGVuL2h5cGVyX2RtYWJ1Zi9oeXBlcl9kbWFidWZfaW1w LmMKaW5kZXggYjYxZDI5YS4uOWIwNTA2MyAxMDA2NDQKLS0tIGEvZHJpdmVycy94ZW4vaHlwZXJf ZG1hYnVmL2h5cGVyX2RtYWJ1Zl9pbXAuYworKysgYi9kcml2ZXJzL3hlbi9oeXBlcl9kbWFidWYv aHlwZXJfZG1hYnVmX2ltcC5jCkBAIC0xMjksNyArMTI5LDcgQEAgc3RydWN0IHNnX3RhYmxlKiBo eXBlcl9kbWFidWZfY3JlYXRlX3NndChzdHJ1Y3QgcGFnZSAqKnBhZ2VzLAogCQlzZ19zZXRfcGFn ZShzZ2wsIHBhZ2VzW2ldLCBQQUdFX1NJWkUsIDApOwogCX0KIAotCWlmIChpID4gMSkgLyogbW9y ZSB0aGFuIG9uZSBwYWdlICovIHsKKwlpZiAobmVudHMgPiAxKSAvKiBtb3JlIHRoYW4gb25lIHBh Z2UgKi8gewogCQlzZ2wgPSBzZ19uZXh0KHNnbCk7CiAJCXNnX3NldF9wYWdlKHNnbCwgcGFnZXNb aV0sIGxhc3RfbGVuLCAwKTsKIAl9Ci0tIAoyLjcuNAoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw=