All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: nutarojj@ornl.gov
Cc: famz@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
	cota@braap.org
Subject: Re: [Qemu-devel] [PATCH V10] qqq: module for synchronizing with a simulation
Date: Tue, 19 Dec 2017 15:23:56 -0800 (PST)	[thread overview]
Message-ID: <151372583496.81.4087757779829737900@5adcb62bf0d6> (raw)
In-Reply-To: <1513724822-25232-1-git-send-email-nutarojj@ornl.gov>

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1513724822-25232-1-git-send-email-nutarojj@ornl.gov
Subject: [Qemu-devel] [PATCH V10] qqq: module for synchronizing with a simulation

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
91b064f0aa qqq: module for synchronizing with a simulation

=== OUTPUT BEGIN ===
Checking PATCH 1/1: qqq: module for synchronizing with a simulation...
ERROR: space required after that ',' (ctx:VxV)
#444: FILE: vl.c:4031:
+                        qemu_find_opts("external_sim"),optarg,true);
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#444: FILE: vl.c:4031:
+                        qemu_find_opts("external_sim"),optarg,true);
                                                              ^

total: 2 errors, 0 warnings, 400 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2017-12-19 23:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 23:07 James J. Nutaro
2017-12-19 23:23 ` no-reply
2017-12-19 23:23 ` no-reply [this message]
2017-12-19 23:41 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151372583496.81.4087757779829737900@5adcb62bf0d6 \
    --to=no-reply@patchew.org \
    --cc=cota@braap.org \
    --cc=famz@redhat.com \
    --cc=nutarojj@ornl.gov \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [Qemu-devel] [PATCH V10] qqq: module for synchronizing with a simulation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.