From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881AbdLWPGN (ORCPT ); Sat, 23 Dec 2017 10:06:13 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:42072 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbdLWPGL (ORCPT ); Sat, 23 Dec 2017 10:06:11 -0500 X-Google-Smtp-Source: ACJfBotn/sQm/fRzNyof/pu0Afs0XnLMRhH08t+GAjk5rLRjX4D2sMJ/kG8Cj7V8OyII6CD8Y1cxgg== From: kishore.p@techveda.org To: eric@anholt.net, stefan.wahren@i2se.com, gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, karthik@techveda.org, shrikant.maurya@techveda.org, Kishore KP , Suniel Mahesh Subject: [PATCH] staging: vc04_services: Prefer BUG_ON instead of if condition followed by BUG. Date: Sat, 23 Dec 2017 20:36:00 +0530 Message-Id: <1514041560-28001-1-git-send-email-kishore.p@techveda.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kishore KP Use BUG_ON instead of if condition followed by BUG. Pointed out by Coccinelle. Signed-off-by: Kishore KP Signed-off-by: Suniel Mahesh --- Note: - Patch was compile tested and built(ARCH=arm) on linux-next (latest). - No build issues reported. --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c index 315b49c..7116f61 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c @@ -224,8 +224,7 @@ int vchiq_platform_init(struct platform_device *pdev, VCHIQ_STATE_T *state) platform_state = (struct vchiq_2835_state *)state->platform_state; - if (!platform_state->inited) - BUG(); + BUG_ON(!platform_state->inited); return &platform_state->arm_state; } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishore.p@techveda.org (kishore.p at techveda.org) Date: Sat, 23 Dec 2017 20:36:00 +0530 Subject: [PATCH] staging: vc04_services: Prefer BUG_ON instead of if condition followed by BUG. Message-ID: <1514041560-28001-1-git-send-email-kishore.p@techveda.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Kishore KP Use BUG_ON instead of if condition followed by BUG. Pointed out by Coccinelle. Signed-off-by: Kishore KP Signed-off-by: Suniel Mahesh --- Note: - Patch was compile tested and built(ARCH=arm) on linux-next (latest). - No build issues reported. --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c index 315b49c..7116f61 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c @@ -224,8 +224,7 @@ int vchiq_platform_init(struct platform_device *pdev, VCHIQ_STATE_T *state) platform_state = (struct vchiq_2835_state *)state->platform_state; - if (!platform_state->inited) - BUG(); + BUG_ON(!platform_state->inited); return &platform_state->arm_state; } -- 1.9.1