All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jackie Li <yaodong.li@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [RFC] drm/i915: Add a new modparam for customized ring multiplier
Date: Tue, 26 Dec 2017 14:35:40 +0000	[thread overview]
Message-ID: <151429894016.11340.4967657781979856698@mail.alporthouse.com> (raw)
In-Reply-To: <151363364587.23825.11593234074115948532@mail.alporthouse.com>

Quoting Chris Wilson (2017-12-18 21:47:25)
> Quoting Jackie Li (2017-12-18 21:22:08)
> > From: Zhipeng Gong <zhipeng.gong@intel.com>
> > 
> > SKL platforms requires a higher ring multiplier when there's massive
> > GPU load. Current driver doesn't provide a way to override the ring
> > multiplier.
> > 
> > This patch adds a new module parameter to allow the overriding of
> > ring multiplier for Gen9 platforms.
> 
> So the default ring-scaling is not good enough, the first thing we do is
> to try and ensure the defaults work for nearly all use cases. My
> impression is that you want a nonlinear scalefactor, low power workloads
> don't try and ramp up the ring frequencies as aggressively, high power
> workloads try hard for higher frequencies, and then get throttled back
> harder as well. How well can we autotune it? What events tells us if the
> ratio is too high or too low?

One thing that came to mind is that we don't know the min/max ring
frequencies and just program them blindly. Is it the case that at max
gpu freq, there is still headroom on the ring freq, or do you require a
steeper ramp so that you hit the max ringfreq earlier for your workload
(which then presumably can run at less than max gpufreq, so pushing
power elsewhere).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-12-26 14:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 21:22 [RFC] drm/i915: Add a new modparam for customized ring multiplier Jackie Li
2017-12-18 21:45 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-18 21:47 ` [RFC] " Chris Wilson
2017-12-19  1:10   ` Yaodong Li
2017-12-26 14:35   ` Chris Wilson [this message]
2017-12-26 16:39     ` Rogozhkin, Dmitry V
2017-12-26 16:58       ` Chris Wilson
2017-12-26 17:39         ` Rogozhkin, Dmitry V
2017-12-27 17:43           ` Rogozhkin, Dmitry V
2018-01-03 18:21           ` Yaodong Li
2018-01-04  6:10             ` Sagar Arun Kamble
2018-01-04 21:52               ` Yaodong Li
2018-01-05 10:15                 ` Sagar Arun Kamble
2018-01-06  0:23                   ` Yaodong Li
2018-01-08  9:11                     ` Sagar Arun Kamble
2018-01-30 18:44                     ` [RFC] drm/i915: cpufreq based dynamic ring freqency table on Gen9 Jackie Li
2017-12-18 22:36 ` ✗ Fi.CI.IGT: failure for drm/i915: Add a new modparam for customized ring multiplier Patchwork
2018-01-30 20:23 ` ✗ Fi.CI.BAT: failure for drm/i915: Add a new modparam for customized ring multiplier (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151429894016.11340.4967657781979856698@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=benjamin.widawsky@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=yaodong.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.