From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Zhang, Chen" <chen.zhang@intel.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Laurent Vivier <lvivier@redhat.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Andrew Melnychenko <andrew@daynix.com>
Subject: Re: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU
Date: Mon, 20 Jun 2022 10:46:31 +0200 [thread overview]
Message-ID: <151603a7-7c5f-baa2-81b5-afb8aa30ff38@redhat.com> (raw)
In-Reply-To: <YrArvxwzVWQK4Hu8@redhat.com>
On 20/06/2022 10.11, Daniel P. Berrangé wrote:
> On Mon, Jun 20, 2022 at 05:59:06AM +0000, Zhang, Chen wrote:
>>
>>
>>> -----Original Message-----
>>> From: Daniel P. Berrangé <berrange@redhat.com>
>>> Sent: Friday, June 17, 2022 4:05 PM
>>> To: Zhang, Chen <chen.zhang@intel.com>
>>> Cc: Jason Wang <jasowang@redhat.com>; qemu-dev <qemu-
>>> devel@nongnu.org>; Paolo Bonzini <pbonzini@redhat.com>; Eduardo
>>> Habkost <eduardo@habkost.net>; Eric Blake <eblake@redhat.com>; Markus
>>> Armbruster <armbru@redhat.com>; Peter Maydell
>>> <peter.maydell@linaro.org>; Thomas Huth <thuth@redhat.com>; Laurent
>>> Vivier <lvivier@redhat.com>; Yuri Benditovich
>>> <yuri.benditovich@daynix.com>; Andrew Melnychenko
>>> <andrew@daynix.com>
>>> Subject: Re: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a
>>> submodule for QEMU
>>>
>>> On Fri, Jun 17, 2022 at 03:36:19PM +0800, Zhang Chen wrote:
>>>> Make iovisor/ubpf project be a git submodule for QEMU.
>>>> It will auto clone ubpf project when configure QEMU.
>>>
>>> I don't think we need todo this. As it is brand new functionality we don't have
>>> any back compat issues. We should just expect the distros to ship ubpf if
>>> they want their QEMU builds to take advantage of it.
>>>
>>
>> Yes, agree. It's the best way to use the uBPF project.
>> But current status is distros(ubuntu, RHEL...) does not ship
>> the iovisor/ubpf like the iovisor/bcc. So I have to do it.
>> Or do you have any better suggestions?
>
> If distros want to support the functionality, they can add packages for
> it IMHO.
Yes, let's please avoid new submodules. Submodules can sometimes be a real
PITA (e.g. if you forget to update before rsync'ing your code to a machine
that has limited internet access), and if users install QEMU from sources,
they can also install ubpf from sources, too.
And if distros want to support this feature, they can package ubpf on their
own, as Daniel said.
Thomas
next prev parent reply other threads:[~2022-06-20 8:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 7:36 [RFC PATCH 00/12] Introduce QEMU userspace ebpf support Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU Zhang Chen
2022-06-17 8:05 ` Daniel P. Berrangé
2022-06-20 5:59 ` Zhang, Chen
2022-06-20 8:11 ` Daniel P. Berrangé
2022-06-20 8:46 ` Thomas Huth [this message]
2022-06-20 9:29 ` Zhang, Chen
2022-06-20 9:43 ` Thomas Huth
2022-06-20 10:29 ` Zhang, Chen
2022-06-20 10:37 ` Daniel P. Berrangé
2022-06-22 9:21 ` Zhang, Chen
2022-06-20 10:00 ` Daniel P. Berrangé
2022-06-20 10:22 ` Zhang, Chen
2022-06-17 7:36 ` [RFC PATCH 02/12] meson: Add ubpf build config and misc Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 03/12] ebpf/uBPF: Introduce userspace ebpf data structure Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 04/12] ebpf/uBPF: Introduce ubpf initialize functions Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 05/12] ebpf/uBPF: Add qemu_prepare_ubpf to load ebpf binary Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 06/12] ebpf/uBPF: Add qemu_ubpf_run_once excute real ebpf program Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 07/12] net/filter: Introduce filter-ubpf module Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 08/12] qapi: Add FilterUbpfProperties and qemu-options Zhang Chen
2022-06-20 7:45 ` Markus Armbruster
2022-06-20 9:40 ` Zhang, Chen
2022-06-17 7:36 ` [RFC PATCH 09/12] softmmu/vl.c: Add filter-ubpf for netdev as other netfilters Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 10/12] net/filter-ubpf.c: run the ubpf program to handle network packet Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 11/12] docs/devel: Add userspace-ebpf.rst Zhang Chen
2022-06-17 7:36 ` [RFC PATCH 12/12] test/qtest: Add ubpf basic test case Zhang Chen
2022-06-17 9:34 ` Thomas Huth
2022-06-20 9:31 ` Zhang, Chen
2022-06-20 9:51 ` Thomas Huth
2022-06-29 10:43 ` [RFC PATCH 00/12] Introduce QEMU userspace ebpf support Andrew Melnichenko
2022-07-01 6:14 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151603a7-7c5f-baa2-81b5-afb8aa30ff38@redhat.com \
--to=thuth@redhat.com \
--cc=andrew@daynix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=chen.zhang@intel.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.