From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "snitzer@redhat.com" CC: "dm-devel@redhat.com" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "ming.lei@redhat.com" , "axboe@kernel.dk" Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Date: Thu, 18 Jan 2018 18:47:59 +0000 Message-ID: <1516301278.2676.35.camel@wdc.com> References: <20180118024124.8079-1-ming.lei@redhat.com> <20180118170353.GB19734@redhat.com> <1516296056.2676.23.camel@wdc.com> <20180118183039.GA20121@redhat.com> In-Reply-To: <20180118183039.GA20121@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gVGh1LCAyMDE4LTAxLTE4IGF0IDEzOjMwIC0wNTAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ IDElIT8gIFdoZXJlIGFyZSB5b3UgZ2V0dGluZyB0aGF0IG51bWJlcj8gIE1pbmcgaGFzIGRldGFp bGVkIG1vcmUNCj4gc2lnbmlmaWNhbnQgcGVyZm9ybWFuY2UgZ2FpbnMgdGhhbiAxJS4uIGFuZCBu b3QganVzdCBvbiBscGZjICh0aG91Z2ggeW91DQo+IGtlZXAgc2VpemluZyBvbiBscGZjIGJlY2F1 c2Ugb2YgdGhlIGxvdyBxdWV1ZV9kZXB0aCBvZiAzKS4NCg0KVGhhdCdzIHdoYXQgSSBkZXJpdmVk IGZyb20gdGhlIG51bWJlcnMgeW91IHBvc3RlZCBmb3IgbnVsbF9ibGsuIElmIE1pbmcgaGFzDQpw b3N0ZWQgcGVyZm9ybWFuY2UgcmVzdWx0cyBmb3Igb3RoZXIgZHJpdmVycyB0aGFuIGxwZmMsIHBs ZWFzZSBsZXQgbWUga25vdw0Kd2hlcmUgSSBjYW4gZmluZCB0aGVzZS4gSSBoYXZlIG5vdCB5ZXQg c2VlbiB0aGVzZSBudW1iZXJzLg0KDQo+IFRoaXMgaXMgYWxsIHZlcnkgdGlyZXNvbWUuDQoNClll cywgdGhpcyBpcyB0aXJlc29tZS4gSXQgaXMgdmVyeSBhbm5veWluZyB0byBtZSB0aGF0IG90aGVy cyBrZWVwIGludHJvZHVjaW5nDQpzbyBtYW55IHJlZ3Jlc3Npb25zIGluIHN1Y2ggaW1wb3J0YW50 IHBhcnRzIG9mIHRoZSBrZXJuZWwuIEl0IGlzIGFsc28gYW5ub3lpbmcNCnRvIG1lIHRoYXQgSSBn ZXQgYmxhbWVkIGlmIEkgcmVwb3J0IGEgcmVncmVzc2lvbiBpbnN0ZWFkIG9mIHNlZWluZyB0aGF0 IHRoZQ0KcmVncmVzc2lvbiBnZXRzIGZpeGVkLg0KDQpCYXJ0Lg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932788AbeARSsH (ORCPT ); Thu, 18 Jan 2018 13:48:07 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:7285 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932452AbeARSsF (ORCPT ); Thu, 18 Jan 2018 13:48:05 -0500 X-IronPort-AV: E=Sophos;i="5.46,378,1511798400"; d="scan'208";a="69861839" From: Bart Van Assche To: "snitzer@redhat.com" CC: "dm-devel@redhat.com" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "ming.lei@redhat.com" , "axboe@kernel.dk" Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Thread-Topic: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Thread-Index: AQHTkAXlp7DN5JBZKUeyLfttG5XpOaN52OmAgAADroCAAATDAIAAE3uAgAAE1gA= Date: Thu, 18 Jan 2018 18:47:59 +0000 Message-ID: <1516301278.2676.35.camel@wdc.com> References: <20180118024124.8079-1-ming.lei@redhat.com> <20180118170353.GB19734@redhat.com> <1516296056.2676.23.camel@wdc.com> <20180118183039.GA20121@redhat.com> In-Reply-To: <20180118183039.GA20121@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1673;7:ahd9/W3dSoGBt1MeVuwiOyWsjG8Rd9Tu0bgJaULSYm6daqFSQMPy8/YQKmyLHQDnZqqGPaFvxGmbOyA+inzpYp//7gu0D7wB/bVSfycrKlcMfqlAUWr6hEtlwatggo8o6lotEeDoYiYJGa6Q9lHV27k6iLVDSvcagZJnt24qSGPBee2eZHHzOl96KguPORvsnys79wPldYnWJJJUnn1ZnNpL9VgwLdE942J0+0GgYRktAPo9TDOv9tohWyceGOxA;20:t8mMzm/cmBMr5A6DzUX6PHX7RGtDvmRvEi3ISDdY37Ur8IiiSdYk1qDdRFGFOVV9cF53OXibQNMNwYU247fZrwl+3iXz8ki8P8sTcMuW00CoxPa9fYAqmMj4i94sw+NFWHz4GJ+AUqcP5f8fAgjjk2o0hZAJh84TFqtOjj522+k= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 61bfaec6-e9f3-4934-7a74-08d55ea3ff45 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:CY1PR0401MB1673; x-ms-traffictypediagnostic: CY1PR0401MB1673: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231023)(944501161)(10201501046)(6055026)(6041268)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011);SRVR:CY1PR0401MB1673;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1673; x-forefront-prvs: 05568D1FF7 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39860400002)(366004)(346002)(39380400002)(376002)(199004)(189003)(377424004)(229853002)(93886005)(97736004)(2950100002)(25786009)(5660300001)(4326008)(36756003)(6512007)(6916009)(53936002)(86362001)(66066001)(478600001)(68736007)(6486002)(6436002)(14454004)(72206003)(3846002)(6116002)(5640700003)(76176011)(54906003)(2501003)(106356001)(2900100001)(103116003)(7736002)(316002)(305945005)(2906002)(3660700001)(6506007)(77096007)(8936002)(59450400001)(105586002)(102836004)(81166006)(8676002)(99286004)(6246003)(26005)(2351001)(1730700003)(3280700002)(81156014);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1673;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: gCJ0FPTswrTStES0x8XTRgO9cvopsgs261OLdTfteL2dB6cSuUHeNuCSM+cegcRbaCkhEqT0DRrKsw6QyfxvCw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <9FFA71298A9AC544B659D8EB772D06B8@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61bfaec6-e9f3-4934-7a74-08d55ea3ff45 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 18:47:59.7591 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1673 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0IImCa0021163 On Thu, 2018-01-18 at 13:30 -0500, Mike Snitzer wrote: > 1%!? Where are you getting that number? Ming has detailed more > significant performance gains than 1%.. and not just on lpfc (though you > keep seizing on lpfc because of the low queue_depth of 3). That's what I derived from the numbers you posted for null_blk. If Ming has posted performance results for other drivers than lpfc, please let me know where I can find these. I have not yet seen these numbers. > This is all very tiresome. Yes, this is tiresome. It is very annoying to me that others keep introducing so many regressions in such important parts of the kernel. It is also annoying to me that I get blamed if I report a regression instead of seeing that the regression gets fixed. Bart.