From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "snitzer@redhat.com" , "axboe@kernel.dk" CC: "dm-devel@redhat.com" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "ming.lei@redhat.com" Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Date: Thu, 18 Jan 2018 20:58:50 +0000 Message-ID: <1516309128.2676.38.camel@wdc.com> References: <20180118024124.8079-1-ming.lei@redhat.com> <20180118170353.GB19734@redhat.com> <1516296056.2676.23.camel@wdc.com> <20180118183039.GA20121@redhat.com> <1516301278.2676.35.camel@wdc.com> <20180118204856.GA31679@redhat.com> In-Reply-To: <20180118204856.GA31679@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gVGh1LCAyMDE4LTAxLTE4IGF0IDE1OjQ4IC0wNTAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ IEZvciBCYXJ0J3MgdGVzdCB0aGUgdW5kZXJseWluZyBzY3NpLW1xIGRyaXZlciBpcyB3aGF0IGlz IHJlZ3VsYXJseQ0KPiBoaXR0aW5nIHRoaXMgY2FzZSBpbiBfX2Jsa19tcV90cnlfaXNzdWVfZGly ZWN0bHkoKToNCj4gDQo+ICAgICAgICAgaWYgKGJsa19tcV9oY3R4X3N0b3BwZWQoaGN0eCkgfHwg YmxrX3F1ZXVlX3F1aWVzY2VkKHEpKQ0KDQpIZWxsbyBNaWtlLA0KDQpUaGF0IGNvZGUgcGF0aCBp cyBub3QgdGhlIGNvZGUgcGF0aCB0aGF0IHRyaWdnZXJlZCB0aGUgbG9ja3VwcyB0aGF0IEkgcmVw b3J0ZWQNCmR1cmluZyB0aGUgcGFzdCBkYXlzLiBUaGVzZSBsb2NrdXBzIHdlcmUgYWxsIHRyaWdn ZXJlZCBieSBpbmNvcnJlY3QgaGFuZGxpbmcgb2YNCi5xdWV1ZV9ycSgpIHJldHVybmluZyBCTEtf U1RTX1JFU09VUkNFLg0KDQpCYXJ0Lg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932158AbeARU64 (ORCPT ); Thu, 18 Jan 2018 15:58:56 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:20506 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbeARU6x (ORCPT ); Thu, 18 Jan 2018 15:58:53 -0500 X-IronPort-AV: E=Sophos;i="5.46,378,1511798400"; d="scan'208";a="69873231" From: Bart Van Assche To: "snitzer@redhat.com" , "axboe@kernel.dk" CC: "dm-devel@redhat.com" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "ming.lei@redhat.com" Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Thread-Topic: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Thread-Index: AQHTkAXlp7DN5JBZKUeyLfttG5XpOaN52OmAgAADroCAAATDAIAAE3uAgAAE1gCAABc0gIAACpqAgAACwAA= Date: Thu, 18 Jan 2018 20:58:50 +0000 Message-ID: <1516309128.2676.38.camel@wdc.com> References: <20180118024124.8079-1-ming.lei@redhat.com> <20180118170353.GB19734@redhat.com> <1516296056.2676.23.camel@wdc.com> <20180118183039.GA20121@redhat.com> <1516301278.2676.35.camel@wdc.com> <20180118204856.GA31679@redhat.com> In-Reply-To: <20180118204856.GA31679@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB0908;7:mqTYuEycTz9dDh5blP5WqR+tgG/SrorzkmMtb6OziqjqK5WgqUugQ2kSKqNkRceluunxwxMi6iytfXtzZHYOF6dPmjNPy9AxDeTdLf+obLmjGH0bZ0NLn+Ps+bwy/7MrcgOmWiR1fR6iL41xMNQ369vE/A+lQsXbXXQ4u4aVIg15h4ZmitpTP9vHhg4mxlUANB1iKMa9NMkSN2FsTYItnIT6uhhArALe4vZxHsamBWrSqmSxEDLohUgXK9N2vzOl;20:vWQQ4hiDTQKJuCxfOSsyW+infgTp2JvAKg2yrqF6SPbj0poleo0HsHmNV46Nl1ufyN83jjtpXhqTxP9C5isK8x+a8/wrg18invk+I6emz3nYhKYUMNtGj2FT9cgxkmkE934oLdY1AtpOGIFjdv2vkTFs50HaIfi/KuUvuIYrjFg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 0592847d-663c-4673-99de-08d55eb646a1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020);SRVR:CY1PR0401MB0908; x-ms-traffictypediagnostic: CY1PR0401MB0908: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(2400067)(944501161)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011);SRVR:CY1PR0401MB0908;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB0908; x-forefront-prvs: 05568D1FF7 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(396003)(376002)(346002)(39860400002)(366004)(377424004)(199004)(189003)(76176011)(106356001)(110136005)(2906002)(54906003)(105586002)(478600001)(102836004)(6506007)(2501003)(8936002)(81166006)(68736007)(81156014)(8676002)(6246003)(316002)(4326008)(103116003)(72206003)(25786009)(14454004)(305945005)(97736004)(6116002)(36756003)(6436002)(6486002)(7736002)(99286004)(3660700001)(86362001)(3280700002)(229853002)(53936002)(3846002)(93886005)(2900100001)(6512007)(66066001)(2950100002)(5660300001)(26005)(77096007);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB0908;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: zpb60aGohmffrNrvAG0XVHpMiBslvU/USfwuC/sFxEhi9VvZO2DvY99OFDxpH1U8dQbgVXaD4QM2SouKMnoJew== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <5FB5DA99D984C848A94C73CF6547EE24@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0592847d-663c-4673-99de-08d55eb646a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 20:58:50.4379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB0908 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0IKx0Hh006779 On Thu, 2018-01-18 at 15:48 -0500, Mike Snitzer wrote: > For Bart's test the underlying scsi-mq driver is what is regularly > hitting this case in __blk_mq_try_issue_directly(): > > if (blk_mq_hctx_stopped(hctx) || blk_queue_quiesced(q)) Hello Mike, That code path is not the code path that triggered the lockups that I reported during the past days. These lockups were all triggered by incorrect handling of .queue_rq() returning BLK_STS_RESOURCE. Bart.