From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "ming.lei@redhat.com" , "axboe@kernel.dk" CC: "dm-devel@redhat.com" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "snitzer@redhat.com" Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Date: Fri, 19 Jan 2018 05:09:46 +0000 Message-ID: <1516338585.4077.1.camel@wdc.com> References: <20180118024124.8079-1-ming.lei@redhat.com> <20180118170353.GB19734@redhat.com> <1516296056.2676.23.camel@wdc.com> <20180118183039.GA20121@redhat.com> <1516301278.2676.35.camel@wdc.com> <20180119023212.GA25413@ming.t460p> In-Reply-To: <20180119023212.GA25413@ming.t460p> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gRnJpLCAyMDE4LTAxLTE5IGF0IDEwOjMyICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gTm93 IG1vc3Qgb2YgdGltZXMgYm90aCBOVk1lIGFuZCBTQ1NJIHdvbid0IHJldHVybiBCTEtfU1RTX1JF U09VUkNFLCBhbmQNCj4gaXQgc2hvdWxkIGJlIERNLW9ubHkgd2hpY2ggcmV0dXJucyBTVFNfUkVT T1VSQ0Ugc28gb2Z0ZW4uDQoNClRoYXQncyB3cm9uZyBhdCBsZWFzdCBmb3IgU0NTSS4gU2VlIGFs c28gaHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtYmxvY2smbT0xNTE1NzgzMjk0MTcwNzYuDQoN CkJhcnQu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbeASFJ6 (ORCPT ); Fri, 19 Jan 2018 00:09:58 -0500 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:2200 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbeASFJu (ORCPT ); Fri, 19 Jan 2018 00:09:50 -0500 X-IronPort-AV: E=Sophos;i="5.46,380,1511798400"; d="scan'208";a="69504658" From: Bart Van Assche To: "ming.lei@redhat.com" , "axboe@kernel.dk" CC: "dm-devel@redhat.com" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "snitzer@redhat.com" Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Thread-Topic: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Thread-Index: AQHTkAXlp7DN5JBZKUeyLfttG5XpOaN52OmAgAADroCAAATDAIAAE3uAgAAE1gCAABc0gIAAaoKAgAAsBIA= Date: Fri, 19 Jan 2018 05:09:46 +0000 Message-ID: <1516338585.4077.1.camel@wdc.com> References: <20180118024124.8079-1-ming.lei@redhat.com> <20180118170353.GB19734@redhat.com> <1516296056.2676.23.camel@wdc.com> <20180118183039.GA20121@redhat.com> <1516301278.2676.35.camel@wdc.com> <20180119023212.GA25413@ming.t460p> In-Reply-To: <20180119023212.GA25413@ming.t460p> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [76.126.112.182] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1689;7:buPf3c2Ku6iCW2NXOTYXK4b20hW94cJ/H/t/4o8x8Uw553jcw55muRuXaLNKU6/aU+ccRaV+tw461wcYvSUWzkuiXprjR8YZwe0AFhbu0FhVCf5EKYjdDw31AKZk6KAsCgKqxyHlRkJpy6X0YISPcxSs9NmPskJ/aEENt12dVE/1bnEfpCxtx1pTTK18yPqbNKmhZb3TjN3UjG7PAhyiO0GCHSQfn28SAHB4Ys/R1FTDwoIubcX5m1ZJYao8eC6w;20:wYEEFqFK1TJJvnGs7pomd8nChR6MMKoZZinodv76zo+bTVQ+N1hCO2B5cLoklfUdVPUdNoy+AvSeHYabISlPyJZx1tEAPDsjQ+JZ7h8/2f8EP4LviYfj1pN9Tb3rPKlglIFigmyORNBJdFt7a2nHZ+MuPjpsaJ+edNFBQT7P8No= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 173abc8c-23dd-4a7b-a447-08d55efadbf3 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:CY1PR0401MB1689; x-ms-traffictypediagnostic: CY1PR0401MB1689: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501161)(93006095)(93001095)(10201501046)(6055026)(6041268)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:CY1PR0401MB1689;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1689; x-forefront-prvs: 0557CBAD84 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(396003)(39860400002)(376002)(366004)(39380400002)(377424004)(189003)(199004)(7736002)(305945005)(478600001)(103116003)(316002)(93886005)(72206003)(105586002)(25786009)(26005)(77096007)(99286004)(54906003)(110136005)(14454004)(966005)(3846002)(2900100001)(6116002)(4326008)(8676002)(3660700001)(76176011)(8936002)(2906002)(81166006)(81156014)(558084003)(6306002)(2501003)(6246003)(68736007)(6506007)(102836004)(5660300001)(6486002)(66066001)(2950100002)(229853002)(97736004)(3280700002)(106356001)(86362001)(6512007)(53936002)(36756003)(6436002)(6606295002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1689;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: mf1fol8KUM7M5fRnC6isgZRxlh+8h0MktJWRuBFHwYX2LmmcioTbV9Z+LWfvU0VmVY49SjX1abV+XZbfjeVy9Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <506310BCB4EFA6478A23287ABCA1E171@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 173abc8c-23dd-4a7b-a447-08d55efadbf3 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2018 05:09:46.6711 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1689 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0J5A3CM017100 On Fri, 2018-01-19 at 10:32 +0800, Ming Lei wrote: > Now most of times both NVMe and SCSI won't return BLK_STS_RESOURCE, and > it should be DM-only which returns STS_RESOURCE so often. That's wrong at least for SCSI. See also https://marc.info/?l=linux-block&m=151578329417076. Bart.