From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBotFOJ+YbYkFLIytJ5ZLg3iC3R7Ctru5gVedc92HGUR1jhAARvA3aYryQ2rWmoVJRDtnXNbv ARC-Seal: i=1; a=rsa-sha256; t=1516375800; cv=none; d=google.com; s=arc-20160816; b=wRkPeysAJzTGjGDIcL5xRYBOrz4p2e6o/UKH6lUNnbc/sXCowEZVnVdXdkavBkC8oi 9OAMLItFiSxctdwozIsgok2n5Q5SAPTTdvBhyyc1eI/a+LcNgRHsT8WgeSs7FF0m8pMw w6XdnS9d1SJFCxukAPiGgtE8zIFk1zGU4jiiSbRqFl/ECxtyw7iU4izOkslG4qMY9ieK 0B8J4fxftGhJl5fZTLhfEYtcYzohIWGddpoW8fIanVOKs7zGpRp3eCYMPgqSl++GTU9e TVGwO0todcKbQ5olS+Vrr3KSiw3b5ffKkcoWg4gRUic2GNGAXjcH8vCJ79Uc/7o7s4SO XEHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=hEbN5SCb8hlel0UTdBIgIXD49akFLV03F/2E7L8GAIQ=; b=OO8xG2/MwSSsk8fjv0xd8WMt0EIBn+YhtSBhvgby3A5/WccyiwWtOvnXPQuFlaqi7i rWNeyc7GGvud0oMb89ZUg3P2ZsT5wUGE5QfSejokye5lErJwPX8mmZCadqTOVDfc9ioc PhM3aFJujxK5Pf3Ra3ZiHqWFoqMFKmt915MlrV1v6tpyZ/tyaTHbgmcE464fvHd7DD1v r2vDZncxZmu4+ixxaRgCRNE+/6l5SpjsEZQ65e1WlDlwfd5+FzqLX/EmReJg/fMJg3Qo R8VXqBowsuLXjx6auLb6lJhJPogK8OgHUagqklUhahoqC8s30TmpQUvgClBbKZsQpT0O 1Hww== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 2a02:1800:110:4::f00:1a is neither permitted nor denied by best guess record for domain of geert@linux-m68k.org) smtp.mailfrom=geert@linux-m68k.org Authentication-Results: mx.google.com; spf=neutral (google.com: 2a02:1800:110:4::f00:1a is neither permitted nor denied by best guess record for domain of geert@linux-m68k.org) smtp.mailfrom=geert@linux-m68k.org From: Geert Uytterhoeven To: Russell King Cc: Antonios Motakis , Adrian Salido , Sasha Levin , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 1/4] ARM: amba: Make driver_override output consistent with other buses Date: Fri, 19 Jan 2018 16:24:07 +0100 Message-Id: <1516375450-30575-2-git-send-email-geert+renesas@glider.be> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516375450-30575-1-git-send-email-geert+renesas@glider.be> References: <1516375450-30575-1-git-send-email-geert+renesas@glider.be> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590035271597233135?= X-GMAIL-MSGID: =?utf-8?q?1590035271597233135?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: For AMBA devices with unconfigured driver override, the "driver_override" sysfs virtual file is empty, while it contains "(null)" for platform and PCI devices. Make AMBA consistent with other buses by dropping the test for a NULL pointer. Note that contrary to popular belief, sprintf() handles NULL pointers fine; they are printed as "(null)". Signed-off-by: Geert Uytterhoeven --- drivers/amba/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 594c228d2f021123..6ffd778352e6d953 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -70,9 +70,6 @@ static ssize_t driver_override_show(struct device *_dev, { struct amba_device *dev = to_amba_device(_dev); - if (!dev->driver_override) - return 0; - return sprintf(buf, "%s\n", dev->driver_override); } -- 2.7.4