All of lore.kernel.org
 help / color / mirror / Atom feed

diff for duplicates of <1516377960.2646.4.camel@wdc.com>

diff --git a/a/1.txt b/N1/1.txt
index 561d5f6..184eb03 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -1,24 +1,40 @@
-T24gRnJpLCAyMDE4LTAxLTE5IGF0IDIzOjMzICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gT24g
-RnJpLCBKYW4gMTksIDIwMTggYXQgMDM6MjA6MTNQTSArMDAwMCwgQmFydCBWYW4gQXNzY2hlIHdy
-b3RlOg0KPiA+IE9uIEZyaSwgMjAxOC0wMS0xOSBhdCAxNToyNiArMDgwMCwgTWluZyBMZWkgd3Jv
-dGU6DQo+ID4gPiBQbGVhc2Ugc2VlIHF1ZXVlX2RlbGF5ZWRfd29ya19vbigpLCBoY3R4LT5ydW5f
-d29yayBpcyBzaGFyZWQgYnkgYWxsDQo+ID4gPiBzY2hlZHVsaW5nLCBvbmNlIGJsa19tcV9kZWxh
-eV9ydW5faHdfcXVldWUoMTAwbXMpIHJldHVybnMsIG5vIG5ldw0KPiA+ID4gc2NoZWR1bGluZyBj
-YW4gbWFrZSBwcm9ncmVzcyBkdXJpbmcgdGhlIDEwMG1zLg0KPiA+IA0KPiA+IEhvdyBhYm91dCBh
-ZGRyZXNzaW5nIHRoYXQgYXMgZm9sbG93czoNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvYmxvY2sv
-YmxrLW1xLmMgYi9ibG9jay9ibGstbXEuYw0KPiA+IGluZGV4IGY3NTE1ZGQ5NWEzNi4uNTdmODM3
-OWE0NzZkIDEwMDY0NA0KPiA+IC0tLSBhL2Jsb2NrL2Jsay1tcS5jDQo+ID4gKysrIGIvYmxvY2sv
-YmxrLW1xLmMNCj4gPiBAQCAtMTQwMyw5ICsxNDAzLDkgQEAgc3RhdGljIHZvaWQgX19ibGtfbXFf
-ZGVsYXlfcnVuX2h3X3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4ICpoY3R4LCBib29sIGFzeW5j
-LA0KPiA+ICAJCXB1dF9jcHUoKTsNCj4gPiAgCX0NCj4gPiAgDQo+ID4gLQlrYmxvY2tkX3NjaGVk
-dWxlX2RlbGF5ZWRfd29ya19vbihibGtfbXFfaGN0eF9uZXh0X2NwdShoY3R4KSwNCj4gPiAtCQkJ
-CQkgJmhjdHgtPnJ1bl93b3JrLA0KPiA+IC0JCQkJCSBtc2Vjc190b19qaWZmaWVzKG1zZWNzKSk7
-DQo+ID4gKwlrYmxvY2tkX21vZF9kZWxheWVkX3dvcmtfb24oYmxrX21xX2hjdHhfbmV4dF9jcHUo
-aGN0eCksDQo+ID4gKwkJCQkgICAgJmhjdHgtPnJ1bl93b3JrLA0KPiA+ICsJCQkJICAgIG1zZWNz
-X3RvX2ppZmZpZXMobXNlY3MpKTsNCj4gPiAgfQ0KPiA+ICANCj4gPiAgdm9pZCBibGtfbXFfZGVs
-YXlfcnVuX2h3X3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4ICpoY3R4LCB1bnNpZ25lZCBsb25n
-IG1zZWNzKQ0KPiA+IA0KPiA+IEJhcnQuDQo+IA0KPiBZZXMsIHRoaXMgb25lIHRvZ2V0aGVyIHdp
-dGggSmVuJ3Mgc3VnZ2VzdGlvbiB3aXRoIHJldHVybmluZw0KPiBCTEtfU1RTX05PX0RFVl9SRVNP
-VVJDRSBzaG91bGQgZml4IHRoaXMgaXNzdWUuDQo+IA0KPiBDb3VsZCB5b3UgY29vayBhIGZpeCBm
-b3IgdGhpcyBpc3N1ZT8gT3RoZXJ3aXNlIEkgYW0gaGFwcHkgdG8gZG8NCj4gdGhhdC4NCg0KSGVs
-bG8gTWluZywNCg0KSSB3aWxsIGxvb2sgZnVydGhlciBpbnRvIHRoaXMuDQoNCkJhcnQu
\ No newline at end of file
+On Fri, 2018-01-19 at 23:33 +0800, Ming Lei wrote:
+> On Fri, Jan 19, 2018 at 03:20:13PM +0000, Bart Van Assche wrote:
+> > On Fri, 2018-01-19 at 15:26 +0800, Ming Lei wrote:
+> > > Please see queue_delayed_work_on(), hctx->run_work is shared by all
+> > > scheduling, once blk_mq_delay_run_hw_queue(100ms) returns, no new
+> > > scheduling can make progress during the 100ms.
+> > 
+> > How about addressing that as follows:
+> > 
+> > diff --git a/block/blk-mq.c b/block/blk-mq.c
+> > index f7515dd95a36..57f8379a476d 100644
+> > --- a/block/blk-mq.c
+> > +++ b/block/blk-mq.c
+> > @@ -1403,9 +1403,9 @@ static void __blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async,
+> >  		put_cpu();
+> >  	}
+> >  
+> > -	kblockd_schedule_delayed_work_on(blk_mq_hctx_next_cpu(hctx),
+> > -					 &hctx->run_work,
+> > -					 msecs_to_jiffies(msecs));
+> > +	kblockd_mod_delayed_work_on(blk_mq_hctx_next_cpu(hctx),
+> > +				    &hctx->run_work,
+> > +				    msecs_to_jiffies(msecs));
+> >  }
+> >  
+> >  void blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, unsigned long msecs)
+> > 
+> > Bart.
+> 
+> Yes, this one together with Jen's suggestion with returning
+> BLK_STS_NO_DEV_RESOURCE should fix this issue.
+> 
+> Could you cook a fix for this issue? Otherwise I am happy to do
+> that.
+
+Hello Ming,
+
+I will look further into this.
+
+Bart.
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index 7306e02..7fab90c 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -59,30 +59,46 @@
   "b\0"
 ]
 [
-  "T24gRnJpLCAyMDE4LTAxLTE5IGF0IDIzOjMzICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gT24g\n",
-  "RnJpLCBKYW4gMTksIDIwMTggYXQgMDM6MjA6MTNQTSArMDAwMCwgQmFydCBWYW4gQXNzY2hlIHdy\n",
-  "b3RlOg0KPiA+IE9uIEZyaSwgMjAxOC0wMS0xOSBhdCAxNToyNiArMDgwMCwgTWluZyBMZWkgd3Jv\n",
-  "dGU6DQo+ID4gPiBQbGVhc2Ugc2VlIHF1ZXVlX2RlbGF5ZWRfd29ya19vbigpLCBoY3R4LT5ydW5f\n",
-  "d29yayBpcyBzaGFyZWQgYnkgYWxsDQo+ID4gPiBzY2hlZHVsaW5nLCBvbmNlIGJsa19tcV9kZWxh\n",
-  "eV9ydW5faHdfcXVldWUoMTAwbXMpIHJldHVybnMsIG5vIG5ldw0KPiA+ID4gc2NoZWR1bGluZyBj\n",
-  "YW4gbWFrZSBwcm9ncmVzcyBkdXJpbmcgdGhlIDEwMG1zLg0KPiA+IA0KPiA+IEhvdyBhYm91dCBh\n",
-  "ZGRyZXNzaW5nIHRoYXQgYXMgZm9sbG93czoNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvYmxvY2sv\n",
-  "YmxrLW1xLmMgYi9ibG9jay9ibGstbXEuYw0KPiA+IGluZGV4IGY3NTE1ZGQ5NWEzNi4uNTdmODM3\n",
-  "OWE0NzZkIDEwMDY0NA0KPiA+IC0tLSBhL2Jsb2NrL2Jsay1tcS5jDQo+ID4gKysrIGIvYmxvY2sv\n",
-  "YmxrLW1xLmMNCj4gPiBAQCAtMTQwMyw5ICsxNDAzLDkgQEAgc3RhdGljIHZvaWQgX19ibGtfbXFf\n",
-  "ZGVsYXlfcnVuX2h3X3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4ICpoY3R4LCBib29sIGFzeW5j\n",
-  "LA0KPiA+ICAJCXB1dF9jcHUoKTsNCj4gPiAgCX0NCj4gPiAgDQo+ID4gLQlrYmxvY2tkX3NjaGVk\n",
-  "dWxlX2RlbGF5ZWRfd29ya19vbihibGtfbXFfaGN0eF9uZXh0X2NwdShoY3R4KSwNCj4gPiAtCQkJ\n",
-  "CQkgJmhjdHgtPnJ1bl93b3JrLA0KPiA+IC0JCQkJCSBtc2Vjc190b19qaWZmaWVzKG1zZWNzKSk7\n",
-  "DQo+ID4gKwlrYmxvY2tkX21vZF9kZWxheWVkX3dvcmtfb24oYmxrX21xX2hjdHhfbmV4dF9jcHUo\n",
-  "aGN0eCksDQo+ID4gKwkJCQkgICAgJmhjdHgtPnJ1bl93b3JrLA0KPiA+ICsJCQkJICAgIG1zZWNz\n",
-  "X3RvX2ppZmZpZXMobXNlY3MpKTsNCj4gPiAgfQ0KPiA+ICANCj4gPiAgdm9pZCBibGtfbXFfZGVs\n",
-  "YXlfcnVuX2h3X3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4ICpoY3R4LCB1bnNpZ25lZCBsb25n\n",
-  "IG1zZWNzKQ0KPiA+IA0KPiA+IEJhcnQuDQo+IA0KPiBZZXMsIHRoaXMgb25lIHRvZ2V0aGVyIHdp\n",
-  "dGggSmVuJ3Mgc3VnZ2VzdGlvbiB3aXRoIHJldHVybmluZw0KPiBCTEtfU1RTX05PX0RFVl9SRVNP\n",
-  "VVJDRSBzaG91bGQgZml4IHRoaXMgaXNzdWUuDQo+IA0KPiBDb3VsZCB5b3UgY29vayBhIGZpeCBm\n",
-  "b3IgdGhpcyBpc3N1ZT8gT3RoZXJ3aXNlIEkgYW0gaGFwcHkgdG8gZG8NCj4gdGhhdC4NCg0KSGVs\n",
-  "bG8gTWluZywNCg0KSSB3aWxsIGxvb2sgZnVydGhlciBpbnRvIHRoaXMuDQoNCkJhcnQu"
+  "On Fri, 2018-01-19 at 23:33 +0800, Ming Lei wrote:\n",
+  "> On Fri, Jan 19, 2018 at 03:20:13PM +0000, Bart Van Assche wrote:\n",
+  "> > On Fri, 2018-01-19 at 15:26 +0800, Ming Lei wrote:\n",
+  "> > > Please see queue_delayed_work_on(), hctx->run_work is shared by all\n",
+  "> > > scheduling, once blk_mq_delay_run_hw_queue(100ms) returns, no new\n",
+  "> > > scheduling can make progress during the 100ms.\n",
+  "> > \n",
+  "> > How about addressing that as follows:\n",
+  "> > \n",
+  "> > diff --git a/block/blk-mq.c b/block/blk-mq.c\n",
+  "> > index f7515dd95a36..57f8379a476d 100644\n",
+  "> > --- a/block/blk-mq.c\n",
+  "> > +++ b/block/blk-mq.c\n",
+  "> > \@\@ -1403,9 +1403,9 \@\@ static void __blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async,\n",
+  "> >  \t\tput_cpu();\n",
+  "> >  \t}\n",
+  "> >  \n",
+  "> > -\tkblockd_schedule_delayed_work_on(blk_mq_hctx_next_cpu(hctx),\n",
+  "> > -\t\t\t\t\t &hctx->run_work,\n",
+  "> > -\t\t\t\t\t msecs_to_jiffies(msecs));\n",
+  "> > +\tkblockd_mod_delayed_work_on(blk_mq_hctx_next_cpu(hctx),\n",
+  "> > +\t\t\t\t    &hctx->run_work,\n",
+  "> > +\t\t\t\t    msecs_to_jiffies(msecs));\n",
+  "> >  }\n",
+  "> >  \n",
+  "> >  void blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, unsigned long msecs)\n",
+  "> > \n",
+  "> > Bart.\n",
+  "> \n",
+  "> Yes, this one together with Jen's suggestion with returning\n",
+  "> BLK_STS_NO_DEV_RESOURCE should fix this issue.\n",
+  "> \n",
+  "> Could you cook a fix for this issue? Otherwise I am happy to do\n",
+  "> that.\n",
+  "\n",
+  "Hello Ming,\n",
+  "\n",
+  "I will look further into this.\n",
+  "\n",
+  "Bart."
 ]
 
-ba219a19ad8ffa38436092460fc3606486ac7556d76bf4c74cbb2c6a3a5539ee
+f4a02d403077d85890c6ab7c3aaec4e118eebadef44b0b5092d3d808143a5525
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.