From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2248MBd2I6pqpsrnfB9R1UG9Vbj6MbUridSdR7evCbvtmRPq3ZTQhEOmq7uCHKjUpSDsB14P ARC-Seal: i=1; a=rsa-sha256; t=1516732698; cv=none; d=google.com; s=arc-20160816; b=rZriaRiUFix38xmcNodWVAomPfOqYe65eRFwMMZlP9PWGSPSIKN9DwKTe5DSqpDE55 Phtjao2CvJ+YGLHCLgA7Ptoa+o0T6+4lt0t2OW3A9SIBVQEJ3CGu91nqPvj6gOeYCjtg 42yE5c/80ARUrFQHkv3RFH3jmLIyeIBDeWwMWBtya0APwYvGg0Zkk0B7fDgIlTjE9rJf QNzCXR6igoVtscP3I3JNXXfoA56IAZ7UjXcCnkn67Ib8fD/ZTvor+wKiVeoYHFU8zi/P jLeS/opwjaKGESp+rvITZaeaHkbAiGV9FICuYk4GZkJoNMuWVciBd25reME8bsB0/vcM hPlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Yi1dFpk0fdcPGp6SQ1b3DGHKnKJcv336UlqUpqY7W/c=; b=aIs2ddkSQatMDhEPObdAo8UFxMpeBQIuKWxseH97OWqqb+1dvkngU/cVCTgnjujU0C awxVmh3T6+z/KuQo+9HxoOV5VVW6/S55xrmznLsued67c8mtmegzjDuIk2mln35P/qHZ aLjeCfROLCrU32n6iPexDPiFasbwjImgGSJiIRBflEYs6Hbg1QABVNLfsl9iI+W+EsQn cuq8M9Dzev0R07O/PlWbfL8q1jamwnsHGsPTTdc3k6SpGRYb4AMXF8JrfEgEEBQ4+X7c lAuOnksVC88hGO0tMSa5wFb5ReiRO6g+1OvjKm51Z38a5j+Ocf60Zh7JXbQMUnFYGnIP +s+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com From: Vadim Pasternak To: dvhart@infradead.org, andy.shevchenko@gmail.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us, Vadim Pasternak Subject: [patch v10 5/6] platform/mellanox: mlxreg-hotplug: Add check for negative adapter number value Date: Tue, 23 Jan 2018 20:34:24 +0000 Message-Id: <1516739665-132304-5-git-send-email-vadimp@mellanox.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1516739665-132304-1-git-send-email-vadimp@mellanox.com> References: <1516739665-132304-1-git-send-email-vadimp@mellanox.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590409506206438853?= X-GMAIL-MSGID: =?utf-8?q?1590409506206438853?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Verify before creation of hotplug device if the associated adapter number is negative. It could be in case hotplug event is not associated with hotplug device. Signed-off-by: Vadim Pasternak --- v10->v9: Fixes added by Vadim: - add this patch to the series; --- drivers/platform/mellanox/mlxreg-hotplug.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c index f841379..b0d7587 100644 --- a/drivers/platform/mellanox/mlxreg-hotplug.c +++ b/drivers/platform/mellanox/mlxreg-hotplug.c @@ -96,6 +96,14 @@ struct mlxreg_hotplug_priv_data { static int mlxreg_hotplug_device_create(struct device *dev, struct mlxreg_core_data *data) { + /* + * Return if adapter number is negative. Return if adapter number is + * negative. It could be in case hotplug event is not associated with + * hotplug device. + */ + if (data->hpdev.nr < 0) + return 0; + data->hpdev.adapter = i2c_get_adapter(data->hpdev.nr); if (!data->hpdev.adapter) { dev_err(dev, "Failed to get adapter for bus %d\n", -- 2.1.4