From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 1/7] app/procinfo: prepare for new debug
	functions
Date: Thu, 10 Jan 2019 00:45:04 +0100
Message-ID: <15168357.XSmGzJBqIm@xps>
References: <20181213050842.64587-1-vipin.varghese@intel.com>
 <20190107153829.34047-1-vipin.varghese@intel.com>
 <20190107153829.34047-2-vipin.varghese@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, reshma.pattan@intel.com, john.mcnamara@intel.com,
 amol.patel@intel.com, stephen@networkplumber.org, konstantin.ananyev@intel.com,
 jasvinder.singh@intel.com
To: Vipin Varghese <vipin.varghese@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B11701B483
 for <dev@dpdk.org>; Thu, 10 Jan 2019 00:45:07 +0100 (CET)
In-Reply-To: <20190107153829.34047-2-vipin.varghese@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Vipin,

The code split in this v8 looks really better,
except this patch which makes no sense alone.
I feel you can move these changes in next patches,
where appropriate, isn't it?

07/01/2019 16:38, Vipin Varghese:
> Update code base and meson build file to accomadate changes for the
> new functionality.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Acked-by: Reshma  Pattan <reshma.pattan@intel.com>
> ---
>  app/proc-info/main.c      | 13 +++++++++++++
>  app/proc-info/meson.build |  2 +-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index c20effa4f..c7697389c 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -29,6 +29,9 @@
>  #include <rte_branch_prediction.h>
>  #include <rte_string_fns.h>
>  #include <rte_metrics.h>
> +#include <rte_cycles.h>
> +#include <rte_security.h>
> +#include <rte_cryptodev.h>
>  
>  /* Maximum long option length for option parsing. */
>  #define MAX_LONG_OPT_SZ 64
> @@ -36,6 +39,10 @@
>  
>  #define MAX_STRING_LEN 256
>  
> +#define STATS_BDR_FMT "========================================"
> +#define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \
> +	STATS_BDR_FMT, s, w, STATS_BDR_FMT)
> +
>  /**< mask of enabled ports */
>  static uint32_t enabled_port_mask;
>  /**< Enable stats. */
> @@ -65,6 +72,9 @@ static char *xstats_name;
>  static uint32_t nb_xstats_ids;
>  static uint64_t xstats_ids[MAX_NB_XSTATS_IDS];
>  
> +/* show border */
> +static char bdr_str[MAX_STRING_LEN];
> +
>  /**< display usage */
>  static void
>  proc_info_usage(const char *prgname)
> @@ -668,5 +678,8 @@ main(int argc, char **argv)
>  	if (ret)
>  		printf("Error from rte_eal_cleanup(), %d\n", ret);
>  
> +	snprintf(bdr_str, MAX_STRING_LEN, " ");
> +	STATS_BDR_STR(50, bdr_str);
> +
>  	return 0;
>  }
> diff --git a/app/proc-info/meson.build b/app/proc-info/meson.build
> index a52b2ee4a..866b390d6 100644
> --- a/app/proc-info/meson.build
> +++ b/app/proc-info/meson.build
> @@ -3,4 +3,4 @@
>  
>  sources = files('main.c')
>  allow_experimental_apis = true
> -deps += ['ethdev', 'metrics']
> +deps += ['ethdev', 'metrics', 'security']
>