From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating Date: Wed, 24 Jan 2018 19:55:43 -0800 Message-ID: <1516852543.3715.43.camel@gmail.com> References: <1515728542-3060-1-git-send-email-jianchao.w.wang@oracle.com> <20180112163247.GB15974@ziepe.ca> <1515775567.131759.42.camel@gmail.com> <53b1ac4d-a294-eb98-149e-65d7954243da@oracle.com> <1516376999.3606.39.camel@gmail.com> <339a7156-9ef1-1f3c-30b8-3cc3558d124e@mellanox.com> <532b4d71-e2eb-35f3-894e-1c3288e7bc3f@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <532b4d71-e2eb-35f3-894e-1c3288e7bc3f-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "jianchao.wang" , Tariq Toukan , Jason Gunthorpe Cc: junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Saeed Mahameed List-Id: linux-rdma@vger.kernel.org On Thu, 2018-01-25 at 11:27 +0800, jianchao.wang wrote: > Hi Tariq > > On 01/22/2018 10:12 AM, jianchao.wang wrote: > > > > On 19/01/2018 5:49 PM, Eric Dumazet wrote: > > > > > On Fri, 2018-01-19 at 23:16 +0800, jianchao.wang wrote: > > > > > > Hi Tariq > > > > > > > > > > > > Very sad that the crash was reproduced again after applied the patch. > > > > > > Memory barriers vary for different Archs, can you please share more details regarding arch and repro steps? > > The hardware is HP ProLiant DL380 Gen9/ProLiant DL380 Gen9, BIOS P89 12/27/2015 > > The xen is installed. The crash occurred in DOM0. > > Regarding to the repro steps, it is a customer's test which does heavy disk I/O over NFS storage without any guest. > > > > What is the finial suggestion on this ? > If use wmb there, is the performance pulled down ? Since https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=dad42c3038a59d27fced28ee4ec1d4a891b28155 we batch allocations, so mlx4_en_refill_rx_buffers() is not called that often. I doubt the additional wmb() will have serious impact there. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933420AbeAYDzs (ORCPT ); Wed, 24 Jan 2018 22:55:48 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36946 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933234AbeAYDzq (ORCPT ); Wed, 24 Jan 2018 22:55:46 -0500 X-Google-Smtp-Source: AH8x2268qvCYG17+oTkrtg358FBKi1vqrPQxEMm7PBFyFawcT3r2env61zkECT5S/Z5ZUE4t4cFvoA== Message-ID: <1516852543.3715.43.camel@gmail.com> Subject: Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating From: Eric Dumazet To: "jianchao.wang" , Tariq Toukan , Jason Gunthorpe Cc: junxiao.bi@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Saeed Mahameed Date: Wed, 24 Jan 2018 19:55:43 -0800 In-Reply-To: <532b4d71-e2eb-35f3-894e-1c3288e7bc3f@oracle.com> References: <1515728542-3060-1-git-send-email-jianchao.w.wang@oracle.com> <20180112163247.GB15974@ziepe.ca> <1515775567.131759.42.camel@gmail.com> <53b1ac4d-a294-eb98-149e-65d7954243da@oracle.com> <1516376999.3606.39.camel@gmail.com> <339a7156-9ef1-1f3c-30b8-3cc3558d124e@mellanox.com> <532b4d71-e2eb-35f3-894e-1c3288e7bc3f@oracle.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-01-25 at 11:27 +0800, jianchao.wang wrote: > Hi Tariq > > On 01/22/2018 10:12 AM, jianchao.wang wrote: > > > > On 19/01/2018 5:49 PM, Eric Dumazet wrote: > > > > > On Fri, 2018-01-19 at 23:16 +0800, jianchao.wang wrote: > > > > > > Hi Tariq > > > > > > > > > > > > Very sad that the crash was reproduced again after applied the patch. > > > > > > Memory barriers vary for different Archs, can you please share more details regarding arch and repro steps? > > The hardware is HP ProLiant DL380 Gen9/ProLiant DL380 Gen9, BIOS P89 12/27/2015 > > The xen is installed. The crash occurred in DOM0. > > Regarding to the repro steps, it is a customer's test which does heavy disk I/O over NFS storage without any guest. > > > > What is the finial suggestion on this ? > If use wmb there, is the performance pulled down ? Since https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=dad42c3038a59d27fced28ee4ec1d4a891b28155 we batch allocations, so mlx4_en_refill_rx_buffers() is not called that often. I doubt the additional wmb() will have serious impact there.