From mboxrd@z Thu Jan 1 00:00:00 1970 From: Moti Haimovsky Subject: [PATCH v7 0/3] net/failsafe: add Rx interrupts support Date: Thu, 25 Jan 2018 10:07:12 +0200 Message-ID: <1516867635-67104-1-git-send-email-motih@mellanox.com> References: <1516810328-39383-3-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org, Moti Haimovsky To: gaetan.rivet@6wind.com, ferruh.yigit@intel.com Return-path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10061.outbound.protection.outlook.com [40.107.1.61]) by dpdk.org (Postfix) with ESMTP id E773E1E33 for ; Thu, 25 Jan 2018 09:07:33 +0100 (CET) In-Reply-To: <1516810328-39383-3-git-send-email-motih@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These three patches add support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single device to be handled by the application while internally it manages several devices on behalf of the application including packets transmission and reception. The Proposed failsafe Rx interrupt scheme follows this approach. The failsafe PMD will present the application with a single set of Rx interrupt vectors representing the failsafe Rx queues, while internally it will serve as an interrupt proxy for its subdevices. will allow applications to wait for Rx traffic from the failsafe PMD by registering and waiting for Rx events from its Rx queues. In order to support this the following is suggested: * Every Rx queue in the failsafe (virtual) device will be assigned * a Linux event file descriptor (efd) and an enable_interrupts flag. * The failsafe PMD will fill in its rte_intr_handle structure with the Rx efds assigned previously and register them with the EAL. * The failsafe driver will create a private epoll fd (epfd) and * will allocate enough space to handle all the Rx events from all its subdevices. * Acting as an application, for each Rx queue in each active subdevice the failsafe will: o Register the Rx queue with the EAL. o Pass the EAL the failsafe private epoll fd as the epfd to register the Rx queue event on. o Pass the EAL, as a parameter, the pointer to the failsafe Rx queue that handles this Rx queue. o Using the DPDK service callbacks, the failsafe PMD will launch an Rx proxy service that will Wait on the epoll fd for Rx events from the sub-devices. o For each Rx event received the proxy service will - Retrieve the pointer to failsafe Rx queue that handles this subdevice Rx queue from the user info returned by the EAL. - Trigger a failsafe Rx event on that queue by writing to the event fd unless interrupts are disabled for that queue. * The failsafe pmd will also implement the rx_queue_intr_enable * and rx_queue_intr_disable routines that will enable and disable Rx interrupts respectively on both on the failsafe and its subdevices. Moti Haimovsky (3): net/failsafe: register as an Rx interrupt mode PMD net/failsafe: slaves Rx interrupts registration net/failsafe: add Rx interrupts --- V7: Fixed compilation errors in FreeBSD. See 1516810328-39383-3-git-send-email-motih@mellanox.com V6: * Added a wrapper around epoll_create1 since it is not supported in FreeBSD. See: 1516193643-130838-1-git-send-email-motih@mellanox.com * Separated between routines' variables definition and initialization according to guidelines from Gaetan Rivet. V5: Modified code and split the patch into three patches in accordance to inputs from Gaetan Rivet in reply to 1516354344-13495-2-git-send-email-motih@mellanox.com V4: Fixed merge conflicts found during integration with other failsafe patches (See cover letter). V3: Fixed build failures in FreeBSD10.3_64 V2: Modifications according to inputs from Stephen Hemminger: * Removed unneeded (void *) casting. Fixed coding style warning. --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/Makefile | 6 + drivers/net/failsafe/failsafe.c | 4 + drivers/net/failsafe/failsafe_epoll.h | 10 + drivers/net/failsafe/failsafe_epoll_bsdapp.c | 19 + drivers/net/failsafe/failsafe_epoll_linuxapp.c | 18 + drivers/net/failsafe/failsafe_ether.c | 1 + drivers/net/failsafe/failsafe_intr.c | 505 +++++++++++++++++++++++++ drivers/net/failsafe/failsafe_ops.c | 102 +++++ drivers/net/failsafe/failsafe_private.h | 40 ++ 10 files changed, 706 insertions(+) create mode 100644 drivers/net/failsafe/failsafe_epoll.h create mode 100644 drivers/net/failsafe/failsafe_epoll_bsdapp.c create mode 100644 drivers/net/failsafe/failsafe_epoll_linuxapp.c create mode 100644 drivers/net/failsafe/failsafe_intr.c -- 1.8.3.1