From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4A406E814 for ; Thu, 25 Jan 2018 11:51:33 +0000 (UTC) Message-ID: <1516881091.2602.3.camel@intel.com> From: Mika Kahola Date: Thu, 25 Jan 2018 13:51:31 +0200 In-Reply-To: <20180123125642.58698-3-maarten.lankhorst@linux.intel.com> References: <20180123125642.58698-1-maarten.lankhorst@linux.intel.com> <20180123125642.58698-3-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/8] lib/igt_fb: Pass format to igt_calc_fb_size List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: mika.kahola@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , igt-dev@lists.freedesktop.org List-ID: T24gVHVlLCAyMDE4LTAxLTIzIGF0IDEzOjU2ICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBicHAgaXMgb25seSBzdWZmaWNpZW50IHRvIGNhbGN1bGF0ZSBkaW1lbnNpb25zIGZvciBw YWNrZWQgZm9ybWF0cywgaW4KPiBjYXNlIG9mIHBsYW5hciBmb3JtYXRzIHdlIG5lZWQgdG8gcGFz cyB0aGUgZHJtIGZvcm1hdCBmb3VyY2MsIHdoaWNoCj4gd2lsbCBnaXZlIHVzIGJldHRlciBpbmZv cm1hdGlvbi4KPiAKPiBUaGlzIGlzIHJlcXVpcmVkIGZvciBzdXBwb3J0aW5nIHBsYW5hciBmcmFt ZWJ1ZmZlcnMuCj4gCgpSZXZpZXdlZC1ieTogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVs LmNvbT4KCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiDCoGxpYi9pZ3RfZmIuY8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHwgMTAgKysrKysrLS0tLQo+IMKgbGliL2lndF9m Yi5owqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKgwqAyICstCj4g wqB0ZXN0cy9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYyB8wqDCoDQgKy0tLQo+IMKgMyBmaWxl cyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDM5YTgzYmFlMTc4YS4uZGEw N2QxYTllMjFmIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3RfZmIu Ywo+IEBAIC0xNDcsNyArMTQ3LDcgQEAgdm9pZCBpZ3RfZ2V0X2ZiX3RpbGVfc2l6ZShpbnQgZmQs IHVpbnQ2NF90Cj4gdGlsaW5nLCBpbnQgZmJfYnBwLAo+IMKgICogQGZkOiB0aGUgRFJNIGZpbGUg ZGVzY3JpcHRvcgo+IMKgICogQHdpZHRoOiB3aWR0aCBvZiB0aGUgZnJhbWVidWZmZXIgaW4gcGl4 ZWxzCj4gwqAgKiBAaGVpZ2h0OiBoZWlnaHQgb2YgdGhlIGZyYW1lYnVmZmVyIGluIHBpeGVscwo+ IC0gKiBAYnBwOiBieXRlcyBwZXIgcGl4ZWwgb2YgdGhlIGZyYW1lYnVmZmVyCj4gKyAqIEBmb3Jt YXQ6IGRybSBmb3VyY2MgcGl4ZWwgZm9ybWF0IGNvZGUKPiDCoCAqIEB0aWxpbmc6IHRpbGluZyBs YXlvdXQgb2YgdGhlIGZyYW1lYnVmZmVyIChhcyBmcmFtZWJ1ZmZlcgo+IG1vZGlmaWVyKQo+IMKg ICogQHNpemVfcmV0OiByZXR1cm5lZCBzaXplIGZvciB0aGUgZnJhbWVidWZmZXIKPiDCoCAqIEBz dHJpZGVfcmV0OiByZXR1cm5lZCBzdHJpZGUgZm9yIHRoZSBmcmFtZWJ1ZmZlcgo+IEBAIC0xNTUs MTAgKzE1NSwxMSBAQCB2b2lkIGlndF9nZXRfZmJfdGlsZV9zaXplKGludCBmZCwgdWludDY0X3QK PiB0aWxpbmcsIGludCBmYl9icHAsCj4gwqAgKiBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdmFsaWQg c3RyaWRlIGFuZCBzaXplIHZhbHVlcyBmb3IgYQo+IGZyYW1lYnVmZmVyIHdpdGggdGhlCj4gwqAg KiBzcGVjaWZpZWQgcGFyYW1ldGVycy4KPiDCoCAqLwo+IC12b2lkIGlndF9jYWxjX2ZiX3NpemUo aW50IGZkLCBpbnQgd2lkdGgsIGludCBoZWlnaHQsIGludCBicHAsCj4gdWludDY0X3QgdGlsaW5n LAo+ICt2b2lkIGlndF9jYWxjX2ZiX3NpemUoaW50IGZkLCBpbnQgd2lkdGgsIGludCBoZWlnaHQs IHVpbnQzMl90Cj4gZm9ybWF0LCB1aW50NjRfdCB0aWxpbmcsCj4gwqAJCcKgwqDCoMKgwqDCoHVu c2lnbmVkICpzaXplX3JldCwgdW5zaWduZWQgKnN0cmlkZV9yZXQpCj4gwqB7Cj4gwqAJdW5zaWdu ZWQgaW50IHRpbGVfd2lkdGgsIHRpbGVfaGVpZ2h0LCBzdHJpZGUsIHNpemU7Cj4gKwlpbnQgYnBw ID0gaWd0X2RybV9mb3JtYXRfdG9fYnBwKGZvcm1hdCk7Cj4gwqAJaW50IGJ5dGVfd2lkdGggPSB3 aWR0aCAqIChicHAgLyA4KTsKPiDCoAo+IMKgCWlndF9nZXRfZmJfdGlsZV9zaXplKGZkLCB0aWxp bmcsIGJwcCwgJnRpbGVfd2lkdGgsCj4gJnRpbGVfaGVpZ2h0KTsKPiBAQCAtMjQ5LDEzICsyNTAs MTIgQEAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKGludCBmZCwgaW50IHdpZHRoLAo+IGlu dCBoZWlnaHQsIHVpbnQzMl90IGZvcm1hdCwKPiDCoAkJCcKgwqDCoMKgdW5zaWduZWQgKnNpemVf cmV0LCB1bnNpZ25lZAo+ICpzdHJpZGVfcmV0LAo+IMKgCQkJwqDCoMKgwqBib29sICppc19kdW1i KQo+IMKgewo+IC0JaW50IGJwcCA9IGlndF9kcm1fZm9ybWF0X3RvX2JwcChmb3JtYXQpOwo+IMKg CWludCBibzsKPiDCoAo+IMKgCWlmICh0aWxpbmcgfHwgc2l6ZSB8fCBzdHJpZGUpIHsKPiDCoAkJ dW5zaWduZWQgY2FsY3VsYXRlZF9zaXplLCBjYWxjdWxhdGVkX3N0cmlkZTsKPiDCoAo+IC0JCWln dF9jYWxjX2ZiX3NpemUoZmQsIHdpZHRoLCBoZWlnaHQsIGJwcCwgdGlsaW5nLAo+ICsJCWlndF9j YWxjX2ZiX3NpemUoZmQsIHdpZHRoLCBoZWlnaHQsIGZvcm1hdCwgdGlsaW5nLAo+IMKgCQkJCcKg JmNhbGN1bGF0ZWRfc2l6ZSwKPiAmY2FsY3VsYXRlZF9zdHJpZGUpOwo+IMKgCQlpZiAoc3RyaWRl ID09IDApCj4gwqAJCQlzdHJpZGUgPSBjYWxjdWxhdGVkX3N0cmlkZTsKPiBAQCAtMjkwLDYgKzI5 MCw4IEBAIHN0YXRpYyBpbnQgY3JlYXRlX2JvX2Zvcl9mYihpbnQgZmQsIGludCB3aWR0aCwKPiBp bnQgaGVpZ2h0LCB1aW50MzJfdCBmb3JtYXQsCj4gwqAJCQlyZXR1cm4gLUVJTlZBTDsKPiDCoAkJ fQo+IMKgCX0gZWxzZSB7Cj4gKwkJaW50IGJwcCA9IGlndF9kcm1fZm9ybWF0X3RvX2JwcChmb3Jt YXQpOwo+ICsKPiDCoAkJaWYgKGlzX2R1bWIpCj4gwqAJCQkqaXNfZHVtYiA9IHRydWU7Cj4gwqAK PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5oIGIvbGliL2lndF9mYi5oCj4gaW5kZXggMzAwNGYw NjU2MDI5Li4xNTI3OThlOTg5NmIgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5oCj4gKysrIGIv bGliL2lndF9mYi5oCj4gQEAgLTkwLDcgKzkwLDcgQEAgZW51bSBpZ3RfdGV4dF9hbGlnbiB7Cj4g wqAKPiDCoHZvaWQgaWd0X2dldF9mYl90aWxlX3NpemUoaW50IGZkLCB1aW50NjRfdCB0aWxpbmcs IGludCBmYl9icHAsCj4gwqAJCQnCoMKgdW5zaWduZWQgKndpZHRoX3JldCwgdW5zaWduZWQKPiAq aGVpZ2h0X3JldCk7Cj4gLXZvaWQgaWd0X2NhbGNfZmJfc2l6ZShpbnQgZmQsIGludCB3aWR0aCwg aW50IGhlaWdodCwgaW50IGJwcCwKPiB1aW50NjRfdCB0aWxpbmcsCj4gK3ZvaWQgaWd0X2NhbGNf ZmJfc2l6ZShpbnQgZmQsIGludCB3aWR0aCwgaW50IGhlaWdodCwgdWludDMyX3QKPiBmb3JtYXQs IHVpbnQ2NF90IHRpbGluZywKPiDCoAkJwqDCoMKgwqDCoMKgdW5zaWduZWQgKnNpemVfcmV0LCB1 bnNpZ25lZCAqc3RyaWRlX3JldCk7Cj4gwqB1bnNpZ25lZCBpbnQKPiDCoGlndF9jcmVhdGVfZmJf d2l0aF9ib19zaXplKGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LAo+IGRpZmYgLS1naXQg YS90ZXN0cy9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYwo+IGIvdGVzdHMva21zX2Zyb250YnVm ZmVyX3RyYWNraW5nLmMKPiBpbmRleCAxNjAxY2FiNDViOWEuLmVhNTI5NzUzOGMzNCAxMDA2NDQK PiAtLS0gYS90ZXN0cy9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYwo+ICsrKyBiL3Rlc3RzL2tt c19mcm9udGJ1ZmZlcl90cmFja2luZy5jCj4gQEAgLTU0MSw3ICs1NDEsNiBAQCBzdGF0aWMgdm9p ZCBjcmVhdGVfZmIoZW51bSBwaXhlbF9mb3JtYXQgcGZvcm1hdCwKPiBpbnQgd2lkdGgsIGludCBo ZWlnaHQsCj4gwqB7Cj4gwqAJdWludDMyX3QgZm9ybWF0Owo+IMKgCXVuc2lnbmVkIGludCBzaXpl LCBzdHJpZGU7Cj4gLQlpbnQgYnBwOwo+IMKgCXVpbnQ2NF90IHRpbGluZ19mb3Jfc2l6ZTsKPiDC oAo+IMKgCXN3aXRjaCAocGZvcm1hdCkgewo+IEBAIC01NzYsMTMgKzU3NSwxMiBAQCBzdGF0aWMg dm9pZCBjcmVhdGVfZmIoZW51bSBwaXhlbF9mb3JtYXQKPiBwZm9ybWF0LCBpbnQgd2lkdGgsIGlu dCBoZWlnaHQsCj4gwqAJwqAqIHRoZSBzYW1lIHNpemUgcmVnYXJkbGVzcyBvZiB0aWxpbmcgc2lu Y2Ugd2Ugd2FudCB0bwo+IHByb3Blcmx5IGV4ZXJjaXNlCj4gwqAJwqAqIHRoZSBLZXJuZWwncyBz cGVjaWZpYyB0aWxpbmctY2hlY2tpbmcgY29kZSBwYXRocyB3aXRob3V0Cj4gYWNjaWRlbnRhbGx5 Cj4gwqAJwqAqIGhpdHRpbmcgc2l6ZS1jaGVja2luZyBvbmVzIGZpcnN0LiAqLwo+IC0JYnBwID0g aWd0X2RybV9mb3JtYXRfdG9fYnBwKGZvcm1hdCk7Cj4gwqAJaWYgKHBsYW5lID09IFBMQU5FX0NV UikKPiDCoAkJdGlsaW5nX2Zvcl9zaXplID0gTE9DQUxfRFJNX0ZPUk1BVF9NT0RfTk9ORTsKPiDC oAllbHNlCj4gwqAJCXRpbGluZ19mb3Jfc2l6ZSA9IG9wdC50aWxpbmc7Cj4gwqAKPiAtCWlndF9j YWxjX2ZiX3NpemUoZHJtLmZkLCB3aWR0aCwgaGVpZ2h0LCBicHAsCj4gdGlsaW5nX2Zvcl9zaXpl LCAmc2l6ZSwKPiArCWlndF9jYWxjX2ZiX3NpemUoZHJtLmZkLCB3aWR0aCwgaGVpZ2h0LCBmb3Jt YXQsCj4gdGlsaW5nX2Zvcl9zaXplLCAmc2l6ZSwKPiDCoAkJCcKgJnN0cmlkZSk7Cj4gwqAKPiDC oAlpZ3RfY3JlYXRlX2ZiX3dpdGhfYm9fc2l6ZShkcm0uZmQsIHdpZHRoLCBoZWlnaHQsIGZvcm1h dCwKPiB0aWxpbmcsIGZiLAotLSAKTWlrYSBLYWhvbGEgLSBJbnRlbCBPVEMKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0 CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=