All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hyun Kwon <hyun.kwon@xilinx.com>
To: dri-devel@lists.freedesktop.org
Cc: Hyun Kwon <hyun.kwon@xilinx.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [RFC v2 00/10] Support for formats with non-byte aligned components
Date: Thu, 25 Jan 2018 18:03:57 -0800	[thread overview]
Message-ID: <1516932247-10750-1-git-send-email-hyun.kwon@xilinx.com> (raw)

Hi,

This is RFC to follow up on adding new formats to DRM core. Previous discussion
can be found in [1].

These new formats are not byte addressable, whereas in many places in DRM core,
the assumption is that format bpp is byte aligned. Thus, in order to support
these formats correctly, additiona handling is needed. Initial approach was to
add the scaling factors to the format info. Those values were multiplied
directly to address extra bits in color components and gaps between components.
On the other hand, this series attempts to simplify such handling by adding
the macro-pixel concept with some additional helper function, based on
the previous discussion.

Still not entirely sure if this is best / simpliest  approach, so any feedback
would be appreciated.

This series includes some patches from downstream, but upstreaming on going,
drivers [2] to demonstrate how it can be used.

Patch 1 - 3 add additional information such as bpp, macro-pixel, and a helper.
Patch 4 - 5 are to demonstrate how additional information can be used.
Patch 6 - 7 add new formats to DRM core. New formats are added next to
	existing formats as it turned out those are not insance enough
	for a separate section
Patch 8 adds new formats to the client driver as an example.
Patch 9 - 10 add more fourccs which are used by downstream drivers currently
	in development.

Thanks,
-hyun

[1] https://lists.freedesktop.org/archives/dri-devel/2017-November/158744.html
[2] https://lists.freedesktop.org/archives/dri-devel/2018-January/162559.html

Hyun Kwon (9):
  drm: drm:fourcc: Add bpp information to struct drm_format_info
  drm: drm_fourcc: Introduce macro-pixel info to drm_format_info
  drm: fourcc: Add drm_format_plane_width_bytes()
  drm: xlnx: zynqmp: use drm_format_width_bytes
  drm: fb_cma_helper: Use drm_format_plane_width_bytes()
  drm: drm_fourcc: Add new 10bit formats to drm_format_info table
  drm: xlnx: zynqmp: Add XV15 and XV20 formats
  uapi: drm: drm_fourcc: Add new formats for Xilinx IPs
  drm: drm_fourcc: Add new formats to the drm format table

Jeffrey Mouroux (1):
  uapi: drm: New fourcc codes needed by Xilinx Video IP

 drivers/gpu/drm/drm_fb_cma_helper.c |   3 +-
 drivers/gpu/drm/drm_fourcc.c        | 193 +++++++++++++++++++++++-------------
 drivers/gpu/drm/xlnx/zynqmp_disp.c  |  22 +++-
 include/drm/drm_fourcc.h            |  14 +++
 include/uapi/drm/drm_fourcc.h       |  15 +++
 5 files changed, 177 insertions(+), 70 deletions(-)

-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2018-01-26  2:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26  2:03 Hyun Kwon [this message]
2018-01-26  2:03 ` [RFC v2 01/10] drm: drm:fourcc: Add bpp information to struct drm_format_info Hyun Kwon
2018-01-30 10:23   ` Daniel Vetter
2018-01-26  2:03 ` [RFC v2 02/10] drm: drm_fourcc: Introduce macro-pixel info to drm_format_info Hyun Kwon
2018-01-30 10:22   ` Daniel Vetter
2018-02-09  2:19     ` Hyun Kwon
2018-02-19  9:02       ` Daniel Vetter
2018-01-30 10:27   ` Daniel Vetter
2018-02-09  2:19     ` Hyun Kwon
2018-02-19  9:03       ` Daniel Vetter
2018-01-26  2:04 ` [RFC v2 03/10] drm: fourcc: Add drm_format_plane_width_bytes() Hyun Kwon
2018-01-26  2:04 ` [RFC v2 04/10] drm: xlnx: zynqmp: use drm_format_width_bytes Hyun Kwon
2018-01-26  2:04 ` [RFC v2 05/10] drm: fb_cma_helper: Use drm_format_plane_width_bytes() Hyun Kwon
2018-01-26  2:04 ` [RFC v2 06/10] uapi: drm: New fourcc codes needed by Xilinx Video IP Hyun Kwon
2018-01-26  2:04 ` [RFC v2 07/10] drm: drm_fourcc: Add new 10bit formats to drm_format_info table Hyun Kwon
2018-01-30 10:24   ` Daniel Vetter
2018-01-26  2:04 ` [RFC v2 08/10] drm: xlnx: zynqmp: Add XV15 and XV20 formats Hyun Kwon
2018-01-26  2:04 ` [RFC v2 09/10] uapi: drm: drm_fourcc: Add new formats for Xilinx IPs Hyun Kwon
2018-01-26  2:04 ` [RFC v2 10/10] drm: drm_fourcc: Add new formats to the drm format table Hyun Kwon
2018-01-30 10:25   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516932247-10750-1-git-send-email-hyun.kwon@xilinx.com \
    --to=hyun.kwon@xilinx.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=michal.simek@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.