From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chengguang Xu Subject: [PATCH] ceph: Check memory allocation result Date: Fri, 26 Jan 2018 14:54:43 +0800 Message-ID: <1516949683-127606-1-git-send-email-cgxu519@icloud.com> Cc: zyan@redhat.com, sage@redhat.com, davem@davemloft.net, idryomov@gmail.com, netdev@vger.kernel.org, Chengguang Xu To: ceph-devel@vger.kernel.org Return-path: Received: from mr11p00im-asmtp001.me.com ([17.110.69.252]:29918 "EHLO mr11p00im-asmtp001.me.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbeAZHzq (ORCPT ); Fri, 26 Jan 2018 02:55:46 -0500 Sender: netdev-owner@vger.kernel.org List-ID: Should check result of kstrndup() in case of memory allocation failure. Signed-off-by: Chengguang Xu --- net/ceph/ceph_common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c index 5c036d2..1e492ef 100644 --- a/net/ceph/ceph_common.c +++ b/net/ceph/ceph_common.c @@ -421,6 +421,10 @@ struct ceph_options * opt->name = kstrndup(argstr[0].from, argstr[0].to-argstr[0].from, GFP_KERNEL); + if (!opt->name) { + err = -ENOMEM; + goto out; + } break; case Opt_secret: opt->key = kzalloc(sizeof(*opt->key), GFP_KERNEL); -- 1.8.3.1