* [PATCH] block: drbd: Replace GFP_ATOMIC with GFP_KERNEL in drbd_resync_finished
@ 2018-01-26 14:44 Jia-Ju Bai
0 siblings, 0 replies; only message in thread
From: Jia-Ju Bai @ 2018-01-26 14:44 UTC (permalink / raw)
To: philipp.reisner, lars.ellenberg; +Cc: drbd-dev, linux-kernel, Jia-Ju Bai
After checking all possible call chains to drbd_resync_finished(),
my tool finds that this function is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
And it calls schedule_timeout_interruptible() before kmalloc(),
so it indicates that drbd_resync_finished()
can call function which can sleep.
Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/block/drbd/drbd_worker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index 1476cb3..7ea56db 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -883,7 +883,7 @@ int drbd_resync_finished(struct drbd_device *device)
* is not finished by now). Retry in 100ms. */
schedule_timeout_interruptible(HZ / 10);
- dw = kmalloc(sizeof(struct drbd_device_work), GFP_ATOMIC);
+ dw = kmalloc(sizeof(struct drbd_device_work), GFP_KERNEL);
if (dw) {
dw->w.cb = w_resync_finished;
dw->device = device;
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-01-26 14:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 14:44 [PATCH] block: drbd: Replace GFP_ATOMIC with GFP_KERNEL in drbd_resync_finished Jia-Ju Bai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.