From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbeAZXwg (ORCPT ); Fri, 26 Jan 2018 18:52:36 -0500 Received: from mail-dm3nam03on0084.outbound.protection.outlook.com ([104.47.41.84]:21584 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752340AbeAZXwc (ORCPT ); Fri, 26 Jan 2018 18:52:32 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; Subject: [PATCH 2/5] iommu/amd - Add a 'verbose' switch for IOMMU debugfs From: Gary R Hook To: iommu@lists.linux-foundation.org Cc: joro@8bytes.org, linux-kernel@vger.kernel.org Date: Fri, 26 Jan 2018 17:52:26 -0600 Message-ID: <151701074611.16448.6376879206073473408.stgit@taos> In-Reply-To: <151701071164.16448.3611271062222336838.stgit@taos> References: <151701071164.16448.3611271062222336838.stgit@taos> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: BL0PR1501CA0019.namprd15.prod.outlook.com (52.132.16.32) To CY4PR12MB1205.namprd12.prod.outlook.com (10.168.164.149) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c879e83c-6d10-4db1-322c-08d56517dcbf X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:CY4PR12MB1205; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1205;3:zutRuWKeEIOpxLv+ZTkkCOPphanZZauSWW1tG117TSMnJzMmIIxw7/SlvpquHpxxgGKetVoshnXFLb2dx6gHP06Gq+TsNSe0sMwg5t5L0iS4TGZReGHLif5pVK+yBRdF41/YAlmfyJQcjHZJVRB5beIGbZwru154qoQu9mpAEvjxjRWovoly/5ZNPyntGL26lTkldy0hrFEoO+BU9/5cHuG/ZLjeVYCup26CV+IUu+IHWoMCfb0RqkYIttuuZ2O5;25:TDpePXqSaEi14U/13zG3/e3cEBB0jcAbCtaejVNlTx165aZUlYRjAcR1huNvbFqanSjEi8EvOo8PGOtenv4WddwWtmFFJ+aYGjOh39ofLOdXTuucCsF2elQga9rIS6CVUKhHsPqEebcH+yWRiUDT62QXN7L8A2Wv8QIgcPha5RgPYKYkoBSk5b69IIkPHg+OKdkLBVVhnRgmkKgENflmpFJhd2VoKp4WfFU8YGVTuaI+oVVJ0cZkfp8JYXpwm0ip555emF0G+1L3Hf58PcUz/cb5+/xJ1DqS9MvViAHh+InTMV9gRfEnQIJIJrgFyAIeHkSO5krMGkbVyoKOfWg/Mw==;31:hgSCGZo59E7kZivqug+pU1Z5kyZgLeB86yUSr6csqDcVPWGL6DkdLhsFPDYtr7QMyvmv3Vi3UMFGaxEGS2VQhSom/9eRvItDd17zw2C9kwbudTzQD1qdmRT4290SkC1RgRX0A2bQwJkc54wkytu1z0C2TUPnYcuDenyVrnyjX28RZgkg7PyT+Rvt22wsj5PVo4NV8dxUVEhmSVtEQywTHnAaqI4bDNaMV+uLEVvuIaM= X-MS-TrafficTypeDiagnostic: CY4PR12MB1205: X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1205;20:Dwg2baPfxnrtUWiUbJiYau0niEacKYSr5t5IzCv3XqDRQb2GmH6tYO5iyxqAqu9pC9T9pD0K8tznbhtaav7NVgqlgqyhP2iJ25T/ii8IGuho9WOpeDLl5PVYl7ivoiQ+NoLwgXIPQ2kXr0UeqGsxRXxr42PaJ3iLY0SDIfytDjyUL4oerupt4GTqS3zl8Qt3qlwIHhfBIJyyVEUnxSChc/sq3ktNgOHYoKha74BT3KLr2azMt+8J0DA6e08NhTF5I9OMyc91UuYtwU7hDRzN/qIvu6vHmB4t92acKru6OIULXb9kH1y1Igne4d8+qNapaIGsaRZkNXIX89B/WT2EqTYaXs38XjjviBWphyB+c4VlOEl+JrigWYKwHkbbW6zaUFBcMCldpQ2aSazNssT2qVKGmdfgYfRQnrO3B9ukAuFUC4fXtRVTMsZjoMcwOcoAkfG48IK5GDbFb1AvtM6xT5rHuXJiwm0cNyO4pZNsaF2JQFxaCOQWW2SZQojmS7PA;4:6GXBDiNtBAAskm7lKcG9xFScAmUTD1fIizjSUMIYc6gZoDx34ctdDH9NbGRv0UiE1kgpI1L4c9FeHaW8wlwgl75hdDhm91HMr2DVrMrEAyBsFQinYXeKGYp5O2ULq6AnQ1ifLKzSjqa/FBJ65V7mZty8rMs6NHELJgn2jYWRDmBLpAmd1081BijG1+uI46wGuVdgZbshJyDzzX2RPIOBd7I73ETBgf/4HhUda7j9EwJlV3oxUCQVhNX3fp1HlG8OAm3/9MolC3UbPn9zLIecNJpy+FmYKPStr5qFg6BxTvGlcBosKCg3VTDrBRZkLigk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231078)(2400081)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:CY4PR12MB1205;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1205; X-Forefront-PRVS: 05641FD966 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(7916004)(39860400002)(366004)(376002)(39380400002)(396003)(346002)(189003)(199004)(33716001)(230700001)(90366009)(68736007)(478600001)(6486002)(72206003)(2361001)(106356001)(2351001)(2906002)(305945005)(26005)(7736002)(186003)(103116003)(86362001)(77096007)(9686003)(16526019)(6916009)(66066001)(50466002)(2950100002)(59450400001)(76176011)(23676004)(52116002)(6666003)(5660300001)(33896004)(47776003)(8936002)(81166006)(2486003)(6116002)(4326008)(97736004)(3846002)(105586002)(16576012)(386003)(53936002)(83506002)(316002)(8676002)(58126008)(25786009)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1205;H:[127.0.1.1];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMjA1OzIzOlQ3NGZvam1EWllCMmdOMDZoWHhHRHFob2xR?= =?utf-8?B?Yk9xbDFhQVdyb09GdTZDM1lqMGgyMzJnSjBVcmtHbFBCUUdTdDUvTEhQa1Y4?= =?utf-8?B?dWVRZjA1Ri9pbXFqMDVRWkw1K2JYTHBZdDFUY1dvMXVSa1hiWm51d2JvVWpJ?= =?utf-8?B?R3JzYlpFNmw3bU13UVBWdDBNVDJjZTl5bFdFRFIvM1k2RVErTFJmb3orNFNk?= =?utf-8?B?KzVQY0RTWHZNVGtYcm1YM2FtSmJRd0ZLbVZnek9HeU1BY01sblhXUFB3cGNC?= =?utf-8?B?KzFlRGkxY20wTWRnQzg5Mm1qWS9sbzlOME83a3pIaSthUHVUN1k2LzZUYXNL?= =?utf-8?B?bGFDbHkwY0pqc0gyOUx3Tkt4YXhLbzZLL3RFK0hqS21YT25VcEF6M01DMFdj?= =?utf-8?B?T1VueUxOY3N3dFBEMHl1M1hORENnNzJrVW9xTm42dVNoQURiMUdBRXhLVkVX?= =?utf-8?B?VzlJeElKYVltZW0xVjB4K1ltL2ZDRzJFbStXV2pwaFlTaXhQcEdlangwMksx?= =?utf-8?B?L2RlbCttRXR2SVFjMEtmOGFrOG9aYXBaVDMxVkVwWGhLR3lYWHZ1RDhtQnYy?= =?utf-8?B?MFBsRklJMHdIemtiOFNKU296UkFjTmRyUnlvTFN0QjA3UjZNb0xrVWtLRVFS?= =?utf-8?B?RnZ2VmZTdnlCQWFzc2FKeFZ2V2lsNkxHN0wxL2pZZnlOaXBKWWNTemVsd3gy?= =?utf-8?B?MTI1c2ZrMXJ4RGFZRk8rT25QaVNqNURYSUZpU3EwM2I0KzlKM0krdVVOWWJ6?= =?utf-8?B?NXVYWEJVOUk2UXVaSC82c1JWcHRpRDJHNTZBMUhoY05RREdaNlE3bzgxUHNT?= =?utf-8?B?MVFuS1BlUW5Qa2NneWc0aW5iZEFGemlKZzFuQ2U3TFYzQjNZbUxoMUlxYUhv?= =?utf-8?B?aFkrUDFZRlo3WlQ4cnJjMEtLOE9xcmEreS9va3VGVEhGZUlUbENXVWZHM21Z?= =?utf-8?B?TEl0UXl5NVdzV1RCaTMveHBLUVh0S2tlbGhoei9iQ2F2YlBrZXVvSEdUZ1hv?= =?utf-8?B?cWlOOG5hYnJmWkI5N0lReHJUK0I1RW44U3NGZDBVbjFUTXlZV201U0tHbWRV?= =?utf-8?B?eG10cGpqdlBEblFac3VpV3RpRDNUdDBjckxjamlQU2NkWVp4ZE05VTFBL2h3?= =?utf-8?B?eW4xRHZIOGM1OTMycjE1RmFMT2dFSTRTL2liSWJHTlcrK25wUGsvQmhPNEJm?= =?utf-8?B?NmgwQTI2R3VjNGJPaGZDazU3TWI4NUZLUnN0eWFqTGpiVGU1U3EzcEtwd2ZD?= =?utf-8?B?THdadWFiOEdCYmhqZERJMGhvZzREMXZNU0lzcEM0WEFCK1Q4WW8zM080WDk1?= =?utf-8?B?K3RMbEF6SFQvaTFmWVFOVWQ5SWVkc3FTK29WYnpEYkF3NGh1d2t4Q0xVaGRK?= =?utf-8?B?QStwZVRzNGlERUN4dTNOa2pxMmQ5L0xvZnV0MFRjUm5ERWlPNFNpNnYzOGJR?= =?utf-8?B?ODFWRDZyKzlLbklFZFhsNCtEb2Nabk1oWFJpUU1zdHJpMXpuMkxzdzkyUDM3?= =?utf-8?B?QUdqRjJ2NkVpekdGUlJ0c0hUaE92RWl4VVhXSlovQXZ6TmFPODZrbFhuNW8r?= =?utf-8?B?NmFjb1g0dFg0YkdCY29IbzVBQUMzRG9mSUlDd09zczZqNGZsa2E0Z2dza1FC?= =?utf-8?B?dE9MUW5VRDlvNlJhNEV4MlEvQ1NzU2pyOFlCUmNnNkdRa0wzRW9NYzlWdmZx?= =?utf-8?B?SUxtLzJTNXFXUXlrRm1qTDJOajhhYURFTjh3TXJsc0xTRk92S2g5MEpIVjFV?= =?utf-8?B?bmVxaEJST0Y2TnZvNkc5Y0hNcWRQYzdjRklJcmphSm94WnlJYnZGa3dKL2xF?= =?utf-8?Q?uRl/+Y8qGDGEO?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1205;6:AZeujRLmchq8mUf4XwyIDLHLXN7yAyz79vDmoJiiqoiodDiqcPPkTIRbpNxhhWvlnZbzpQvWdY6sI0aqPiNLVcztq2MSzHAI1V8QmRfXdP2VpLZMlQeD+QR8cRJqyXykSORrETCG5x0CCM+vJifFWGvPlIld467JpiHbrtnoAfIDyr175Y0U4WXz6Z1mGI7LlCuQa7Lu6nx9ey9xCa5SkjY1ZinPUmOQjitiSzlGigGc7SYnXeO9k9YAFm6H7ab0lCLURA20Gz0ksOwSR2NCCScVuCiW00NpwWLcsr6JnAjWp5ajF+hGqBpmpzryNaklsAHTChNNAtA/d2sC5lwwmfTUHendNe66CF39JuEnqgU=;5:zNAY89QfWWzZG+EFKYmIxGBYgcVr6a1bgkVwlXzOYGsLjMYMzzypAKLDNfGwxUYXbAA1Fq3SH9g7885QI1XkRu4T25BfYcrp/1iPbk2y780zBgRZXV7TV7ljUMdSaLR4ccLdpCDt69UavfV+u+RY+papscH44Lok8Z+MAhCWS4M=;24:4aYbQzTsyLkmU28sxuCyTjT25XzdZBAIYvcV4UdDOqSEF22Lh1CWnEeSfPZITCFpQC08GE2rjIOdMcXEa4GHB16/oXyTkoM5OmfSbk7R978=;7:RiKwvdwCjLE6lzq1xdR8HYiHrxC3ENwZShNA42KR40Vol4WoZY+GcmbUhUFtYphmV91KASu9Q3ruBHoAq5bzJEBykfe2qnvuXI47FkYNjQgqIhOWaCbQoTWfvURl+dTP9m4M1YhzQ/a0BMtzZNkMEgdYThnxLNuNJJ+NAo6evqtrNEyORNIwlzUJDApAMpYtlodfs1SsQho8wEWFJUH1jlddy0vPTW7Lr2NPurKdtN7uyZuCI5L8Yo6LmehKdpBT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1205;20:LsEQyW/aMbzaIYF5obGEW968BSWaNgwFHS4Z0sf0KLI5gPVIng9wDQW56Z3CmOoSNuC6Z1LQUPZRwaRun/Iw4RE8iND6DLFDsUCPB5IYu4LWXOUpY8XeyNRIUpbtkb81DujHcGD+Rq3TPDPd7iCw2aXCtDlvL0FX2+mwllT9wD7DOWadrBRdjWjP8llBu4VMfw1u+pPWz9M+wbGpH8T3YWAZwx9ZX+U5lW50IUSN8hiJ80xODzcL3Zy8JVXNMFwR X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 23:52:29.8245 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c879e83c-6d10-4db1-322c-08d56517dcbf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1205 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Enable more descriptive debugfs output via a 'verbose' variable. Signed-off-by: Gary R Hook --- drivers/iommu/amd_iommu_debugfs.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu_debugfs.c b/drivers/iommu/amd_iommu_debugfs.c index 18f70934961d..c449f3a7452c 100644 --- a/drivers/iommu/amd_iommu_debugfs.c +++ b/drivers/iommu/amd_iommu_debugfs.c @@ -27,6 +27,8 @@ static DEFINE_RWLOCK(iommu_debugfs_lock); #define MAX_NAME_LEN 20 +static unsigned int amd_iommu_verbose; + static unsigned int amd_iommu_count_valid_dtes(int start, int end) { unsigned int n = 0; @@ -61,7 +63,10 @@ static ssize_t amd_iommu_debugfs_dtecount_read(struct file *filp, return -ENOMEM; n = amd_iommu_count_valid_dtes(0, 0xFFFF); - oboff += OSCNPRINTF("%d\n", n); + if (amd_iommu_verbose) + oboff += OSCNPRINTF("# DTEs: %d\n", n); + else + oboff += OSCNPRINTF("%d\n", n); ret = simple_read_from_buffer(ubuf, count, offp, obuf, oboff); kfree(obuf); @@ -79,6 +84,7 @@ static const struct file_operations amd_iommu_debugfs_dtecount_ops = { void amd_iommu_debugfs_setup(struct amd_iommu *iommu) { char name[MAX_NAME_LEN + 1]; + struct dentry *d_verbose; struct dentry *d_dte; unsigned long flags; @@ -97,6 +103,12 @@ void amd_iommu_debugfs_setup(struct amd_iommu *iommu) if (!iommu->debugfs_instance) goto err; + d_verbose = debugfs_create_u32("verbose", 0600, + iommu->debugfs_instance, + &amd_iommu_verbose); + if (!d_verbose) + goto err; + d_dte = debugfs_create_file("count", 0400, iommu->debugfs_instance, iommu, &amd_iommu_debugfs_dtecount_ops);