From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chee, Tien Fong <tien.fong.chee@intel.com>
Date: Thu, 1 Feb 2018 07:06:28 +0000
Subject: [U-Boot] [PATCH v7 3/3] common: Generic firmware loader for
	file system
In-Reply-To: <ae135c72-f66e-856c-7172-64091e0f46d6@denx.de>
References: <1517310984-71347-1-git-send-email-tien.fong.chee@intel.com>
 <1517310984-71347-4-git-send-email-tien.fong.chee@intel.com>
 <ae135c72-f66e-856c-7172-64091e0f46d6@denx.de>
Message-ID: <1517468787.2520.2.camel@intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On Tue, 2018-01-30 at 13:12 +0100, Marek Vasut wrote:
> On 01/30/2018 12:16 PM, tien.fong.chee at intel.com wrote:
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> > This is file system generic loader which can be used to load
> > the file image from the storage into target such as memory.
> > The consumer driver would then use this loader to program whatever,
> > ie. the FPGA device.
> > 
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > Reviewed-by: Lothar Waßmann <LW@KARO-electronics.de>
> > ---
> >  common/Kconfig             |   9 ++
> >  common/Makefile            |   1 +
> >  common/fs_loader.c         | 326
> > +++++++++++++++++++++++++++++++++++++++++++++
> >  doc/README.firmware_loader |  76 +++++++++++
> >  include/fs_loader.h        |  28 ++++
> >  5 files changed, 440 insertions(+)
> >  create mode 100644 common/fs_loader.c
> >  create mode 100644 doc/README.firmware_loader
> >  create mode 100644 include/fs_loader.h
> [...]
> 
> > 
> > +#ifdef CONFIG_CMD_UBIFS
> > +static int mount_ubifs(struct device_location *location)
> > +{
> > +	int ret;
> > +	char cmd[32];
> > +
> > +	snprintf(cmd, sizeof(location->mtdpart), "ubi part %s",
> > +		 location->mtdpart);
> > +
> > +	ret = run_command(cmd, 0);
> Can you call the UBI functions directly instead of invoking the U-
> Boot
> command parser ?
> 
Okay.
> > 
> > +	if (ret)
> > +		return ret;
> > +
> > +	snprintf(cmd, sizeof(location->ubivol), "ubifsmount %s",
> > +		 location->ubivol);
> > +
> > +	ret = run_command(cmd, 0);
> DTTO here ...
> 
Okay.

Could i submit the next version immediately for this minor change?

> > 
> > +	return ret;
> > +}
> > +
> > +static int umount_ubifs(void)
> > +{
> > +	return cmd_ubifs_umount();
> > +}
> > +#else
> > +static int mount_ubifs(struct device_location *location)
> > +{
> > +	debug("Error: Cannot load image: no UBIFS support\n");
> > +	return -ENOSYS;
> > +}
> > +#endif
> [...]