All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rob Herring <robh@kernel.org>,
	Igor Stoppa <igor.stoppa@huawei.com>,
	Kate Stewart <kstewart@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andy Whitcroft <apw@canonical.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check
Date: Fri, 02 Feb 2018 11:06:03 -0800	[thread overview]
Message-ID: <1517598363.7489.126.camel@perches.com> (raw)
In-Reply-To: <CAL_JsqK+1Z_vuFE_po1VCxkSc112OFmgCiwM7F1S0mH6gw3KHQ@mail.gmail.com>

On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote:
> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa <igor.stoppa@huawei.com> wrote:
> > On 02/02/18 17:40, Rob Herring wrote:
> > > Add SPDX license tag check based on the rules defined in
> > 
> > Shouldn't it also check that the license is compatible?
> > 
> 
> Perhaps we shouldn't try to script legal advice.

True.

I believe what was meant was that the
entry was a valid SPDX License entry
that already exists as a specific file
in the LICENSES/ path.

So that entry must be some combination of:

$ git ls-files LICENSES/ | cut -f3- -d'/' | sort
BSD-2-Clause
BSD-3-Clause
BSD-3-Clause-Clear
GPL-1.0
GPL-2.0
LGPL-2.0
LGPL-2.1
Linux-syscall-note
MIT
MPL-1.1

>From my perspective, it'd be better if the
various + uses had their own individual
license files in the LICENSES/ path.

Right now, there are many missing licenses
that are already used by various existing
SPDX-License-Identifier: entries.


APACHE-2.0
BSD
CDDL
CDDL-1.0
ISC
GPL-1.0+
GPL-2.0+
LGPL-2.1+
OpenSSL

There are odd entries like:

GPL-2.0-only

Parentheses around AND/OR aren't consistent.

  reply	other threads:[~2018-02-02 19:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 15:40 Rob Herring
2018-02-02 15:49 ` Igor Stoppa
2018-02-02 16:12   ` Greg Kroah-Hartman
2018-02-02 16:17     ` Jonathan Corbet
2018-02-02 18:27   ` Rob Herring
2018-02-02 19:06     ` Joe Perches [this message]
2018-02-02 20:18       ` Kate Stewart
2018-02-02 20:26         ` Kate Stewart
2018-02-02 20:55         ` Joe Perches
2018-02-08 14:41         ` Philippe Ombredanne
2018-02-02 20:57       ` Rob Herring
2018-02-02 21:10         ` Joe Perches
2018-02-03 13:41       ` Igor Stoppa
2018-02-08 14:44         ` Philippe Ombredanne
2018-02-08 14:35       ` Philippe Ombredanne
2018-02-08 17:24         ` Joe Perches
2018-02-08 18:09           ` Philippe Ombredanne
2018-02-02 21:18 ` Joe Perches
2018-02-09  0:35   ` Joe Perches
2018-02-09  5:58     ` Philippe Ombredanne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517598363.7489.126.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=igor.stoppa@huawei.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.