From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Deprecate I915_SET_COLORKEY_NONE
Date: Fri, 02 Feb 2018 21:17:08 +0000 [thread overview]
Message-ID: <151760622899.15322.1749558368592305341@mail.alporthouse.com> (raw)
In-Reply-To: <20180202204231.27905-1-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2018-02-02 20:42:31)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Deprecate the silly I915_SET_COLORKEY_NONE flag. The obvious
> way to disable colorkey is to just set flags to 0, which is
> exactly what the intel ddx has been doing all along.
I can confirm that I never realised the flag existed. Just not setting
either the dst or src flags made sense to me.
> Currently when userspace sets the flags to 0, we end up in a
> funny state where colorkey is disabled, but various colorkey
> vs. scaling checks still consider colorkey to be enabled, and
> thus we don't allow plane scaling to kick in.
>
> In case there is some other userspace out there that actually
> uses this flag (unlikely as this is an i915 specific uapi)
> we'll keep on accepting it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-02 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 20:42 [PATCH] drm/i915: Deprecate I915_SET_COLORKEY_NONE Ville Syrjala
2018-02-02 21:17 ` Chris Wilson [this message]
2018-02-05 19:27 ` Ville Syrjälä
2018-02-02 21:39 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-03 7:32 ` ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151760622899.15322.1749558368592305341@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.