From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Benjamin Marzinski" Subject: [PATCH v2 4/7] multipathd: remove unused configure parameter Date: Thu, 8 Feb 2018 17:56:04 -0600 Message-ID: <1518134167-15938-5-git-send-email-bmarzins@redhat.com> References: <1518134167-15938-1-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1518134167-15938-1-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: device-mapper development List-Id: dm-devel.ids configure() is always called with start_waiters=1, so there is no point in having the parameter. Remove it. Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/multipathd/main.c b/multipathd/main.c index dbf9890..51e0f5e 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -1955,7 +1955,7 @@ checkerloop (void *ap) } int -configure (struct vectors * vecs, int start_waiters) +configure (struct vectors * vecs) { struct multipath * mpp; struct path * pp; @@ -2054,11 +2054,9 @@ configure (struct vectors * vecs, int start_waiters) i--; continue; } - if (start_waiters) { - if (start_waiter_thread(mpp, vecs)) { - remove_map(mpp, vecs, 1); - i--; - } + if (start_waiter_thread(mpp, vecs)) { + remove_map(mpp, vecs, 1); + i--; } } return 0; @@ -2125,7 +2123,7 @@ reconfigure (struct vectors * vecs) rcu_assign_pointer(multipath_conf, conf); call_rcu(&old->rcu, rcu_free_config); - configure(vecs, 1); + configure(vecs); return 0; -- 2.7.4