From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
Date: Thu, 25 Aug 2011 16:37:32 +0530 (IST)
Subject: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller
 driver for Armada100
In-Reply-To: <583672539.2717.1314270415380.JavaMail.root@ahm.einfochips.com>
Message-ID: <1518158435.2722.1314270452411.JavaMail.root@ahm.einfochips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


----- "Marek Vasut" <marek.vasut@gmail.com> wrote:

[...]
> > +static void abortdma(struct eth_device *dev)
> > +{
> > +	struct armdfec_device *darmdfec = to_darmdfec(dev);
> > +	struct armdfec_reg *regs = darmdfec->regs;
> > +	int delay;
> > +	int maxretries = 40;
> > +
> > +	do {
> > +		writel(SDMA_CMD_AR | SDMA_CMD_AT, &regs->sdma_cmd);
> > +		udelay(100);
> > +
> > +		delay = 10;
> > +		while ((readl(&regs->sdma_cmd) &
> > +			(SDMA_CMD_AR | SDMA_CMD_AT))
> > +			&& delay-- > 0) {
> > +			udelay(10);
> > +		}
> > +	} while (maxretries-- > 0 && delay <= 0);
> 
> Didn't I comment on this one in V1?
> 

I modified it as follows... Is it more readable now? :)

while (maxretries--) {
	writel(SDMA_CMD_AR | SDMA_CMD_AT, &regs->sdma_cmd);
	udelay(100);

	delay = 10;
	while ((readl(&regs->sdma_cmd) & (SDMA_CMD_AR | SDMA_CMD_AT))
			&& delay--)
		udelay(10);
	if(delay)
		break;
}

Regards,
Ajay Bhargav