All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: dri-devel@lists.freedesktop.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jyri Sarha <jsarha@ti.com>, Benoit Parrot <bparrot@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [PATCH 17/24] drm/omap: fix WBDELAYCOUNT for HDMI
Date: Mon, 12 Feb 2018 11:44:47 +0200	[thread overview]
Message-ID: <1518428694-18018-18-git-send-email-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <1518428694-18018-1-git-send-email-tomi.valkeinen@ti.com>

For HDMI, WBDELAYCOUNT starts counting at the start of vsync, not at the
start of vfp.

This patch adjusts the wbdelay for HDMI accordingly.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/omapdrm/dss/dispc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
index 7f9186894bd5..669ee9df224b 100644
--- a/drivers/gpu/drm/omapdrm/dss/dispc.c
+++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
@@ -2712,8 +2712,12 @@ int dispc_wb_setup(const struct omap_dss_writeback_info *wi,
 	} else {
 		int wbdelay;
 
-		wbdelay = min(vm->vfront_porch +
-			      vm->vsync_len + vm->vback_porch, (u32)255);
+		if (channel_in == DSS_WB_TV_MGR)
+			wbdelay = min(vm->vsync_len + vm->vback_porch,
+				(u32)255);
+		else
+			wbdelay = min(vm->vfront_porch +
+				vm->vsync_len + vm->vback_porch, (u32)255);
 
 		/* WBDELAYCOUNT */
 		REG_FLD_MOD(DISPC_OVL_ATTRIBUTES2(plane), wbdelay, 7, 0);
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-02-12  9:45 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12  9:44 [PATCH 00/24] drm/omap: misc patches Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 01/24] drm/omap: fix omap_fbdev_free() when omap_fbdev_create() wasn't called Tomi Valkeinen
2018-02-27 11:28   ` Laurent Pinchart
2018-02-27 11:53     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 02/24] drm/omap: cleanup fbdev init/free Tomi Valkeinen
2018-02-27 11:38   ` Laurent Pinchart
2018-02-28  8:49     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 03/24] drm/omap: add HPD support to connector-dvi Tomi Valkeinen
2018-02-27 12:58   ` Laurent Pinchart
2018-02-28  9:00     ` Tomi Valkeinen
     [not found] ` <1518428694-18018-1-git-send-email-tomi.valkeinen-l0cyMroinI0@public.gmane.org>
2018-02-12  9:44   ` [PATCH 04/24] dt-bindings: display: add HPD gpio to DVI connector Tomi Valkeinen
2018-02-19  0:11     ` Rob Herring
2018-02-27 13:01     ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 05/24] drm/omap: Use devm_kzalloc() to allocate omap_drm_private Tomi Valkeinen
2018-02-27 13:03   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 06/24] drm/omap: Allocate drm_device earlier and unref it as last step Tomi Valkeinen
2018-02-27 13:07   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 07/24] drm/omap: Manage the usable omap_dss_device list within omap_drm_private Tomi Valkeinen
2018-02-27 13:19   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 08/24] drm/omap: Separate the dssdevs array setup from the connect function Tomi Valkeinen
2018-02-27 13:23   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 09/24] drm/omap: Do dss_device (display) ordering in omap_drv.c Tomi Valkeinen
2018-02-27 13:26   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 10/24] drm/omap: dss: Remove display ordering from dss/display.c Tomi Valkeinen
2018-02-27 13:30   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 11/24] drm/omap: Add kernel parameter to specify the desired display order Tomi Valkeinen
2018-02-27 13:35   ` Laurent Pinchart
2018-02-28  9:16     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 12/24] drm/omap: Init fbdev emulation only when we have displays Tomi Valkeinen
2018-02-27 13:36   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 13/24] drm/omap: remove leftover enums Tomi Valkeinen
2018-02-27 13:36   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 14/24] drm/omap: dispc: disp_wb_setup to check return code Tomi Valkeinen
2018-02-27 13:38   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 15/24] drm/omap: Add pclk setting case when channel is DSS_WB Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 16/24] drm/omap: set WB channel-in in wb_setup() Tomi Valkeinen
2018-02-12  9:44 ` Tomi Valkeinen [this message]
2018-02-12  9:44 ` [PATCH 18/24] drm/omap: fix WBDELAYCOUNT with interlace Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 19/24] drm/omap: fix WB height " Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 20/24] drm/omap: fix scaling limits for WB Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 21/24] drm/omap: add writeback funcs to dispc_ops Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 22/24] drm/omap: fix maximum sizes Tomi Valkeinen
2018-02-27 13:42   ` Laurent Pinchart
2018-02-28  9:10     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 23/24] drm/omap: Allow HDMI audio setup even if we do not have video configured Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 24/24] drm/omap: cleanup color space conversion Tomi Valkeinen
2018-02-27 14:08   ` Laurent Pinchart
2018-02-28 10:09     ` Tomi Valkeinen
2018-02-28 10:13       ` Laurent Pinchart
2018-02-28 10:22         ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518428694-18018-18-git-send-email-tomi.valkeinen@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=bparrot@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.