Re: [PATCH] drm/i915: Hold rpm wakeref for printing the engine's register state

[Chris Wilson <chris@chris-wilson.co.uk>]

Quoting Mika Kuoppala (2018-02-12 13:28:54)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > When dumping the engine, we print out the current register values. This
> > requires the rpm wakeref. If the device is alseep, we can assume the
> > engine is asleep (and the register state is uninteresting) so skip and
> > only acquire the rpm wakeref if the device is already awake.
> >
> > Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> > ---
> > +     if (intel_runtime_pm_get_if_in_use(engine->i915)) {
> > +             intel_engine_print_registers(engine, m);
> > +             intel_runtime_pm_put(engine->i915);
> > +     } else {
> > +             drm_printf(m, "Device is alseep; skipping register dump\n");
> > +     }
> 
> s/alseep/asleep
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Done, and both pushed. Now to try Tvrtko's warning patch on the new
baseline. Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx