From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: Call i915_pipe_update_start with uncore.lock held. Date: Mon, 12 Feb 2018 15:44:47 +0000 Message-ID: <151845028749.18923.17946119254067208206@mail.alporthouse.com> References: <20180209095404.76418-1-maarten.lankhorst@linux.intel.com> <20180209095404.76418-4-maarten.lankhorst@linux.intel.com> <151844879607.18923.15930170017428937869@mail.alporthouse.com> <75c049c5-64ce-ae65-32b8-560a3e3e182d@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id B915C89144 for ; Mon, 12 Feb 2018 15:44:52 +0000 (UTC) In-Reply-To: <75c049c5-64ce-ae65-32b8-560a3e3e182d@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBNYWFydGVuIExhbmtob3JzdCAoMjAxOC0wMi0xMiAxNTozOToxNikKPiBPcCAxMi0w Mi0xOCBvbSAxNjoxOSBzY2hyZWVmIENocmlzIFdpbHNvbjoKPiA+IFF1b3RpbmcgTWFhcnRlbiBM YW5raG9yc3QgKDIwMTgtMDItMDkgMDk6NTQ6MDIpCj4gPj4gVGhpcyByZXF1aXJlcyBiZWluZyBh YmxlIHRvIHJlYWQgdGhlIHZibGFuayBjb3VudGVyIHdpdGggdGhlCj4gPj4gdW5jb3JlLmxvY2sg YWxyZWFkeSBoZWxkLiBUaGlzIGlzIGFsc28gYSBwcmVwYXJhdGlvbiBmb3IKPiA+PiBiZWluZyBh YmxlIHRvIHJ1biB0aGUgZW50aXJlIHZibGFuayB1cGRhdGUgc2VxdWVuY2Ugd2l0aAo+ID4+IHRo ZSB1bmNvcmUgbG9jayBoZWxkLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5r aG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyAgICAgfCA2NiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKystLS0tLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdHJh Y2UuaCAgIHwgIDUgKystCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAg IHwgIDEgKwo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8ICAzICst Cj4gPj4gIDQgZmlsZXMgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0p Cj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+PiBpbmRleCBlZGE5NTQzYTAxOTku LjZjNDkxZTYzZTA3YyAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2lycS5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4+IEBA IC03MzYsMTMgKzczNiwxMiBAQCBzdGF0aWMgdm9pZCBpOTE1X2VuYWJsZV9hc2xlX3BpcGVzdGF0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+PiAgLyogQ2FsbGVkIGZyb20g ZHJtIGdlbmVyaWMgY29kZSwgcGFzc2VkIGEgJ2NydGMnLCB3aGljaAo+ID4+ICAgKiB3ZSB1c2Ug YXMgYSBwaXBlIGluZGV4Cj4gPj4gICAqLwo+ID4+IC1zdGF0aWMgdTMyIGk5MTVfZ2V0X3ZibGFu a19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ID4+ ICtzdGF0aWMgdTMyIF9faTkxNV9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0IGludGVsX2NydGMg KmNydGMpCj4gPj4gIHsKPiA+PiAtICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+PiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ID4+ICAgICAgICAgaTkxNV9y ZWdfdCBoaWdoX2ZyYW1lLCBsb3dfZnJhbWU7Cj4gPj4gICAgICAgICB1MzIgaGlnaDEsIGhpZ2gy LCBsb3csIHBpeGVsLCB2Ymxfc3RhcnQsIGhzeW5jX3N0YXJ0LCBodG90YWw7Cj4gPj4gLSAgICAg ICBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSA9ICZkZXYtPnZibGFua1twaXBl XS5od21vZGU7Cj4gPj4gLSAgICAgICB1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+ID4+ICsgICAg ICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSAmY3J0Yy0+YmFzZS5kZXYt PnZibGFua1tjcnRjLT5waXBlXS5od21vZGU7Cj4gPiBsb2NrZGVwX2Fzc2VydF9oZWxkKCZkZXZf cHJpdi0+dW5jb3JlLmxvY2spOwo+ID4KPiA+PiAgCj4gPj4gICAgICAgICBodG90YWwgPSBtb2Rl LT5jcnRjX2h0b3RhbDsKPiA+PiAgICAgICAgIGhzeW5jX3N0YXJ0ID0gbW9kZS0+Y3J0Y19oc3lu Y19zdGFydDsKPiA+PiBAQCAtNzU2LDEwICs3NTUsOCBAQCBzdGF0aWMgdTMyIGk5MTVfZ2V0X3Zi bGFua19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ ID4+ICAgICAgICAgLyogU3RhcnQgb2YgdmJsYW5rIGV2ZW50IG9jY3VycyBhdCBzdGFydCBvZiBo c3luYyAqLwo+ID4+ICAgICAgICAgdmJsX3N0YXJ0IC09IGh0b3RhbCAtIGhzeW5jX3N0YXJ0Owo+ ID4+ICAKPiA+PiAtICAgICAgIGhpZ2hfZnJhbWUgPSBQSVBFRlJBTUUocGlwZSk7Cj4gPj4gLSAg ICAgICBsb3dfZnJhbWUgPSBQSVBFRlJBTUVQSVhFTChwaXBlKTsKPiA+PiAtCj4gPj4gLSAgICAg ICBzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4g Pj4gKyAgICAgICBoaWdoX2ZyYW1lID0gUElQRUZSQU1FKGNydGMtPnBpcGUpOwo+ID4+ICsgICAg ICAgbG93X2ZyYW1lID0gUElQRUZSQU1FUElYRUwoY3J0Yy0+cGlwZSk7Cj4gPj4gIAo+ID4+ICAg ICAgICAgLyoKPiA+PiAgICAgICAgICAqIEhpZ2ggJiBsb3cgcmVnaXN0ZXIgZmllbGRzIGFyZW4n dCBzeW5jaHJvbml6ZWQsIHNvIG1ha2Ugc3VyZQo+ID4+IEBAIC03NzIsOCArNzY5LDYgQEAgc3Rh dGljIHUzMiBpOTE1X2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1 bnNpZ25lZCBpbnQgcGlwZSkKPiA+PiAgICAgICAgICAgICAgICAgaGlnaDIgPSBJOTE1X1JFQURf RlcoaGlnaF9mcmFtZSkgJiBQSVBFX0ZSQU1FX0hJR0hfTUFTSzsKPiA+PiAgICAgICAgIH0gd2hp bGUgKGhpZ2gxICE9IGhpZ2gyKTsKPiA+PiAgCj4gPj4gLSAgICAgICBzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiA+PiAtCj4gPj4gICAg ICAgICBoaWdoMSA+Pj0gUElQRV9GUkFNRV9ISUdIX1NISUZUOwo+ID4+ICAgICAgICAgcGl4ZWwg PSBsb3cgJiBQSVBFX1BJWEVMX01BU0s7Cj4gPj4gICAgICAgICBsb3cgPj49IFBJUEVfRlJBTUVf TE9XX1NISUZUOwo+ID4+IEBAIC03ODYsMTEgKzc4MSw2MCBAQCBzdGF0aWMgdTMyIGk5MTVfZ2V0 X3ZibGFua19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBl KQo+ID4+ICAgICAgICAgcmV0dXJuICgoKGhpZ2gxIDw8IDgpIHwgbG93KSArIChwaXhlbCA+PSB2 Ymxfc3RhcnQpKSAmIDB4ZmZmZmZmOwo+ID4+ICB9Cj4gPj4gIAo+ID4+ICtzdGF0aWMgdTMyIGk5 MTVfZ2V0X3ZibGFua19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGlu dCBwaXBlKQo+ID4+ICt7Cj4gPj4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gPj4gKyAgICAgICB1bnNpZ25lZCBsb25nIGlycWZsYWdz Owo+ID4+ICsgICAgICAgdTMyIHJldDsKPiA+PiArCj4gPj4gKyAgICAgICBzcGluX2xvY2tfaXJx c2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gPj4gKyAgICAgICByZXQg PSBpOTE1X2dldF92YmxhbmtfY291bnRlcihkZXYsIHBpcGUpOwo+ID4+ICsgICAgICAgc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gPj4g Kwo+ID4+ICsgICAgICAgcmV0dXJuIHJldDsKPiA+PiArfQo+ID4+ICsKPiA+PiArc3RhdGljIHUz MiBfX2c0eF9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gPj4g K3sKPiA+PiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ID4gbG9ja2RlcF9hc3NlcnRfaGVsZCgmZGV2X3ByaXYtPnVu Y29yZS5sb2NrKTsgPwo+ID4KPiA+IE9rLCB3aHkgZG8gd2UgbmVlZCB1bmNvcmUubG9jayBoZWxk IGhlcmUgYXQgYWxsPyBTZXJpYWxpc2F0aW9uIG9mIG1taW8KPiA+IGFjY2VzcyB0byB0aGUgc2Ft ZSBjYWNoZWxpbmUgaXMgdGhlIGFnZSBvbGQgcmVhc29uLCBjYW4gd2UgZ3VhcmFudGVlCj4gPiB0 aGF0IGRvZXNuJ3QgaGFwcGVuIGFueXdheT8gKFByb2JhYmx5IG5vdCwgYnV0IHJlYWxseSBtb3N0 IGNhbGxlcnMgZG8KPiA+IG5vdCBuZWVkIHRoZSBtbWlvIHcvYS4pCj4gCj4gSXMgdGhlIHNlcmlh bGl6YXRpb24gb25seSBuZWVkZWQgZm9yIHdyaXRpbmc/CgpObywgc2FkbHkgbm90LiBDb25jdXJy ZW50IGFjY2VzcyBvZiBhbnkgdHlwZSB0byB0aGUgc2FtZSBjYWNoZWxpbmUgaXMKdGhlIHRyaWdn ZXIuIChTdXBwb3NlZCB0byBiZSBpdmItb25seS4pCiAKPiBUaGUgb25seSB0aGluZyB0aGF0IGNh biByYWNlIHdpdGggbm9uYmxvY2tpbmcgYXRvbWljIGNvbW1pdHMgYXJlIGxlZ2FjeQo+IGN1cnNv ciB1cGRhdGVzLCBidXQgdGhvc2UgY2FuIG9ubHkgaGFwcGVuIGlmIHRoZSBjdXJzb3IgcGxhbmUg YXJlIG5vdCBwYXJ0Cj4gb2YgdGhlIHByZXZpb3VzIGF0b21pYyBjb21taXQuIFRob3NlIGFyZSBh bHNvIHByb3RlY3RlZCBieSBwbGFuZS0+bXV0ZXgsCj4gc28gaW4gdGhlb3J5IHNhbWUgY2FjaGUg bGluZXMgb24gdGhlIHNhbWUgcGlwZXMgcHJvYmFibHkgY2FuJ3QgcmFjZS4uCgpBdCB3b3JzdCwg d2UgY291bGQganVzdCB1c2UgYSB2YmxhbmstPnNwaW5sb2NrPwotQ2hyaXMKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==