* [PATCH] mmc: sdhci-iproc: Disable preset values for BCM2835
@ 2018-02-12 20:02 ` Stefan Wahren
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2018-02-12 20:02 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson
Cc: Eric Anholt, Ray Jui, Scott Branden, Jon Mason, linux-arm-kernel,
bcm-kernel-feedback-list, linux-mmc, Stefan Wahren
According to the BCM2835 datasheet there are no preset value registers.
This wasn't an issue before, because we didn't propagate 1.8V support.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/mmc/host/sdhci-iproc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 61666d2..0ef741b 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -214,6 +214,7 @@ static const struct sdhci_pltfm_data sdhci_bcm2835_pltfm_data = {
SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
SDHCI_QUIRK_MISSING_CAPS |
SDHCI_QUIRK_NO_HISPD_BIT,
+ .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
.ops = &sdhci_iproc_32only_ops,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mmc: sdhci-iproc: Disable preset values for BCM2835
@ 2018-02-12 20:02 ` Stefan Wahren
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2018-02-12 20:02 UTC (permalink / raw)
To: linux-arm-kernel
According to the BCM2835 datasheet there are no preset value registers.
This wasn't an issue before, because we didn't propagate 1.8V support.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/mmc/host/sdhci-iproc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 61666d2..0ef741b 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -214,6 +214,7 @@ static const struct sdhci_pltfm_data sdhci_bcm2835_pltfm_data = {
SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
SDHCI_QUIRK_MISSING_CAPS |
SDHCI_QUIRK_NO_HISPD_BIT,
+ .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
.ops = &sdhci_iproc_32only_ops,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci-iproc: Disable preset values for BCM2835
2018-02-12 20:02 ` Stefan Wahren
@ 2018-02-14 10:38 ` Ulf Hansson
-1 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2018-02-14 10:38 UTC (permalink / raw)
To: Stefan Wahren
Cc: Adrian Hunter, Eric Anholt, Ray Jui, Scott Branden, Jon Mason,
linux-arm-kernel, BCM Kernel Feedback, linux-mmc
On 12 February 2018 at 21:02, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> According to the BCM2835 datasheet there are no preset value registers.
> This wasn't an issue before, because we didn't propagate 1.8V support.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 61666d2..0ef741b 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -214,6 +214,7 @@ static const struct sdhci_pltfm_data sdhci_bcm2835_pltfm_data = {
> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
> SDHCI_QUIRK_MISSING_CAPS |
> SDHCI_QUIRK_NO_HISPD_BIT,
> + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
> .ops = &sdhci_iproc_32only_ops,
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mmc: sdhci-iproc: Disable preset values for BCM2835
@ 2018-02-14 10:38 ` Ulf Hansson
0 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2018-02-14 10:38 UTC (permalink / raw)
To: linux-arm-kernel
On 12 February 2018 at 21:02, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> According to the BCM2835 datasheet there are no preset value registers.
> This wasn't an issue before, because we didn't propagate 1.8V support.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 61666d2..0ef741b 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -214,6 +214,7 @@ static const struct sdhci_pltfm_data sdhci_bcm2835_pltfm_data = {
> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
> SDHCI_QUIRK_MISSING_CAPS |
> SDHCI_QUIRK_NO_HISPD_BIT,
> + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
> .ops = &sdhci_iproc_32only_ops,
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-14 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-12 20:02 [PATCH] mmc: sdhci-iproc: Disable preset values for BCM2835 Stefan Wahren
2018-02-12 20:02 ` Stefan Wahren
2018-02-14 10:38 ` Ulf Hansson
2018-02-14 10:38 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.