From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net ([212.227.15.19]:44061 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbeBMFDA (ORCPT ); Tue, 13 Feb 2018 00:03:00 -0500 Message-ID: <1518498175.6944.48.camel@gmx.de> Subject: Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook From: Mike Galbraith To: Oleksandr Natalenko Cc: Paolo Valente , Jens Axboe , stable Date: Tue, 13 Feb 2018 06:02:55 +0100 In-Reply-To: <805e9d5af9aed3fbc2697fdb0ce51e88@natalenko.name> References: <20180207211920.6343-1-paolo.valente@linaro.org> <1518197379.26824.31.camel@gmx.de> <6394471.U0O273vb9H@natalenko.name> <9E24F648-C93A-4CEA-A1B6-B041540CEAAE@linaro.org> <1518434553.13087.7.camel@gmx.de> <805e9d5af9aed3fbc2697fdb0ce51e88@natalenko.name> Content-Type: text/plain; charset="ISO-8859-15" Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Mon, 2018-02-12 at 13:48 +0100, Oleksandr Natalenko wrote: > Hi. > > 12.02.2018 12:22, Mike Galbraith wrote: > > How does that work without someone actually submitting patches? �CC > > stable and pass along a conveniently sorted cherry-pick list? > > From my experience, Greg is fine with the list of hashes, but he needs > an approval from the relevant subtree maintainer (Jens in this case). Oh dear. �I'm a bit reluctant to even mention this, buuut, when creating that hash list, I extracted/applied them to 4.15.3 via quilt to make sure that they really do slip right in.. and later, while building two fat enterprise config kernels concurrently, trees living in separate spinning rust buckets, box IO stalled on me. �Not good. �Hard reboot, clean up and try it again, it reproduced. �Switch to master, that reproduced. �Extra not good. I found that rather odd, because I had earlier done this to 4.15.. patches/block-bfq:-fix-occurrences-of-request-finish-method-s-old-name.patch patches/block-bfq:-add-requeue-request-hook.patch ..ie take only the rename, wedge the fix in on top of it, beat on box, it worked fine. �This morning, I go back to only those two, and box is again (at least pretending to be) perfectly happy to build the same trees it hung on twice in a row yesterday, it _seems_ to be completely uninterested in stalling no matter what I do. So, something not so funny is still going on, here at least. �Test results imply that something in that hash list _may_ not be all that desirable a thing to send to stable, but who knows, some playful gremlin may well be pulling my chain, will let box stall on me again a few seconds after I write that, and poke send :) Ok IO gremlin, go for it... -Mike