All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jianfeng Tan <jianfeng.tan@intel.com>
To: dev@dpdk.org
Cc: Jianfeng Tan <jianfeng.tan@intel.com>,
	maxime.coquelin@redhat.com, yliu@fridaylinux.org
Subject: [PATCH 2/4] vhost: avoid function call in data path
Date: Wed, 14 Feb 2018 04:01:30 +0000	[thread overview]
Message-ID: <1518580892-32656-3-git-send-email-jianfeng.tan@intel.com> (raw)
In-Reply-To: <1518580892-32656-1-git-send-email-jianfeng.tan@intel.com>

Previously, get_device() is a function call. It's OK for slow path
configuration, but takes some cycles for data path.

To avoid that, we turn this function to inline type.

Cc: maxime.coquelin@redhat.com
Cc: yliu@fridaylinux.org

Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 lib/librte_vhost/vhost.c | 13 -------------
 lib/librte_vhost/vhost.h | 13 ++++++++++++-
 2 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
index a407067..f6f12a0 100644
--- a/lib/librte_vhost/vhost.c
+++ b/lib/librte_vhost/vhost.c
@@ -68,19 +68,6 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,
 	return 0;
 }
 
-struct virtio_net *
-get_device(int vid)
-{
-	struct virtio_net *dev = vhost_devices[vid];
-
-	if (unlikely(!dev)) {
-		RTE_LOG(ERR, VHOST_CONFIG,
-			"(%d) device not found.\n", vid);
-	}
-
-	return dev;
-}
-
 void
 cleanup_vq(struct vhost_virtqueue *vq, int destroy)
 {
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index ecd5b7b..3fce13b 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -343,7 +343,18 @@ gpa_to_hpa(struct virtio_net *dev, uint64_t gpa, uint64_t size)
 	return 0;
 }
 
-struct virtio_net *get_device(int vid);
+static __rte_always_inline struct virtio_net *
+get_device(int vid)
+{
+	struct virtio_net *dev = vhost_devices[vid];
+
+	if (unlikely(!dev)) {
+		RTE_LOG(ERR, VHOST_CONFIG,
+			"(%d) device not found.\n", vid);
+	}
+
+	return dev;
+}
 
 int vhost_new_device(void);
 void cleanup_device(struct virtio_net *dev, int destroy);
-- 
2.7.4

  parent reply	other threads:[~2018-02-14  3:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14  4:01 [PATCH 0/4] some fixes target for 18.05 Jianfeng Tan
2018-02-14  4:01 ` [PATCH 1/4] vhost: remove unused macro Jianfeng Tan
2018-02-19 20:49   ` Maxime Coquelin
2018-02-21  7:32     ` Maxime Coquelin
2018-02-14  4:01 ` Jianfeng Tan [this message]
2018-02-19 20:48   ` [PATCH 2/4] vhost: avoid function call in data path Maxime Coquelin
2018-02-21  7:32     ` Maxime Coquelin
2018-02-14  4:01 ` [PATCH 3/4] app/testpmd: add option to avoid lock all memory Jianfeng Tan
2018-02-14  6:40   ` Wu, Jingjing
2018-02-24  3:26   ` [PATCH v2] " Jianfeng Tan
2018-04-22 23:05     ` Thomas Monjalon
2018-05-03 11:32       ` Burakov, Anatoly
2018-02-14  4:01 ` [PATCH 4/4] vhost: avoid populate guest memory Jianfeng Tan
2018-02-19 20:44   ` Maxime Coquelin
2018-02-22  2:42     ` Tan, Jianfeng
2018-02-22  8:25       ` Maxime Coquelin
2018-02-22  8:40         ` Tan, Jianfeng
2018-02-22 12:32           ` Maxime Coquelin
2018-02-23  3:17             ` Tan, Jianfeng
2018-03-28  6:56     ` [PATCH v2] " Jianfeng Tan
2018-03-30  8:21       ` Maxime Coquelin
2018-03-30  8:34         ` Maxime Coquelin
2018-02-21  7:35 ` [PATCH 0/4] some fixes target for 18.05 Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518580892-32656-3-git-send-email-jianfeng.tan@intel.com \
    --to=jianfeng.tan@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.