All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>,
	Linux USB <linux-usb@vger.kernel.org>
Subject: usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro
Date: Thu, 15 Feb 2018 15:00:40 +0200	[thread overview]
Message-ID: <1518699640.22495.352.camel@linux.intel.com> (raw)

On Thu, 2018-02-15 at 13:16 +0200, Felipe Balbi wrote:
> ...instead of open coding file operations followed by custom ->open()
> callbacks per each attribute.
> 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Though one comment below.

> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

>  static void dwc3_debugfs_create_endpoint_file(struct dwc3_ep *dep,
> +		struct dentry *parent, const char *const name,
> +		const struct file_operations *const fops)
>  {
> +	(void) debugfs_create_file(name, S_IRUGO, parent, dep, fops);
>  }

At this point why do you need one line function anymore?

> +		dwc3_debugfs_create_endpoint_file(dep, parent,
> +				name, fops);

             reply	other threads:[~2018-02-15 13:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 13:00 Andy Shevchenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-02-20 18:12 usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro Andy Shevchenko
2018-02-15 13:12 Felipe Balbi
2018-02-15 11:16 Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518699640.22495.352.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.