All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH resend 0/1] thermal: int3400_thermal: Ignore charger events
@ 2018-02-14 15:13 Hans de Goede
  2018-02-14 15:13 ` [PATCH resend] " Hans de Goede
  2018-02-17  5:58 ` [PATCH resend 0/1] " Zhang Rui
  0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2018-02-14 15:13 UTC (permalink / raw)
  To: Zhang Rui, Eduardo Valentin; +Cc: Hans de Goede, linux-pm

Hi All,

This patch seems to have fallen through the cracks, hence this resend.

Regards,

Hans

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH resend] thermal: int3400_thermal: Ignore charger events
  2018-02-14 15:13 [PATCH resend 0/1] thermal: int3400_thermal: Ignore charger events Hans de Goede
@ 2018-02-14 15:13 ` Hans de Goede
  2018-02-17  5:58 ` [PATCH resend 0/1] " Zhang Rui
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2018-02-14 15:13 UTC (permalink / raw)
  To: Zhang Rui, Eduardo Valentin; +Cc: Hans de Goede, linux-pm

Ignore events of type 0x86 which are fired of when plugging in / out the
charger, judging from both observed behavior and the AML code on an Asus
T100HA.

This silences these kernel errors on the T100HA:
[   86.599918] acpi INT3400:00: Unsupported event [0x86]
[  120.133024] acpi INT3400:00: Unsupported event [0x86]

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/thermal/int340x_thermal/int3400_thermal.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c b/drivers/thermal/int340x_thermal/int3400_thermal.c
index e26b01c05e82..3c37528f2319 100644
--- a/drivers/thermal/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/int340x_thermal/int3400_thermal.c
@@ -17,6 +17,7 @@
 #include "acpi_thermal_rel.h"
 
 #define INT3400_THERMAL_TABLE_CHANGED 0x83
+#define INT3400_CHARGER_EVENT         0x86
 
 enum int3400_thermal_uuid {
 	INT3400_THERMAL_PASSIVE_1,
@@ -210,6 +211,8 @@ static void int3400_notify(acpi_handle handle,
 		kobject_uevent_env(&priv->thermal->device.kobj, KOBJ_CHANGE,
 				thermal_prop);
 		break;
+	case INT3400_CHARGER_EVENT:
+		break;
 	default:
 		/* Ignore unknown notification codes sent to INT3400 device */
 		break;
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH resend 0/1] thermal: int3400_thermal: Ignore charger events
  2018-02-14 15:13 [PATCH resend 0/1] thermal: int3400_thermal: Ignore charger events Hans de Goede
  2018-02-14 15:13 ` [PATCH resend] " Hans de Goede
@ 2018-02-17  5:58 ` Zhang Rui
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang Rui @ 2018-02-17  5:58 UTC (permalink / raw)
  To: Hans de Goede, Eduardo Valentin; +Cc: linux-pm

On Wed, 2018-02-14 at 16:13 +0100, Hans de Goede wrote:
> Hi All,
> 
> This patch seems to have fallen through the cracks, hence this
> resend.
> 
I think the problem can be covered by this commit, right?

commit 261ac1d2d9ef9a29c57f8aff341ae3dc323a707c
Author:     Brian Bian <brian.bian@linux.intel.com>
AuthorDate: Tue Nov 14 09:36:36 2017 -0800
Commit:     Zhang Rui <rui.zhang@intel.com>
CommitDate: Wed Dec 27 10:14:58 2017 +0800

    thermal: int3400_thermal: Ignore Unknown Notification Codes
    
    Some BIOS implementations route ACPI codes other than 0x83 to
INT3400
    device. Ignore these ACPI notification codes because the INT3400
driver
    does not handle them.
    
    Signed-off-by: Brian Bian <brian.bian@linux.intel.com>
    Signed-off-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-02-17  5:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 15:13 [PATCH resend 0/1] thermal: int3400_thermal: Ignore charger events Hans de Goede
2018-02-14 15:13 ` [PATCH resend] " Hans de Goede
2018-02-17  5:58 ` [PATCH resend 0/1] " Zhang Rui

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.