* [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
@ 2018-02-17 15:41 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-02-17 15:41 UTC (permalink / raw)
To: shawnguo; +Cc: devicetree, robh+dt, kernel, Fabio Estevam, linux-arm-kernel, LW
From: Fabio Estevam <fabio.estevam@nxp.com>
Pass the memory unit name in order to fix the following
dtc warning with W=1:
arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Hi,
Currently the only dtc warnings observed with W=1 are the ones:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
If this solution can be accepted I can clean all the other i.MX dts files.
Please advise.
arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 8a4f5bc..bbdf004 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -65,8 +65,8 @@
usbotg = &usb0;
};
- memory {
- reg = <0 0>; /* will be filled in by U-Boot */
+ memory@40000000 {
+ reg = <0x40000000 0>; /* will be filled in by U-Boot */
};
onewire {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
@ 2018-02-17 15:41 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-02-17 15:41 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Pass the memory unit name in order to fix the following
dtc warning with W=1:
arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Hi,
Currently the only dtc warnings observed with W=1 are the ones:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
If this solution can be accepted I can clean all the other i.MX dts files.
Please advise.
arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 8a4f5bc..bbdf004 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -65,8 +65,8 @@
usbotg = &usb0;
};
- memory {
- reg = <0 0>; /* will be filled in by U-Boot */
+ memory at 40000000 {
+ reg = <0x40000000 0>; /* will be filled in by U-Boot */
};
onewire {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
2018-02-17 15:41 ` Fabio Estevam
@ 2018-02-19 12:06 ` Lothar Waßmann
-1 siblings, 0 replies; 6+ messages in thread
From: Lothar Waßmann @ 2018-02-19 12:06 UTC (permalink / raw)
To: Fabio Estevam
Cc: devicetree, robh+dt, kernel, Fabio Estevam, shawnguo, linux-arm-kernel
Hi,
On Sat, 17 Feb 2018 13:41:43 -0200 Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi,
>
> Currently the only dtc warnings observed with W=1 are the ones:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> If this solution can be accepted I can clean all the other i.MX dts files.
>
> Please advise.
>
> arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 8a4f5bc..bbdf004 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -65,8 +65,8 @@
> usbotg = &usb0;
> };
>
> - memory {
> - reg = <0 0>; /* will be filled in by U-Boot */
> + memory@40000000 {
> + reg = <0x40000000 0>; /* will be filled in by U-Boot */
> };
>
> onewire {
>
I have no objections to this change. U-Boot still finds the memory node
and puts the correct size into the 'reg' property.
Acked-by: Lothar Waßmann <LW@KARO-electronics.de>
Lothar Waßmann
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
@ 2018-02-19 12:06 ` Lothar Waßmann
0 siblings, 0 replies; 6+ messages in thread
From: Lothar Waßmann @ 2018-02-19 12:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Sat, 17 Feb 2018 13:41:43 -0200 Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi,
>
> Currently the only dtc warnings observed with W=1 are the ones:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> If this solution can be accepted I can clean all the other i.MX dts files.
>
> Please advise.
>
> arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 8a4f5bc..bbdf004 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -65,8 +65,8 @@
> usbotg = &usb0;
> };
>
> - memory {
> - reg = <0 0>; /* will be filled in by U-Boot */
> + memory at 40000000 {
> + reg = <0x40000000 0>; /* will be filled in by U-Boot */
> };
>
> onewire {
>
I have no objections to this change. U-Boot still finds the memory node
and puts the correct size into the 'reg' property.
Acked-by: Lothar Wa?mann <LW@KARO-electronics.de>
Lothar Wa?mann
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
2018-02-17 15:41 ` Fabio Estevam
@ 2018-02-24 8:29 ` Shawn Guo
-1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-02-24 8:29 UTC (permalink / raw)
To: Fabio Estevam
Cc: devicetree, robh+dt, kernel, Fabio Estevam, linux-arm-kernel, LW
On Sat, Feb 17, 2018 at 01:41:43PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
@ 2018-02-24 8:29 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-02-24 8:29 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Feb 17, 2018 at 01:41:43PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-24 8:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-17 15:41 [RFC] ARM: dts: imx28-tx28: Pass the memory unit name Fabio Estevam
2018-02-17 15:41 ` Fabio Estevam
2018-02-19 12:06 ` Lothar Waßmann
2018-02-19 12:06 ` Lothar Waßmann
2018-02-24 8:29 ` Shawn Guo
2018-02-24 8:29 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.