Re: [V3] drm/i915: Enable VBT based BL control for DP

[Chris Wilson <chris@chris-wilson.co.uk>]

Quoting Mustamin B Mustaffa (2018-02-20 06:52:49)
> Currently, BXT_PP is hardcoded with value '0'.
> It practically disabled eDP backlight on MRB (BXT) platform.
> 
> This patch will tell which BXT_PP registers (there are two set of
> PP_CONTROL in the spec) to be used as defined in VBT (Video Bios Timing
> table) and this will enabled eDP backlight controller on MRB (BXT)
> platform.
> 
> v2:
>  - Remove unnecessary information in commit message.
>  - Assign vbt.backlight.controller to a backlight_controller variable and
>    return the variable value.
> v3:
>  - Rebased to latest code base.
>  - updated commit title.
> 
> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 1868f73..f9b922d 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -655,18 +655,15 @@ static enum pipe vlv_find_free_pps(struct drm_i915_private *dev_priv)
>  {
>         struct drm_i915_private *dev_priv = to_i915(intel_dp_to_dev(intel_dp));
>  

Ah, a purveyor of newlines.

> +       int backlight_controller = dev_priv->vbt.backlight.controller;

Isn't the vbt->backlight.controller sanitized to the
panel->backlight.controller at this point?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx