From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Add enum aux_ch and clean up the aux init to use it
Date: Tue, 20 Feb 2018 17:47:03 +0000 [thread overview]
Message-ID: <151914882328.4312.9873031664892366622@mail.alporthouse.com> (raw)
In-Reply-To: <20180220170524.12303-1-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2018-02-20 17:05:22)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Since we no longer have a 1:1 correspondence between ports and AUX
> channels, let's give AUX channels their own enum. Makes it easier
> to tell the apples from the oranges, and we get rid of the
> port E AUX power domain FIXME since we now derive the power domain
> from the actual AUX CH.
>
> v2: Rebase due to AUX F
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
The translation looks fine; nothing stood out and utterly confused me.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Should definitely seek a second opinion on the new enum vs abusing port.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-20 17:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 17:05 [PATCH 1/3] drm/i915: Add enum aux_ch and clean up the aux init to use it Ville Syrjala
2018-02-20 17:05 ` [PATCH 2/3] drm/i915: Nuke aux regs from intel_dp Ville Syrjala
2018-02-20 17:30 ` Chris Wilson
2018-02-20 17:49 ` Ville Syrjälä
2018-02-20 17:57 ` Chris Wilson
2018-02-20 19:00 ` [PATCH v2 " Ville Syrjala
2018-02-22 7:16 ` Pandiyan, Dhinakaran
2018-02-22 12:43 ` Ville Syrjälä
2018-02-22 20:38 ` Pandiyan, Dhinakaran
2018-02-20 17:05 ` [PATCH 3/3] drm/i915: Collect aux ch vfunc setup into intel_dp_aux_init() Ville Syrjala
2018-02-20 17:25 ` Chris Wilson
2018-02-20 19:35 ` Rodrigo Vivi
2018-02-20 17:28 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Add enum aux_ch and clean up the aux init to use it Patchwork
2018-02-20 17:43 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-20 17:47 ` Chris Wilson [this message]
2018-02-20 19:31 ` [PATCH 1/3] " Rodrigo Vivi
2018-02-22 7:25 ` Pandiyan, Dhinakaran
2018-02-22 12:48 ` Ville Syrjälä
2018-02-22 16:29 ` Ville Syrjälä
2018-02-22 6:12 ` Pandiyan, Dhinakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151914882328.4312.9873031664892366622@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.