From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH 1/3] drm/i915: Add enum aux_ch and clean up the aux init to use it Date: Thu, 22 Feb 2018 07:25:22 +0000 Message-ID: <1519285729.2358.13.camel@dk-H97M-D3H> References: <20180220170524.12303-1-ville.syrjala@linux.intel.com> <20180220193109.GE27433@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5532D6EC05 for ; Thu, 22 Feb 2018 07:25:24 +0000 (UTC) In-Reply-To: <20180220193109.GE27433@intel.com> Content-Language: en-US Content-ID: <12833C124C76324A8E92E40465E11E4B@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org DQoNCg0KT24gVHVlLCAyMDE4LTAyLTIwIGF0IDExOjMxIC0wODAwLCBSb2RyaWdvIFZpdmkgd3Jv dGU6DQo+IE9uIFR1ZSwgRmViIDIwLCAyMDE4IGF0IDA3OjA1OjIyUE0gKzAyMDAsIFZpbGxlIFN5 cmphbGEgd3JvdGU6DQo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4NCj4gPiANCj4gPiBTaW5jZSB3ZSBubyBsb25nZXIgaGF2ZSBhIDE6MSBj b3JyZXNwb25kZW5jZSBiZXR3ZWVuIHBvcnRzIGFuZCBBVVgNCj4gPiBjaGFubmVscywgbGV0J3Mg Z2l2ZSBBVVggY2hhbm5lbHMgdGhlaXIgb3duIGVudW0uIE1ha2VzIGl0IGVhc2llcg0KPiA+IHRv IHRlbGwgdGhlIGFwcGxlcyBmcm9tIHRoZSBvcmFuZ2VzLCBhbmQgd2UgZ2V0IHJpZCBvZiB0aGUN Cj4gPiBwb3J0IEUgQVVYIHBvd2VyIGRvbWFpbiBGSVhNRSBzaW5jZSB3ZSBub3cgZGVyaXZlIHRo ZSBwb3dlciBkb21haW4NCj4gPiBmcm9tIHRoZSBhY3R1YWwgQVVYIENILg0KPiANCj4gDQo+IEJl YXV0aWZ1bCBjbGVhbi11cC4gSSBoYWQgdGhpcyBpbiBhIHRvZG8gbGlzdCB5ZWFycyBhZ28gYW5k DQo+IGFmdGVyIHN0YXlpbmcgb24gdGhlIGJvdHRvbSBmb3Igc28gbG9uZyBJIGhhZCByZW1vdmVk IGl0IGZyb20gdGhlcmUuLi4NCj4gPiANCj4gPiB2MjogUmViYXNlIGR1ZSB0byBBVVggRg0KPiAN Cj4gc29ycnkgYW5kIHRoYW5rcyEgOikNCj4gDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4NCj4gDQo+IEkgd29u ZGVyZWQgaWYgYXQgbGVhc3QgYXV4X3Bvd2VyX2RvbWFpbiBwYXJ0IGNvdWxkIGJlIGluIGENCj4g c2VwYXJhdGVkIHBhdGNoIGJlY2F1c2UgYnkgdGhlIGVuZCBJIHdhcyBhIGJpdCBjb25mdXNlZC4u Lg0KPiBCdXQgaW4gdGhlIGVuZCBJIGNvdWxkIHB1dCBhbGwgcGllY2VzIHRvZ2V0aGVyIGFuZCBp dCBtYWRlIHNlbnNlDQo+IGFnYWluLiBTbyBvbmUgcGF0Y2ggZm9yIGVhc3kgYmFjayBwb3J0aW5n IHNlZW1zIGJldHRlci4NCj4gDQo+IFJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28u dml2aUBpbnRlbC5jb20+DQo+IA0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oICAgICAgfCAgIDggKy0NCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5oIHwgIDExICsrDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMg ICAgICB8IDI0MCArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgIDEgKw0KPiA+ICA0IGZpbGVzIGNo YW5nZWQsIDEzMSBpbnNlcnRpb25zKCspLCAxMjkgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3JlZy5oDQo+ID4gaW5kZXggMTQxMmFiY2IyN2Q0Li4zOWQ2MjQwODNhMTcg MTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaA0KPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgNCj4gPiBAQCAtNTM0Nyw4ICs1MzQ3 LDggQEAgZW51bSB7DQo+ID4gICNkZWZpbmUgX0RQRl9BVVhfQ0hfREFUQTQJKGRldl9wcml2LT5p bmZvLmRpc3BsYXlfbW1pb19vZmZzZXQgKyAweDY0NTIwKQ0KPiA+ICAjZGVmaW5lIF9EUEZfQVVY X0NIX0RBVEE1CShkZXZfcHJpdi0+aW5mby5kaXNwbGF5X21taW9fb2Zmc2V0ICsgMHg2NDUyNCkN Cj4gPiAgDQo+ID4gLSNkZWZpbmUgRFBfQVVYX0NIX0NUTChwb3J0KQlfTU1JT19QT1JUKHBvcnQs IF9EUEFfQVVYX0NIX0NUTCwgX0RQQl9BVVhfQ0hfQ1RMKQ0KPiA+IC0jZGVmaW5lIERQX0FVWF9D SF9EQVRBKHBvcnQsIGkpCV9NTUlPKF9QT1JUKHBvcnQsIF9EUEFfQVVYX0NIX0RBVEExLCBfRFBC X0FVWF9DSF9EQVRBMSkgKyAoaSkgKiA0KSAvKiA1IHJlZ2lzdGVycyAqLw0KPiA+ICsjZGVmaW5l IERQX0FVWF9DSF9DVEwoYXV4X2NoKQlfTU1JT19QT1JUKGF1eF9jaCwgX0RQQV9BVVhfQ0hfQ1RM LCBfRFBCX0FVWF9DSF9DVEwpDQo+ID4gKyNkZWZpbmUgRFBfQVVYX0NIX0RBVEEoYXV4X2NoLCBp KQlfTU1JTyhfUE9SVChhdXhfY2gsIF9EUEFfQVVYX0NIX0RBVEExLCBfRFBCX0FVWF9DSF9EQVRB MSkgKyAoaSkgKiA0KSAvKiA1IHJlZ2lzdGVycyAqLw0KPiA+ICANCj4gPiAgI2RlZmluZSAgIERQ X0FVWF9DSF9DVExfU0VORF9CVVNZCSAgICAoMSA8PCAzMSkNCj4gPiAgI2RlZmluZSAgIERQX0FV WF9DSF9DVExfRE9ORQkJICAgICgxIDw8IDMwKQ0KPiA+IEBAIC03ODc1LDggKzc4NzUsOCBAQCBl bnVtIHsNCj4gPiAgI2RlZmluZSBfUENIX0RQRF9BVVhfQ0hfREFUQTQJMHhlNDMyMA0KPiA+ICAj ZGVmaW5lIF9QQ0hfRFBEX0FVWF9DSF9EQVRBNQkweGU0MzI0DQo+ID4gIA0KPiA+IC0jZGVmaW5l IFBDSF9EUF9BVVhfQ0hfQ1RMKHBvcnQpCQlfTU1JT19QT1JUKChwb3J0KSAtIFBPUlRfQiwgX1BD SF9EUEJfQVVYX0NIX0NUTCwgX1BDSF9EUENfQVVYX0NIX0NUTCkNCj4gPiAtI2RlZmluZSBQQ0hf RFBfQVVYX0NIX0RBVEEocG9ydCwgaSkJX01NSU8oX1BPUlQoKHBvcnQpIC0gUE9SVF9CLCBfUENI X0RQQl9BVVhfQ0hfREFUQTEsIF9QQ0hfRFBDX0FVWF9DSF9EQVRBMSkgKyAoaSkgKiA0KSAvKiA1 IHJlZ2lzdGVycyAqLw0KPiA+ICsjZGVmaW5lIFBDSF9EUF9BVVhfQ0hfQ1RMKGF1eF9jaCkJCV9N TUlPX1BPUlQoKGF1eF9jaCkgLSBBVVhfQ0hfQiwgX1BDSF9EUEJfQVVYX0NIX0NUTCwgX1BDSF9E UENfQVVYX0NIX0NUTCkNCj4gPiArI2RlZmluZSBQQ0hfRFBfQVVYX0NIX0RBVEEoYXV4X2NoLCBp KQlfTU1JTyhfUE9SVCgoYXV4X2NoKSAtIEFVWF9DSF9CLCBfUENIX0RQQl9BVVhfQ0hfREFUQTEs IF9QQ0hfRFBDX0FVWF9DSF9EQVRBMSkgKyAoaSkgKiA0KSAvKiA1IHJlZ2lzdGVycyAqLw0KPiA+ ICANCj4gPiAgLyogQ1BUICovDQo+ID4gICNkZWZpbmUgIFBPUlRfVFJBTlNfQV9TRUxfQ1BUCTAN Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5oIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5oDQo+ID4gaW5kZXggYzQwNDJlMzQy ZjUwLi5mNTczM2EyNTc2ZTcgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5oDQo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5oDQo+ID4gQEAgLTEzOSw2ICsxMzksMTcgQEAgZW51bSBkcGlvX3BoeSB7DQo+ID4gIA0K PiA+ICAjZGVmaW5lIEk5MTVfTlVNX1BIWVNfVkxWIDINCj4gPiAgDQo+ID4gK2VudW0gYXV4X2No IHsNCj4gPiArCUFVWF9DSF9BLA0KPiA+ICsJQVVYX0NIX0IsDQo+ID4gKwlBVVhfQ0hfQywNCj4g PiArCUFVWF9DSF9ELA0KPiA+ICsJX0FVWF9DSF9FLCAvKiBkb2VzIG5vdCBleGlzdCAqLw0KPiA+ ICsJQVVYX0NIX0YsDQo+ID4gK307DQo+ID4gKw0KPiA+ICsjZGVmaW5lIGF1eF9jaF9uYW1lKGEp ICgoYSkgKyAnQScpDQo+ID4gKw0KPiA+ICBlbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWlu IHsNCj4gPiAgCVBPV0VSX0RPTUFJTl9QSVBFX0EsDQo+ID4gIAlQT1dFUl9ET01BSU5fUElQRV9C LA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiA+IGluZGV4IGYyMGIyNWY5OGU1YS4uZWVi OGEwMjZmZDA4IDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMNCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4gQEAgLTEz MzEsMTcxICsxMzMxLDE5NCBAQCBpbnRlbF9kcF9hdXhfdHJhbnNmZXIoc3RydWN0IGRybV9kcF9h dXggKmF1eCwgc3RydWN0IGRybV9kcF9hdXhfbXNnICptc2cpDQo+ID4gIAlyZXR1cm4gcmV0Ow0K PiA+ICB9DQo+ID4gIA0KPiA+IC1zdGF0aWMgZW51bSBwb3J0IGludGVsX2F1eF9wb3J0KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwNCj4gPiAtCQkJCWVudW0gcG9ydCBwb3J0KQ0K PiA+ICtzdGF0aWMgZW51bSBhdXhfY2ggaW50ZWxfYXV4X2NoKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHApDQo+ID4gIHsNCj4gPiArCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyID0gJmRw X3RvX2RpZ19wb3J0KGludGVsX2RwKS0+YmFzZTsNCj4gPiArCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOw0KPiA+ICsJZW51bSBw b3J0IHBvcnQgPSBlbmNvZGVyLT5wb3J0Ow0KPiA+ICAJY29uc3Qgc3RydWN0IGRkaV92YnRfcG9y dF9pbmZvICppbmZvID0NCj4gPiAgCQkmZGV2X3ByaXYtPnZidC5kZGlfcG9ydF9pbmZvW3BvcnRd Ow0KPiA+IC0JZW51bSBwb3J0IGF1eF9wb3J0Ow0KPiA+ICsJZW51bSBhdXhfY2ggYXV4X2NoOw0K PiA+ICANCj4gPiAgCWlmICghaW5mby0+YWx0ZXJuYXRlX2F1eF9jaGFubmVsKSB7DQo+ID4gKwkJ YXV4X2NoID0gKGVudW0gYXV4X2NoKSBwb3J0Ow0KPiA+ICsNCj4gPiAgCQlEUk1fREVCVUdfS01T KCJ1c2luZyBBVVggJWMgZm9yIHBvcnQgJWMgKHBsYXRmb3JtIGRlZmF1bHQpXG4iLA0KPiA+IC0J CQkgICAgICBwb3J0X25hbWUocG9ydCksIHBvcnRfbmFtZShwb3J0KSk7DQo+ID4gLQkJcmV0dXJu IHBvcnQ7DQo+ID4gKwkJCSAgICAgIGF1eF9jaF9uYW1lKGF1eF9jaCksIHBvcnRfbmFtZShwb3J0 KSk7DQo+ID4gKwkJcmV0dXJuIGF1eF9jaDsNCj4gPiAgCX0NCj4gPiAgDQo+ID4gIAlzd2l0Y2gg KGluZm8tPmFsdGVybmF0ZV9hdXhfY2hhbm5lbCkgew0KPiA+ICAJY2FzZSBEUF9BVVhfQToNCj4g PiAtCQlhdXhfcG9ydCA9IFBPUlRfQTsNCj4gPiArCQlhdXhfY2ggPSBBVVhfQ0hfQTsNCj4gPiAg CQlicmVhazsNCj4gPiAgCWNhc2UgRFBfQVVYX0I6DQo+ID4gLQkJYXV4X3BvcnQgPSBQT1JUX0I7 DQo+ID4gKwkJYXV4X2NoID0gQVVYX0NIX0I7DQo+ID4gIAkJYnJlYWs7DQo+ID4gIAljYXNlIERQ X0FVWF9DOg0KPiA+IC0JCWF1eF9wb3J0ID0gUE9SVF9DOw0KPiA+ICsJCWF1eF9jaCA9IEFVWF9D SF9DOw0KPiA+ICAJCWJyZWFrOw0KPiA+ICAJY2FzZSBEUF9BVVhfRDoNCj4gPiAtCQlhdXhfcG9y dCA9IFBPUlRfRDsNCj4gPiArCQlhdXhfY2ggPSBBVVhfQ0hfRDsNCj4gPiAgCQlicmVhazsNCj4g PiAgCWNhc2UgRFBfQVVYX0Y6DQo+ID4gLQkJYXV4X3BvcnQgPSBQT1JUX0Y7DQo+ID4gKwkJYXV4 X2NoID0gQVVYX0NIX0Y7DQo+ID4gIAkJYnJlYWs7DQo+ID4gIAlkZWZhdWx0Og0KPiA+ICAJCU1J U1NJTkdfQ0FTRShpbmZvLT5hbHRlcm5hdGVfYXV4X2NoYW5uZWwpOw0KPiA+IC0JCWF1eF9wb3J0 ID0gUE9SVF9BOw0KPiA+ICsJCWF1eF9jaCA9IEFVWF9DSF9BOw0KPiA+ICAJCWJyZWFrOw0KPiA+ ICAJfQ0KPiA+ICANCj4gPiAgCURSTV9ERUJVR19LTVMoInVzaW5nIEFVWCAlYyBmb3IgcG9ydCAl YyAoVkJUKVxuIiwNCj4gPiAtCQkgICAgICBwb3J0X25hbWUoYXV4X3BvcnQpLCBwb3J0X25hbWUo cG9ydCkpOw0KPiA+ICsJCSAgICAgIGF1eF9jaF9uYW1lKGF1eF9jaCksIHBvcnRfbmFtZShwb3J0 KSk7DQo+ID4gIA0KPiA+IC0JcmV0dXJuIGF1eF9wb3J0Ow0KPiA+ICsJcmV0dXJuIGF1eF9jaDsN Cj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGVudW0gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21h aW4NCj4gPiAraW50ZWxfYXV4X3Bvd2VyX2RvbWFpbihzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw KQ0KPiA+ICt7DQo+ID4gKwlzd2l0Y2ggKGludGVsX2RwLT5hdXhfY2gpIHsNCj4gPiArCWNhc2Ug QVVYX0NIX0E6DQo+ID4gKwkJcmV0dXJuIFBPV0VSX0RPTUFJTl9BVVhfQTsNCj4gPiArCWNhc2Ug QVVYX0NIX0I6DQo+ID4gKwkJcmV0dXJuIFBPV0VSX0RPTUFJTl9BVVhfQjsNCj4gPiArCWNhc2Ug QVVYX0NIX0M6DQo+ID4gKwkJcmV0dXJuIFBPV0VSX0RPTUFJTl9BVVhfQzsNCj4gPiArCWNhc2Ug QVVYX0NIX0Q6DQo+ID4gKwkJcmV0dXJuIFBPV0VSX0RPTUFJTl9BVVhfRDsNCj4gPiArCWNhc2Ug QVVYX0NIX0Y6DQo+ID4gKwkJcmV0dXJuIFBPV0VSX0RPTUFJTl9BVVhfRjsNCj4gPiArCWRlZmF1 bHQ6DQo+ID4gKwkJTUlTU0lOR19DQVNFKGludGVsX2RwLT5hdXhfY2gpOw0KPiA+ICsJCXJldHVy biBQT1dFUl9ET01BSU5fQVVYX0E7DQo+ID4gKwl9DQo+ID4gIH0NCj4gPiAgDQo+ID4gIHN0YXRp YyBpOTE1X3JlZ190IGc0eF9hdXhfY3RsX3JlZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsDQo+ID4gLQkJCQkgIGVudW0gcG9ydCBwb3J0KQ0KPiA+ICsJCQkJICBlbnVtIGF1eF9j aCBhdXhfY2gpDQo+ID4gIHsNCj4gPiAtCXN3aXRjaCAocG9ydCkgew0KPiA+IC0JY2FzZSBQT1JU X0I6DQo+ID4gLQljYXNlIFBPUlRfQzoNCj4gPiAtCWNhc2UgUE9SVF9EOg0KPiA+IC0JCXJldHVy biBEUF9BVVhfQ0hfQ1RMKHBvcnQpOw0KPiA+ICsJc3dpdGNoIChhdXhfY2gpIHsNCj4gPiArCWNh c2UgQVVYX0NIX0I6DQo+ID4gKwljYXNlIEFVWF9DSF9DOg0KPiA+ICsJY2FzZSBBVVhfQ0hfRDoN Cj4gPiArCQlyZXR1cm4gRFBfQVVYX0NIX0NUTChhdXhfY2gpOw0KPiA+ICAJZGVmYXVsdDoNCj4g PiAtCQlNSVNTSU5HX0NBU0UocG9ydCk7DQo+ID4gLQkJcmV0dXJuIERQX0FVWF9DSF9DVEwoUE9S VF9CKTsNCj4gPiArCQlNSVNTSU5HX0NBU0UoYXV4X2NoKTsNCj4gPiArCQlyZXR1cm4gRFBfQVVY X0NIX0NUTChBVVhfQ0hfQik7DQoNClNob3VsZG4ndCBpbnRlbF9kcC0+YXV4X2NoIGNoYW5nZSB0 b28gaWYgd2UgYXJlIHN3aXRjaGluZyB0byBmYWxsYmFjaw0KZGVmYXVsdCByZWdpc3RlcnM/DQoN ClBhdGNoIDMvMyBhc3NpZ25zIGludGVsX2RwLT5hdXhfY2ggYW5kIHRoZW4gYXNzaWducyBjb250 cm9sIGFuZCBkYXRhDQpyZWdpc3RlcnMuDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK