All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/preemption: Allow preemption between submission ports
Date: Thu, 22 Feb 2018 14:36:01 +0000	[thread overview]
Message-ID: <151931016112.26255.14239968207579178798@mail.alporthouse.com> (raw)
In-Reply-To: <20180222142229.14517-1-chris@chris-wilson.co.uk>

Quoting Chris Wilson (2018-02-22 14:22:29)
> Sometimes we need to boost the priority of an in-flight request, which
> may lead to the situation where the second submission port then contains
> a higher priority context than the first and so we need to inject a
> preemption event. To do so we must always check inside
> execlists_dequeue() whether there is a priority inversion between the
> ports themselves as well as the head of the priority sorted queue, and we
> cannot just skip dequeuing if the queue is empty.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Note this probably merits a Fixes tag. Outside of igt causing priority
inversion between GPU hogs, is it a big enough problem to deserve
sending to stable@?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-02-22 14:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 14:11 [PATCH] drm/i915/preemption: Allow preemption between submission ports Chris Wilson
2018-02-22 14:22 ` Chris Wilson
2018-02-22 14:36   ` Chris Wilson [this message]
2018-02-23 14:06   ` Mika Kuoppala
2018-02-23 14:23     ` Chris Wilson
2018-02-23 15:18   ` Mika Kuoppala
2018-02-23 16:41     ` Chris Wilson
2018-02-22 14:59 ` ✓ Fi.CI.BAT: success for drm/i915/preemption: Allow preemption between submission ports (rev2) Patchwork
2018-02-22 19:48 ` ✓ Fi.CI.IGT: " Patchwork
2018-02-23 13:35 ` [PATCH] drm/i915/preemption: Allow preemption between submission ports Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151931016112.26255.14239968207579178798@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.