From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227MV8AZ3KBCADiqwxqSB7mATsr4WmRivZn9CJ95PKh5HUii2m8pQD1CK4dVJ4URe/q840cM ARC-Seal: i=1; a=rsa-sha256; t=1519315344; cv=none; d=google.com; s=arc-20160816; b=tDOLu3CULbcaU5W0w8Pq6tVdZj4foibDyDRbl48tzG1lXN0CjtgyuFpu1XGiLa+XZw PQCEUFyW4dswm+iZ5GawbBF3/uJgh5Xr0ZP3mMZVLhkjkTj6jBwElmP7PuQazINCBa2A 0R/MZQRyJxA64IFhIR/Nf9vWf4vdU/maVScD0ZqwM+kyJJaGfHpCpOL4cTkQIK/VgLpu OI84lBLMVqWOQhxG0aTsYACcvZ+vFXW5cKgd6ebdhqs8RsVofl6m0MsZ13cWsf+aXP2h RGv9ycsRkdI/RN3bhDz5F7FnQB2PdlbmkrSKcJmiS4yyXP8JX9tVFORUHLCpn0QD0wg4 vnyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dmarc-filter:dkim-signature :dkim-signature:arc-authentication-results; bh=CoeaFqstDmrs9gFUWcmFWtXF1LiGQM/ckGF+XbTnCTc=; b=he58NTTNvxO1LFM6+ocfmLoiJrRRJ5G2BE671HXS6Rc36PQoXPn8vaG64Al7tR2T6m UegrMu7WxKict3B3ZNGLip6y/ptpWjGARFjIS8eKlOfYyof5rCJOJIo5M5Ag01f4JIKE +PyvA5ubmdiWCV3kYfMOwaOv5dWb1zntBN2Fhsz+bhet+Zte13JyypDpk5C1XAnwNttL awXpNkWNe640aRV18CupTEj3kRpvc31WYhVJt4rNrZ0MwnTweDE8eN+3n0BZHsAQ1eN1 MbogawBHhrrotZvBjm3Ki1Yu9XdCGv7nuT3k9fKh5VWeridlZQgE+RBqWEIdNm2xK8ZX wRIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ydv0zFi5; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ydv0zFi5; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ydv0zFi5; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ydv0zFi5; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B600E607CF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v10 0/7] Address error and recovery for AER and DPC Date: Thu, 22 Feb 2018 21:32:05 +0530 Message-Id: <1519315332-26852-1-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1593086399695598263?= X-GMAIL-MSGID: =?utf-8?q?1593117606085826918?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: This patch set brings in error handling support for DPC The current implementation of AER and error message broadcasting to the EP driver is tightly coupled and limited to AER service driver. It is important to factor out broadcasting and other link handling callbacks. So that not only when AER gets triggered, but also when DPC get triggered (for e.g. ERR_FATAL), callbacks are handled appropriately. DPC should enumerate the devices after recovering the link, which is achieved by implementing error_resume callback. Changes since v9: Sinan's comments addressed. Changes since v8: Fixed Kbuild errors. Changes since v7: Rebased the code on pci master > https://kernel.googlesource.com/pub/scm/linux/kernel/git/helgaas/pci Changes since v6: Sinan's and Stefan's comments implemented. > reordered patch 6 and 7 > cleaned up Changes since v5: Sinan's and Keith's comments incorporated. > made separate patch for mutex > unified error repotting codes into driver/pci/pci.h > got rid of wait link active/inactive and made generic function in driver/pci/pci.c Changes since v4: Bjorn's comments incorporated. > Renamed only do_recovery. > moved the things more locally to drivers/pci/pci.h Changes since v3: Bjorn's comments incorporated. > Made separate patch renaming generic pci_err.c > Introduce pci_err.h to contain all the error types and recovery > removed all the dependencies on pci.h Changes since v2: Based on feedback from Keith: " When DPC is triggered due to receipt of an uncorrectable error Message, the Requester ID from the Message is recorded in the DPC Error Source ID register and that Message is discarded and not forwarded Upstream. " Removed the patch where AER checks if DPC service is active Changes since v1: Kbuild errors fixed: > pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (7): PCI/AER: Rename error recovery to generic pci naming PCI/AER: factor out error reporting from AER PCI/ERR: add mutex to synchronize recovery PCI/DPC: Unify and plumb error handling into DPC PCI/AER: Unify aer error defines at single space PCI/DPC: Enumerate the devices after DPC trigger event PCI: Unify wait for link active into generic pci drivers/acpi/apei/ghes.c | 1 + drivers/pci/hotplug/pciehp_hpc.c | 21 +- drivers/pci/pci.c | 39 +++- drivers/pci/pci.h | 11 + drivers/pci/pcie/Makefile | 2 +- drivers/pci/pcie/aer/aerdrv.h | 30 --- drivers/pci/pcie/aer/aerdrv_core.c | 293 +------------------------- drivers/pci/pcie/aer/aerdrv_errprint.c | 1 + drivers/pci/pcie/pcie-dpc.c | 115 ++++++++++- drivers/pci/pcie/pcie-err.c | 366 +++++++++++++++++++++++++++++++++ drivers/pci/pcie/portdrv.h | 2 + include/linux/aer.h | 4 - include/linux/pci.h | 1 + 13 files changed, 534 insertions(+), 352 deletions(-) create mode 100644 drivers/pci/pcie/pcie-err.c -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.