From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Subject: [ndctl PATCH] ndctl, test: kill usage of fallocate in firmware-update.sh
Date: Thu, 22 Feb 2018 22:59:22 -0800 [thread overview]
Message-ID: <151936916209.18166.8915957818264326430.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
The 'fallocate -l 196608 $image' step in the test fails when $image is
on an NFS mount. Use dd instead to create a sparse file. We do not need
to allocate anything since we are only writing zeros.
Cc: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
test/firmware-update.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/firmware-update.sh b/test/firmware-update.sh
index 0d5bcdb3cc42..173647218c28 100755
--- a/test/firmware-update.sh
+++ b/test/firmware-update.sh
@@ -49,7 +49,7 @@ detect()
do_tests()
{
- fallocate -l 196608 $image
+ dd if=/dev/zero of=$image bs=1 count=1 skip=196607
$ndctl update-firmware -d $dev -f $image
}
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next reply other threads:[~2018-02-23 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 6:59 Dan Williams [this message]
2018-02-23 20:58 ` [ndctl PATCH] ndctl, test: kill usage of fallocate in firmware-update.sh Ross Zwisler
2018-02-23 21:45 ` Dan Williams
2018-02-23 21:56 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151936916209.18166.8915957818264326430.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.